[PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Chris Blake]

Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
blink support. However, blink support isn't supported by the GPIO
driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
MX100-HW.

Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
---

Changelog:
V3: Update commit message format and update contributor message.
V2: Updated commit message, and added Christian Lamparter as a
contributor.
V1: Initial Patch

 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 3bbb29a7e7a5..f10e53187f67 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_DH89XXCC] = {
 		.name = "DH89xxCC",
 		.iTCO_version = 2,
+		.gpio_version = ICH_V5_GPIO,
 	},
 	[LPC_PPT] = {
 		.name = "Panther Point",
-- 
2.25.1

Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Chris]

On Mon, Jun 7, 2021 at 6:35 PM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
>
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>
> Changelog:
> V3: Update commit message format and update contributor message.
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
> V1: Initial Patch
>
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 3bbb29a7e7a5..f10e53187f67 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>         [LPC_DH89XXCC] = {
>                 .name = "DH89xxCC",
>                 .iTCO_version = 2,
> +               .gpio_version = ICH_V5_GPIO,
>         },
>         [LPC_PPT] = {
>                 .name = "Panther Point",
> --
> 2.25.1
>

Hello,

Just curious if there's anything I can do to help get this reviewed
for merge, thanks.

Regards,
Chris B

Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Lee Jones]

On Fri, 02 Jul 2021, Chris wrote:

> On Mon, Jun 7, 2021 at 6:35 PM Chris Blake <chrisrblake93@gmail.com> wrote:
> >
> > Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> > is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> > blink support. However, blink support isn't supported by the GPIO
> > driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> > MX100-HW.
> >
> > Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> > Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> > ---
> >
> > Changelog:
> > V3: Update commit message format and update contributor message.
> > V2: Updated commit message, and added Christian Lamparter as a
> > contributor.
> > V1: Initial Patch
> >
> >  drivers/mfd/lpc_ich.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> > index 3bbb29a7e7a5..f10e53187f67 100644
> > --- a/drivers/mfd/lpc_ich.c
> > +++ b/drivers/mfd/lpc_ich.c
> > @@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
> >         [LPC_DH89XXCC] = {
> >                 .name = "DH89xxCC",
> >                 .iTCO_version = 2,
> > +               .gpio_version = ICH_V5_GPIO,
> >         },
> >         [LPC_PPT] = {
> >                 .name = "Panther Point",
> >
> 
> Hello,
> 
> Just curious if there's anything I can do to help get this reviewed
> for merge, thanks.

Apologies, this had slipped through the gaps.

Looks simple enough.  I'll review it for v5.15 once -rc1 is out.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Lee Jones]

On Mon, 07 Jun 2021, Chris Blake wrote:

> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
> 
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> 
> Changelog:
> V3: Update commit message format and update contributor message.
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
> V1: Initial Patch
> 
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog