All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <promsoft@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [V2 12/15] S3c64xx: clear GPIO, Interrupt, Watchdog variable.
Date: Tue, 24 Jul 2012 17:47:47 +0900	[thread overview]
Message-ID: <CALrBrZ0MNvw_dEwPxAAhYR2PMyVD_Tr6M3_iOfOwZGT89xpRxA@mail.gmail.com> (raw)
In-Reply-To: <1342195913-25161-13-git-send-email-bocui107@gmail.com>

Dear Zhong Hongbo

On 14 July 2012 01:11, Zhong Hongbo <bocui107@gmail.com> wrote:
> From: Zhong Hongbo <bocui107@gmail.com>
>
> Signed-off-by: Zhong Hongbo <bocui107@gmail.com>
> ---
> Change for V2:
>         - None.
> ---
>  arch/arm/include/asm/arch-s3c64xx/s3c6400.h |  260 ---------------------------
>  board/samsung/smdk6400/lowlevel_init.S      |   23 ++--
>  2 files changed, 11 insertions(+), 272 deletions(-)
>
> diff --git a/board/samsung/smdk6400/lowlevel_init.S b/board/samsung/smdk6400/lowlevel_init.S
> index 79d5ab3..02828e8 100644
> --- a/board/samsung/smdk6400/lowlevel_init.S
> +++ b/board/samsung/smdk6400/lowlevel_init.S
> @@ -46,13 +46,13 @@ lowlevel_init:
>         /* LED on only #8 */
>         ldr     r0, =ELFIN_GPIO_BASE
>         ldr     r1, =0x55540000
> -       str     r1, [r0, #GPNCON_OFFSET]
> +       str     r1, [r0, #0x830]        @ GPNCON_OFFSET
>
>         ldr     r1, =0x55555555
> -       str     r1, [r0, #GPNPUD_OFFSET]
> +       str     r1, [r0, #0x838]        @ GPNPUD_OFFSET
>
>         ldr     r1, =0xf000
> -       str     r1, [r0, #GPNDAT_OFFSET]
> +       str     r1, [r0, #0x834]        @ GPNDAT_OFFSET
>
>         /* Disable Watchdog */
>         ldr     r0, =0x7e000000         @0x7e004000
> @@ -61,7 +61,7 @@ lowlevel_init:
>         str     r1, [r0]
>
>         /* External interrupt pending clear */
> -       ldr     r0, =(ELFIN_GPIO_BASE+EINTPEND_OFFSET)  /*EINTPEND*/
> +       ldr     r0, =(ELFIN_GPIO_BASE + 0x924)  /*EINTPEND*/
>         ldr     r1, [r0]
>         str     r1, [r0]
>
> @@ -70,18 +70,18 @@ lowlevel_init:
>
>         /* Disable all interrupts (VIC0 and VIC1) */
>         mvn     r3, #0x0
> -       str     r3, [r0, #oINTMSK]
> -       str     r3, [r1, #oINTMSK]
> +       str     r3, [r0, #0x14]         @ INTMSK
> +       str     r3, [r1, #0x14]
>
>         /* Set all interrupts as IRQ */
>         mov     r3, #0x0
> -       str     r3, [r0, #oINTMOD]
> -       str     r3, [r1, #oINTMOD]
> +       str     r3, [r0, #0x0c]         @ INTMOD
> +       str     r3, [r1, #0x0c]
>
>         /* Pending Interrupt Clear */
>         mov     r3, #0x0
> -       str     r3, [r0, #oVECTADDR]
> -       str     r3, [r1, #oVECTADDR]
> +       str     r3, [r0, #0xf00]        @ VECTADDR
> +       str     r3, [r1, #0xf00]
>
>  #ifdef CONFIG_SPL_BUILD
>         /* init system clock */
> @@ -136,7 +136,6 @@ wakeup_reset:
>         mov     pc, r1
>         nop
>         nop
> -
>  /*
>   * system_clock_init: Initialize core clock and bus clock.
>   * void system_clock_init(void)
> @@ -241,7 +240,7 @@ uart_asm_init:
>         /* set GPIO to enable UART */
>         ldr     r0, =ELFIN_GPIO_BASE
>         ldr     r1, =0x220022
> -       str     r1, [r0, #GPACON_OFFSET]
> +       str     r1, [r0, #0x0]          @ GPACON_OFFSET
>         mov     pc, lr
>  #endif
>

Too many magic numbers.
Please fix it globally.

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net

  reply	other threads:[~2012-07-24  8:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-13 16:11 [U-Boot] V2 S3c64xx: Switch all I/O to use readl/writel functio and Clear variable Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 01/15] SMDK6400: Move smdk6400 board from Makefile to boards.cfg Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 02/15] S3C64XX: Switch to use readl/writel to operate nand flash Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 03/15] S3C64XX: Use readl/writel to operate uart Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] =?yes?q?=5BV2=2004/15=5D=20S3C64XX=3A=20add=20pwm=20for=20s3c64xx=20support?= Zhong Hongbo
2012-07-13 16:21   ` [U-Boot] [V2 04/15] S3C64XX: add pwm for s3c64xx support Zhong Hongbo
2012-07-19 22:04   ` Zhong Hongbo
2012-07-20  3:14     ` Minkyu Kang
2012-07-13 16:11 ` [U-Boot] [V2 05/15] S3C64XX: reference s5p cpu time system for s3c64xx timer Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 06/15] S3C64xx: mov cpu_init.S to the board directory Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 07/15] S3C6400: Delete nand_spl for S3C6400 Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 08/15] S3C6400: Adopt SPL framwork to support spl for nand flash Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 09/15] arm1176: Fixed No relocation Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 10/15] S3C64XX: Change SROM init to use read/write operation Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 11/15] S3C64XX: Switch to use read/writel to operation clock system Zhong Hongbo
2012-07-24  8:58   ` Minkyu Kang
2012-07-24 14:40     ` Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 12/15] S3c64xx: clear GPIO, Interrupt, Watchdog variable Zhong Hongbo
2012-07-24  8:47   ` Minkyu Kang [this message]
2012-07-13 16:11 ` [U-Boot] [V2 13/15] S3C6400: clear memory init variable Zhong Hongbo
2012-07-24  8:44   ` Minkyu Kang
2012-07-13 16:11 ` [U-Boot] [V2 14/15] S3C64XX: Move s3c6400.h to cpu.h to support s3c6410 board Zhong Hongbo
2012-07-24  2:38   ` Minkyu Kang
2012-07-24 14:45     ` Zhong Hongbo
2012-07-13 16:11 ` [U-Boot] [V2 15/15] S3C6400: Remove the unused variable for S3C6400 Zhong Hongbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALrBrZ0MNvw_dEwPxAAhYR2PMyVD_Tr6M3_iOfOwZGT89xpRxA@mail.gmail.com \
    --to=promsoft@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.