All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling
@ 2016-03-15 15:07 Óscar Gómez Fuente
  2016-03-15 15:49 ` Peter Korsgaard
  0 siblings, 1 reply; 5+ messages in thread
From: Óscar Gómez Fuente @ 2016-03-15 15:07 UTC (permalink / raw)
  To: buildroot

Yes, I did both, but I've just checked again and It doesn't work.

../output/target/usr/sbin$ ls
addgroup  chroot    deluser   ether-wake  i2cdetect  i2cset    loadfont
setlogcons
adduser   crond     dnsd      fbset       i2cdump    inetd     rdate
 vcfiled
arping    delgroup  dropbear  fdformat    i2cget     killall5  readprofile

Oscar Gomez Fuente.

On 11 March 2016 at 15:31, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "?scar" == ?scar G?mez Fuente <oscargomezf@gmail.com> writes:
>
>  > Hi,
>  > I'm using the last release buildroot-2016.02 and I'm trying to test some
>  > dtb files on my raspberry pi 2 (because It seems to be it doesn't work
>  > well) so I'm trying to add the package to debug vcdbg:
>
>  > Target package ---> Hardware handling  ---> Firmware ---> vcdbg
>
>  > The compilation was successful but the file /usr/sbin/vcdbg doesn't
> exist
>  > in the $TARGET_DIR
>
> From package/rpi-firmware/rpi-firmware.mk:
>
> ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG),y)
> define RPI_FIRMWARE_INSTALL_TARGET_CMDS
>         $(INSTALL) -d -m 0700 $(@D)/$(if
> BR2_ARM_EABIHF,hardfp/)opt/vc/bin/vcdbg \
>                 $(TARGET_DIR)/usr/sbin/vcdbg
> endef
> endif # INSTALL_VCDBG
>
> So it should be in usr/sbin. Did you do a clean build (or at least rm
> -rf output/build/rpi-firmware-*) when you enabled the VCDBG option?
>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160315/6431a4ff/attachment.html>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling
  2016-03-15 15:07 [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling Óscar Gómez Fuente
@ 2016-03-15 15:49 ` Peter Korsgaard
  2016-03-16  8:42   ` Óscar Gómez Fuente
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2016-03-15 15:49 UTC (permalink / raw)
  To: buildroot

>>>>> "?scar" == ?scar G?mez Fuente <oscargomezf@gmail.com> writes:

 > Yes, I did both, but I've just checked again and It doesn't work.
 > ../output/target/usr/sbin$ ls
 > addgroup  chroot    deluser   ether-wake  i2cdetect  i2cset    loadfont
 > setlogcons
 > adduser   crond     dnsd      fbset       i2cdump    inetd     rdate
 >  vcfiled
 > arping    delgroup  dropbear  fdformat    i2cget     killall5  readprofile

Sorry, I just had a closer look, and the vcdbg handling logic is broken
:/ I've pushed a fix to current git to correct it:

commit 41276ae12aefb8a3e69df365aa2240d29ddca776
Author: Peter Korsgaard <peter@korsgaard.com>
Date:   Tue Mar 15 16:43:10 2016 +0100

    rpi-firmware: unbreak _INSTALL_VCDBG logic
    
    Commit d16b32a401 (package/rpi-firmware: add option to install vcdbg) added
    a sub option to install the vcdbg tool, but the commit unfortunately
    contained two errors:
    
    - The package sets _INSTALL_TARGET = NO, so the _TARGET_CMDS are never used
    - The install command used -d (handle arguments as directories) instead of
      -D (create needed directories)
    
    Fix these issues.
    
    Cc: yann.morin.1998 at free.fr
    Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling
  2016-03-15 15:49 ` Peter Korsgaard
@ 2016-03-16  8:42   ` Óscar Gómez Fuente
  0 siblings, 0 replies; 5+ messages in thread
From: Óscar Gómez Fuente @ 2016-03-16  8:42 UTC (permalink / raw)
  To: buildroot

Hi Peter

Thank you very much. I made the changes you told me:

--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -8,7 +8,7 @@ RPI_FIRMWARE_VERSION =
22d8c910f4c53118f9cf85c038d7d8e307efc110
 RPI_FIRMWARE_SITE = $(call
github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3c
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-RPI_FIRMWARE_INSTALL_TARGET = NO
+RPI_FIRMWARE_INSTALL_TARGET = YES
 RPI_FIRMWARE_INSTALL_IMAGES = YES

 RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
@@ -31,7 +31,7 @@ endif

 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG),y)
 define RPI_FIRMWARE_INSTALL_TARGET_CMDS
-       $(INSTALL) -d -m 0700 $(@D)/$(if
BR2_ARM_EABIHF,hardfp/)opt/vc/bin/vcdbg \
+       $(INSTALL) -D -m 0700 $(@D)/$(if
BR2_ARM_EABIHF,hardfp/)opt/vc/bin/vcdbg \
                $(TARGET_DIR)/usr/sbin/vcdbg
 endef
 endif # INSTALL_VCDBG

And now the file exists in the folder:  /usr/sbin/vcdbg and I checked that
it works fine on my raspberry pi 2.

Best regards.

On 15 March 2016 at 16:49, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "?scar" == ?scar G?mez Fuente <oscargomezf@gmail.com> writes:
>
>  > Yes, I did both, but I've just checked again and It doesn't work.
>  > ../output/target/usr/sbin$ ls
>  > addgroup  chroot    deluser   ether-wake  i2cdetect  i2cset    loadfont
>  > setlogcons
>  > adduser   crond     dnsd      fbset       i2cdump    inetd     rdate
>  >  vcfiled
>  > arping    delgroup  dropbear  fdformat    i2cget     killall5
> readprofile
>
> Sorry, I just had a closer look, and the vcdbg handling logic is broken
> :/ I've pushed a fix to current git to correct it:
>
> commit 41276ae12aefb8a3e69df365aa2240d29ddca776
> Author: Peter Korsgaard <peter@korsgaard.com>
> Date:   Tue Mar 15 16:43:10 2016 +0100
>
>     rpi-firmware: unbreak _INSTALL_VCDBG logic
>
>     Commit d16b32a401 (package/rpi-firmware: add option to install vcdbg)
> added
>     a sub option to install the vcdbg tool, but the commit unfortunately
>     contained two errors:
>
>     - The package sets _INSTALL_TARGET = NO, so the _TARGET_CMDS are never
> used
>     - The install command used -d (handle arguments as directories)
> instead of
>       -D (create needed directories)
>
>     Fix these issues.
>
>     Cc: yann.morin.1998 at free.fr
>     Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>
> --
> Venlig hilsen,
> Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160316/699922c9/attachment.html>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling
  2016-03-11 12:59 Óscar Gómez Fuente
@ 2016-03-11 14:31 ` Peter Korsgaard
  0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2016-03-11 14:31 UTC (permalink / raw)
  To: buildroot

>>>>> "?scar" == ?scar G?mez Fuente <oscargomezf@gmail.com> writes:

 > Hi,
 > I'm using the last release buildroot-2016.02 and I'm trying to test some
 > dtb files on my raspberry pi 2 (because It seems to be it doesn't work
 > well) so I'm trying to add the package to debug vcdbg:

 > Target package ---> Hardware handling  ---> Firmware ---> vcdbg

 > The compilation was successful but the file /usr/sbin/vcdbg doesn't exist
 > in the $TARGET_DIR

From package/rpi-firmware/rpi-firmware.mk:

ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG),y)
define RPI_FIRMWARE_INSTALL_TARGET_CMDS
        $(INSTALL) -d -m 0700 $(@D)/$(if BR2_ARM_EABIHF,hardfp/)opt/vc/bin/vcdbg \
                $(TARGET_DIR)/usr/sbin/vcdbg
endef
endif # INSTALL_VCDBG

So it should be in usr/sbin. Did you do a clean build (or at least rm
-rf output/build/rpi-firmware-*) when you enabled the VCDBG option?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling
@ 2016-03-11 12:59 Óscar Gómez Fuente
  2016-03-11 14:31 ` Peter Korsgaard
  0 siblings, 1 reply; 5+ messages in thread
From: Óscar Gómez Fuente @ 2016-03-11 12:59 UTC (permalink / raw)
  To: buildroot

Hi,

I'm using the last release buildroot-2016.02 and I'm trying to test some
dtb files on my raspberry pi 2 (because It seems to be it doesn't work
well) so I'm trying to add the package to debug vcdbg:

Target package ---> Hardware handling  ---> Firmware ---> vcdbg

The compilation was successful but the file /usr/sbin/vcdbg doesn't exist
in the $TARGET_DIR

Can everyone help me? I don't know If It could be a bug.

Best regards.

Oscar Gomez Fuente
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160311/51f05661/attachment.html>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-03-16  8:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 15:07 [Buildroot] [rpi-firmware] I can't find the file /usr/sbin/vcdbg after compiling Óscar Gómez Fuente
2016-03-15 15:49 ` Peter Korsgaard
2016-03-16  8:42   ` Óscar Gómez Fuente
  -- strict thread matches above, loose matches on Subject: below --
2016-03-11 12:59 Óscar Gómez Fuente
2016-03-11 14:31 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.