From: Shakeel Butt <shakeelb@google.com> To: Zefan Li <lizefan@huawei.com> Cc: Michal Hocko <mhocko@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>, Vladimir Davydov <vdavydov.dev@gmail.com>, Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <guro@fb.com> Subject: Re: [PATCH v2] memcg: Fix memcg_kmem_bypass() for remote memcg charging Date: Wed, 13 May 2020 05:22:13 -0700 [thread overview] Message-ID: <CALvZod5EzSAdFJh-wjN9TfdUwsjL5Zfn6xao5S9nWvhiL+oL+w@mail.gmail.com> (raw) In-Reply-To: <3a721f62-5a66-8bc5-247b-5c8b7c51c555@huawei.com> On Wed, May 13, 2020 at 4:47 AM Zefan Li <lizefan@huawei.com> wrote: > > While trying to use remote memcg charging in an out-of-tree kernel module > I found it's not working, because the current thread is a workqueue thread. > > As we will probably encounter this issue in the future as the users of > memalloc_use_memcg() grow, it's better we fix it now. > > Signed-off-by: Zefan Li <lizefan@huawei.com> > --- > > v2: add a comment as sugguested by Michal. and add changelog to explain why > upstream kernel needs this fix. > > --- > > mm/memcontrol.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a3b97f1..43a12ed 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2802,6 +2802,9 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg, > > static inline bool memcg_kmem_bypass(void) > { > + /* Allow remote memcg charging in kthread contexts. */ > + if (unlikely(current->active_memcg)) > + return false; What about __GFP_ACCOUNT allocations in the interrupt context? e.g. memalloc_use_memcg(memcg); --->interrupt --->alloc_page(GFP_KERNEL_ACCOUNT) in interrupt context. alloc_page(GFP_KERNEL_ACCOUNT); memalloc_unuse_memcg(); > if (in_interrupt() || !current->mm || (current->flags & PF_KTHREAD)) > return true; > return false; > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Cc: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org> Subject: Re: [PATCH v2] memcg: Fix memcg_kmem_bypass() for remote memcg charging Date: Wed, 13 May 2020 05:22:13 -0700 [thread overview] Message-ID: <CALvZod5EzSAdFJh-wjN9TfdUwsjL5Zfn6xao5S9nWvhiL+oL+w@mail.gmail.com> (raw) In-Reply-To: <3a721f62-5a66-8bc5-247b-5c8b7c51c555-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> On Wed, May 13, 2020 at 4:47 AM Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote: > > While trying to use remote memcg charging in an out-of-tree kernel module > I found it's not working, because the current thread is a workqueue thread. > > As we will probably encounter this issue in the future as the users of > memalloc_use_memcg() grow, it's better we fix it now. > > Signed-off-by: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> > --- > > v2: add a comment as sugguested by Michal. and add changelog to explain why > upstream kernel needs this fix. > > --- > > mm/memcontrol.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a3b97f1..43a12ed 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2802,6 +2802,9 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg, > > static inline bool memcg_kmem_bypass(void) > { > + /* Allow remote memcg charging in kthread contexts. */ > + if (unlikely(current->active_memcg)) > + return false; What about __GFP_ACCOUNT allocations in the interrupt context? e.g. memalloc_use_memcg(memcg); --->interrupt --->alloc_page(GFP_KERNEL_ACCOUNT) in interrupt context. alloc_page(GFP_KERNEL_ACCOUNT); memalloc_unuse_memcg(); > if (in_interrupt() || !current->mm || (current->flags & PF_KTHREAD)) > return true; > return false; > -- > 2.7.4 >
next prev parent reply other threads:[~2020-05-13 12:22 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 7:28 [PATCH] memcg: Fix memcg_kmem_bypass() for remote memcg charging Zefan Li 2020-05-13 7:28 ` Zefan Li 2020-05-13 9:05 ` Michal Hocko 2020-05-13 9:05 ` Michal Hocko 2020-05-13 11:19 ` Zefan Li 2020-05-13 11:19 ` Zefan Li 2020-05-13 11:29 ` Michal Hocko 2020-05-13 11:29 ` Michal Hocko 2020-05-13 11:47 ` [PATCH v2] " Zefan Li 2020-05-13 11:47 ` Zefan Li 2020-05-13 12:22 ` Shakeel Butt [this message] 2020-05-13 12:22 ` Shakeel Butt 2020-05-13 13:05 ` Johannes Weiner 2020-05-13 13:05 ` Johannes Weiner 2020-05-13 16:11 ` Roman Gushchin 2020-05-13 16:11 ` Roman Gushchin 2020-05-14 1:16 ` Zefan Li 2020-05-14 1:16 ` Zefan Li 2020-05-14 22:52 ` Roman Gushchin 2020-05-14 22:52 ` Roman Gushchin 2020-05-15 6:56 ` Michal Hocko 2020-05-15 6:56 ` Michal Hocko 2020-05-15 8:20 ` Zefan Li 2020-05-15 8:20 ` Zefan Li 2020-05-15 8:34 ` Michal Hocko 2020-05-15 8:34 ` Michal Hocko 2020-05-15 16:22 ` Shakeel Butt 2020-05-15 16:22 ` Shakeel Butt 2020-05-15 17:31 ` Roman Gushchin 2020-05-15 17:31 ` Roman Gushchin 2020-05-18 9:13 ` Michal Hocko 2020-05-18 9:13 ` Michal Hocko 2020-05-26 1:25 ` [PATCH v3] " Zefan Li 2020-05-26 1:25 ` Zefan Li 2020-05-26 15:53 ` Roman Gushchin 2020-05-26 15:53 ` Roman Gushchin 2020-05-27 16:50 ` Shakeel Butt 2020-05-27 16:50 ` Shakeel Butt 2020-05-28 14:44 ` Michal Hocko 2020-05-28 14:44 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALvZod5EzSAdFJh-wjN9TfdUwsjL5Zfn6xao5S9nWvhiL+oL+w@mail.gmail.com \ --to=shakeelb@google.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=linux-mm@kvack.org \ --cc=lizefan@huawei.com \ --cc=mhocko@kernel.org \ --cc=vdavydov.dev@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.