All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Herbert <tom@herbertland.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch net-next v2 0/5] fou: some fixes and updates
Date: Fri, 10 Apr 2015 13:38:36 -0700	[thread overview]
Message-ID: <CALx6S37WGT7p=ZMLc+ZOiXmvjQxaxG+k6yR2m2h9SEn5Av5xjg@mail.gmail.com> (raw)
In-Reply-To: <1428692430-14465-1-git-send-email-xiyou.wangcong@gmail.com>

On Fri, Apr 10, 2015 at 12:00 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> Patch 1~3 fix some minor bugs in net/ipv4/fou.c, the only
> thing I am not sure is if it's too late to change the
> byte order of FOU_ATTR_PORT, if so we have to fix iproute2
> instead of kernel.
>
Is this a relic from previous patch set, or is there a reason you want
to make this hbo?

> Patch 4~5 add some new features to make it complete.
>
> v2: make fou->port be16 too
>
> Cong Wang (5):
>   fou: avoid calling udp_del_offload() twice
>   fou: exit early when parsing config fails
>   fou: always use be16 for port
>   fou: add network namespace support
>   fou: implement FOU_CMD_GET
>

I assume you didn't see any adverse performance impact with these patches?

Acked-by: Tom Herbert <tom@herbertland.com>

Thanks!
Tom

>  include/uapi/linux/fou.h |   1 +
>  net/ipv4/fou.c           | 230 +++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 186 insertions(+), 45 deletions(-)
>
> --
> 1.8.3.1
>

  parent reply	other threads:[~2015-04-10 20:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 19:00 [Patch net-next v2 0/5] fou: some fixes and updates Cong Wang
2015-04-10 19:00 ` [Patch net-next v2 1/5] fou: avoid calling udp_del_offload() twice Cong Wang
2015-04-10 19:00 ` [Patch net-next v2 2/5] fou: exit early when parsing config fails Cong Wang
2015-04-10 19:00 ` [Patch net-next v2 3/5] fou: always use be16 for port Cong Wang
2015-04-10 19:00 ` [Patch net-next v2 4/5] fou: add network namespace support Cong Wang
2015-04-10 19:00 ` [Patch net-next v2 5/5] fou: implement FOU_CMD_GET Cong Wang
2015-04-10 20:38 ` Tom Herbert [this message]
2015-04-10 20:50   ` [Patch net-next v2 0/5] fou: some fixes and updates Cong Wang
2015-04-13  1:25     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALx6S37WGT7p=ZMLc+ZOiXmvjQxaxG+k6yR2m2h9SEn5Av5xjg@mail.gmail.com' \
    --to=tom@herbertland.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.