[PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistake in mlx5_core_dbg debug message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
index 4d0db481f6c4..de2aed44ab85 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
@@ -101,7 +101,7 @@ int mlx5_core_reserved_gid_alloc(struct mlx5_core_dev *dev, int *gid_index)
 	if (index < 0)
 		return index;
 
-	mlx5_core_dbg(dev, "Allodating reserved GID %u\n", index);
+	mlx5_core_dbg(dev, "Allocating reserved GID %u\n", index);
 	*gid_index = index;
 	return 0;
 }
-- 
2.11.0

RE: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[Ilan Tayari]

> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Subject: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" ->
> "Allocating"
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> index 4d0db481f6c4..de2aed44ab85 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> @@ -101,7 +101,7 @@ int mlx5_core_reserved_gid_alloc(struct mlx5_core_dev
> *dev, int *gid_index)
>  	if (index < 0)
>  		return index;
> 
> -	mlx5_core_dbg(dev, "Allodating reserved GID %u\n", index);
> +	mlx5_core_dbg(dev, "Allocating reserved GID %u\n", index);
>  	*gid_index = index;
>  	return 0;
>  }
> --
> 2.11.0

Thank you Colin for the fix.

Reviewed-by: Ilan Tayari <ilant@mellanox.com>

RE: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[Ilan Tayari]

> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Subject: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" ->
> "Allocating"
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> index 4d0db481f6c4..de2aed44ab85 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c
> @@ -101,7 +101,7 @@ int mlx5_core_reserved_gid_alloc(struct mlx5_core_dev
> *dev, int *gid_index)
>  	if (index < 0)
>  		return index;
> 
> -	mlx5_core_dbg(dev, "Allodating reserved GID %u\n", index);
> +	mlx5_core_dbg(dev, "Allocating reserved GID %u\n", index);
>  	*gid_index = index;
>  	return 0;
>  }
> --
> 2.11.0

Thank you Colin for the fix.

Reviewed-by: Ilan Tayari <ilant@mellanox.com>

Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[David Miller]

From: Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Date: Fri, 30 Jun 2017 11:59:22 +0100

> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> 
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
> 
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>

Applied, thanks Colin.

Mellanox folks, I don't like how these lib/ objects are built.

I absolutely depend upon being able to try and build individual
object files, by name, in order to quickly smoke-test patches.
Like this:

[davem@kkuri net-next]$ make drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o

But I can't for these files:

scripts/Makefile.build:44: drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile: No such file or directory
make[1]: *** No rule to make target 'drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile'.  Stop.
Makefile:1663: recipe for target 'drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o' failed

Please fix this so that I can build all object files by name in this driver
again.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[David Miller]

From: Colin King <colin.king@canonical.com>
Date: Fri, 30 Jun 2017 11:59:22 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in mlx5_core_dbg debug message
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks Colin.

Mellanox folks, I don't like how these lib/ objects are built.

I absolutely depend upon being able to try and build individual
object files, by name, in order to quickly smoke-test patches.
Like this:

[davem@kkuri net-next]$ make drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o

But I can't for these files:

scripts/Makefile.build:44: drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile: No such file or directory
make[1]: *** No rule to make target 'drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile'.  Stop.
Makefile:1663: recipe for target 'drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o' failed

Please fix this so that I can build all object files by name in this driver
again.

Thanks.

Re: [PATCH][-next] net/mlx5: fix spelling mistake: "Allodating" -> "Allocating"

[Saeed Mahameed]

On Sun, Jul 2, 2017 at 12:40 AM, David Miller <davem@davemloft.net> wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Fri, 30 Jun 2017 11:59:22 +0100
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake in mlx5_core_dbg debug message
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Applied, thanks Colin.
>
> Mellanox folks, I don't like how these lib/ objects are built.
>
> I absolutely depend upon being able to try and build individual
> object files, by name, in order to quickly smoke-test patches.
> Like this:
>
> [davem@kkuri net-next]$ make drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o
>
> But I can't for these files:
>
> scripts/Makefile.build:44: drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile: No such file or directory
> make[1]: *** No rule to make target 'drivers/net/ethernet/mellanox/mlx5/core/lib/Makefile'.  Stop.
> Makefile:1663: recipe for target 'drivers/net/ethernet/mellanox/mlx5/core/lib/gid.o' failed
>
> Please fix this so that I can build all object files by name in this driver
> again.

Hi Dave,
We are going to provide a fix ASAP.

>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html