All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding
Date: Thu, 29 Nov 2018 16:03:52 -0800	[thread overview]
Message-ID: <CALzJLG-NQsxmVgc0naKSkLg4Vg5RYA==4eZJ08fmFho_F=JM5g@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpXe2BwPjZV_7ySmnzHk5h6UXveKeaqQc7oPbz-UPNp4Ug@mail.gmail.com>

On Wed, Nov 28, 2018 at 4:05 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Wed, Nov 28, 2018 at 3:57 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > But again, I kinda feel the hardware already does the sanity check,
> > otherwise we have much more serious trouble in mlx5e_lro_update_hdr()
> > which parses into TCP header.
> >
>
> While we are on this page, mlx5e_lro_update_hdr() incorrectly assumes
> TCP header is located right after struct iphdr, which is wrong if we could
> have IP options on this path.
>
> It could the hardware which already verified this corner case though.

yes HW will not do LRO in case of ip options, so no problem in
mlx5e_lro_update_hdr

  parent reply	other threads:[~2018-11-30 11:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  6:10 [Patch net v2] mlx5: fixup checksum for short ethernet frame padding Cong Wang
2018-11-28 15:00 ` Eric Dumazet
2018-11-28 22:16   ` Cong Wang
2018-11-28 23:50     ` Eric Dumazet
2018-11-28 23:57       ` Cong Wang
2018-11-29  0:05         ` Cong Wang
2018-11-29  0:14           ` Eric Dumazet
2018-11-30  0:03           ` Saeed Mahameed [this message]
2018-11-29  0:07         ` Eric Dumazet
2018-11-29  3:40           ` Cong Wang
2018-11-29  3:49             ` Eric Dumazet
2018-11-29  3:53               ` Cong Wang
2018-11-29  4:09                 ` Eric Dumazet
2018-11-30  0:30                   ` Saeed Mahameed
2018-12-03 23:17 ` David Miller
2018-12-03 23:45   ` Cong Wang
2018-12-04 19:21   ` Saeed Mahameed
2018-12-04 20:50     ` Cong Wang
2018-12-05  1:06       ` Saeed Mahameed
2018-12-05  2:15         ` Cong Wang
2018-12-13  8:40         ` Nikola Ciprich
2018-12-13 17:08           ` Saeed Mahameed
2018-12-14  9:33             ` Nikola Ciprich
2019-01-05 18:35             ` Nikola Ciprich
2019-01-06 11:10               ` Saeed Mahameed
2019-01-18  1:19                 ` Christoph Paasch
2019-01-19  0:45                   ` Saeed Mahameed
2019-01-22 11:35                     ` David Laight
2018-12-05  2:52 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALzJLG-NQsxmVgc0naKSkLg4Vg5RYA==4eZJ08fmFho_F=JM5g@mail.gmail.com' \
    --to=saeedm@dev.mellanox.co.il \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.