Redirect from NIC to TAP

Redirect from NIC to TAP

[Radu Stoenescu]

Hi

Is it possible to redirect packets from XDP program attached in driver
mode to a physical NIC to a TAP interface?

The same works fine if the XDP programs are attached in generic mode.

Best
-- 
Radu Stoenescu

Re: Redirect from NIC to TAP

[Jesper Dangaard Brouer]

On Tue, 9 Feb 2021 10:31:50 +0200
Radu Stoenescu <radu.stoe@gmail.com> wrote:

> Is it possible to redirect packets from XDP program attached in driver
> mode to a physical NIC to a TAP interface?

Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
Maybe Jason can remember?
(or point me to the relevant code that I can check).

> The same works fine if the XDP programs are attached in generic mode.

So, you have tried and it doesn't work.

What is your setup?

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Re: Redirect from NIC to TAP

[Radu Stoenescu]

Hello

My physical NIC is a Netronome (I can come back with exact model type
and driver version).

Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
It works when they are both in generic mode. I haven't tried other
combinations of attachment modes (one driver, other generic etc.).

Thanks

On Tue, Feb 9, 2021 at 11:21 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> On Tue, 9 Feb 2021 10:31:50 +0200
> Radu Stoenescu <radu.stoe@gmail.com> wrote:
>
> > Is it possible to redirect packets from XDP program attached in driver
> > mode to a physical NIC to a TAP interface?
>
> Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
> Maybe Jason can remember?
> (or point me to the relevant code that I can check).
>
> > The same works fine if the XDP programs are attached in generic mode.
>
> So, you have tried and it doesn't work.
>
> What is your setup?
>
> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer
>


-- 
Radu Stoenescu

Re: Redirect from NIC to TAP

[Maciej Fijalkowski]

On Tue, Feb 09, 2021 at 11:26:06AM +0200, Radu Stoenescu wrote:
> Hello
> 
> My physical NIC is a Netronome (I can come back with exact model type
> and driver version).
> 
> Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
> It works when they are both in generic mode. I haven't tried other
> combinations of attachment modes (one driver, other generic etc.).

Looks like Netronome driver still doesn't support XDP_REDIRECT in native
mode.

CC: Simon

Simon, any plans on adding support for redirect?

> 
> Thanks
> 
> On Tue, Feb 9, 2021 at 11:21 AM Jesper Dangaard Brouer
> <brouer@redhat.com> wrote:
> >
> > On Tue, 9 Feb 2021 10:31:50 +0200
> > Radu Stoenescu <radu.stoe@gmail.com> wrote:
> >
> > > Is it possible to redirect packets from XDP program attached in driver
> > > mode to a physical NIC to a TAP interface?
> >
> > Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
> > Maybe Jason can remember?
> > (or point me to the relevant code that I can check).
> >
> > > The same works fine if the XDP programs are attached in generic mode.
> >
> > So, you have tried and it doesn't work.
> >
> > What is your setup?
> >
> > --
> > Best regards,
> >   Jesper Dangaard Brouer
> >   MSc.CS, Principal Kernel Engineer at Red Hat
> >   LinkedIn: http://www.linkedin.com/in/brouer
> >
> 
> 
> -- 
> Radu Stoenescu

Re: Redirect from NIC to TAP

[Jason Wang]

On 2021/2/9 下午5:26, Radu Stoenescu wrote:
> Hello
>
> My physical NIC is a Netronome (I can come back with exact model type
> and driver version).
>
> Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
> It works when they are both in generic mode. I haven't tried other
> combinations of attachment modes (one driver, other generic etc.).


It should work. I tested with i40e/ixgbe/mlx4 in the past.

What eBPF program did you use? (Is it the one in samples/bpf?)

I would test it by myself.

(It's near to spring festival, so I can only check after the holiday).

Thanks


>
> Thanks
>
> On Tue, Feb 9, 2021 at 11:21 AM Jesper Dangaard Brouer
> <brouer@redhat.com> wrote:
>> On Tue, 9 Feb 2021 10:31:50 +0200
>> Radu Stoenescu <radu.stoe@gmail.com> wrote:
>>
>>> Is it possible to redirect packets from XDP program attached in driver
>>> mode to a physical NIC to a TAP interface?
>> Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
>> Maybe Jason can remember?
>> (or point me to the relevant code that I can check).
>>
>>> The same works fine if the XDP programs are attached in generic mode.
>> So, you have tried and it doesn't work.
>>
>> What is your setup?
>>
>> --
>> Best regards,
>>    Jesper Dangaard Brouer
>>    MSc.CS, Principal Kernel Engineer at Red Hat
>>    LinkedIn: http://www.linkedin.com/in/brouer
>>
>

Re: Redirect from NIC to TAP

[David Ahern]

On 2/9/21 2:41 AM, Maciej Fijalkowski wrote:
> On Tue, Feb 09, 2021 at 11:26:06AM +0200, Radu Stoenescu wrote:
>> Hello
>>
>> My physical NIC is a Netronome (I can come back with exact model type
>> and driver version).
>>
>> Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
>> It works when they are both in generic mode. I haven't tried other
>> combinations of attachment modes (one driver, other generic etc.).
> 

If the driver supports XDP_REDIRECT, it does work.

Take a look at this slide deck for gotcha's with this use case:

https://netdevconf.info/0x14/pub/slides/24/netdev-0x14-XDP-and-the-cloud.pdf

Re: Redirect from NIC to TAP

[Jesper Dangaard Brouer]

On Wed, 10 Feb 2021 11:42:10 +0800
Jason Wang <jasowang@redhat.com> wrote:

> On 2021/2/9 下午5:26, Radu Stoenescu wrote:
> > Hello
> >
> > My physical NIC is a Netronome (I can come back with exact model type
> > and driver version).
> >
> > Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
> > It works when they are both in generic mode. I haven't tried other
> > combinations of attachment modes (one driver, other generic etc.).  
> 
> 
> It should work. I tested with i40e/ixgbe/mlx4 in the past.
> 
> What eBPF program did you use? (Is it the one in samples/bpf?)
> 
> I would test it by myself.
> 
> (It's near to spring festival, so I can only check after the holiday).

As Maciej Fijalkowski pointed out:
 "Looks like Netronome driver still doesn't support XDP_REDIRECT in native
mode."

So, that is likely the problem.
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Re: Redirect from NIC to TAP

[Jason Wang]

On 2021/2/10 下午7:35, Jesper Dangaard Brouer wrote:
> On Wed, 10 Feb 2021 11:42:10 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> On 2021/2/9 下午5:26, Radu Stoenescu wrote:
>>> Hello
>>>
>>> My physical NIC is a Netronome (I can come back with exact model type
>>> and driver version).
>>>
>>> Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
>>> It works when they are both in generic mode. I haven't tried other
>>> combinations of attachment modes (one driver, other generic etc.).
>>
>> It should work. I tested with i40e/ixgbe/mlx4 in the past.
>>
>> What eBPF program did you use? (Is it the one in samples/bpf?)
>>
>> I would test it by myself.
>>
>> (It's near to spring festival, so I can only check after the holiday).
> As Maciej Fijalkowski pointed out:
>   "Looks like Netronome driver still doesn't support XDP_REDIRECT in native
> mode."
>
> So, that is likely the problem.


I see.

Thanks

Re: Redirect from NIC to TAP

[Simon Horman]

Hi Maciej, Hi Radu,

On Tue, Feb 09, 2021 at 10:41:37AM +0100, Maciej Fijalkowski wrote:
> On Tue, Feb 09, 2021 at 11:26:06AM +0200, Radu Stoenescu wrote:
> > Hello
> > 
> > My physical NIC is a Netronome (I can come back with exact model type
> > and driver version).
> > 
> > Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
> > It works when they are both in generic mode. I haven't tried other
> > combinations of attachment modes (one driver, other generic etc.).
> 
> Looks like Netronome driver still doesn't support XDP_REDIRECT in native
> mode.
> 
> CC: Simon

Sorry for the delay, I was on vacation.

> Simon, any plans on adding support for redirect?

Sorry (again), there are no immediate plans to add this feature
to the driver.

> > Thanks
> > 
> > On Tue, Feb 9, 2021 at 11:21 AM Jesper Dangaard Brouer
> > <brouer@redhat.com> wrote:
> > >
> > > On Tue, 9 Feb 2021 10:31:50 +0200
> > > Radu Stoenescu <radu.stoe@gmail.com> wrote:
> > >
> > > > Is it possible to redirect packets from XDP program attached in driver
> > > > mode to a physical NIC to a TAP interface?
> > >
> > > Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
> > > Maybe Jason can remember?
> > > (or point me to the relevant code that I can check).
> > >
> > > > The same works fine if the XDP programs are attached in generic mode.
> > >
> > > So, you have tried and it doesn't work.
> > >
> > > What is your setup?
> > >
> > > --
> > > Best regards,
> > >   Jesper Dangaard Brouer
> > >   MSc.CS, Principal Kernel Engineer at Red Hat
> > >   LinkedIn: http://www.linkedin.com/in/brouer
> > >
> > 
> > 
> > -- 
> > Radu Stoenescu

Re: Redirect from NIC to TAP

[Radu Stoenescu]

Thanks a lot for the info.

In retrospect, was there a way I could reach this conclusion myself
(no driver support)? I'm asking this since I'm relatively new to the
environment and we run various NICs from various vendors, and I would
like to know how to perform the "due diligence" myself before reaching
out?

Best
Radu


On Thu, Feb 18, 2021 at 12:12 PM Simon Horman
<simon.horman@netronome.com> wrote:
>
> Hi Maciej, Hi Radu,
>
> On Tue, Feb 09, 2021 at 10:41:37AM +0100, Maciej Fijalkowski wrote:
> > On Tue, Feb 09, 2021 at 11:26:06AM +0200, Radu Stoenescu wrote:
> > > Hello
> > >
> > > My physical NIC is a Netronome (I can come back with exact model type
> > > and driver version).
> > >
> > > Redirect NIC to TAP doesn't work when XDP is attached in driver mode.
> > > It works when they are both in generic mode. I haven't tried other
> > > combinations of attachment modes (one driver, other generic etc.).
> >
> > Looks like Netronome driver still doesn't support XDP_REDIRECT in native
> > mode.
> >
> > CC: Simon
>
> Sorry for the delay, I was on vacation.
>
> > Simon, any plans on adding support for redirect?
>
> Sorry (again), there are no immediate plans to add this feature
> to the driver.
>
> > > Thanks
> > >
> > > On Tue, Feb 9, 2021 at 11:21 AM Jesper Dangaard Brouer
> > > <brouer@redhat.com> wrote:
> > > >
> > > > On Tue, 9 Feb 2021 10:31:50 +0200
> > > > Radu Stoenescu <radu.stoe@gmail.com> wrote:
> > > >
> > > > > Is it possible to redirect packets from XDP program attached in driver
> > > > > mode to a physical NIC to a TAP interface?
> > > >
> > > > Cc. Jason Wang as I think he implemented this, but I'm not 100% sure.
> > > > Maybe Jason can remember?
> > > > (or point me to the relevant code that I can check).
> > > >
> > > > > The same works fine if the XDP programs are attached in generic mode.
> > > >
> > > > So, you have tried and it doesn't work.
> > > >
> > > > What is your setup?
> > > >
> > > > --
> > > > Best regards,
> > > >   Jesper Dangaard Brouer
> > > >   MSc.CS, Principal Kernel Engineer at Red Hat
> > > >   LinkedIn: http://www.linkedin.com/in/brouer
> > > >
> > >
> > >
> > > --
> > > Radu Stoenescu



-- 
Radu Stoenescu

Re: Redirect from NIC to TAP

[Toke Høiland-Jørgensen]

Radu Stoenescu <radu.stoe@gmail.com> writes:

> Thanks a lot for the info.
>
> In retrospect, was there a way I could reach this conclusion myself
> (no driver support)? I'm asking this since I'm relatively new to the
> environment and we run various NICs from various vendors, and I would
> like to know how to perform the "due diligence" myself before reaching
> out?

Grepping the source code is one. The xdp_monitor tool from samples/bpf
might have provided a hint as well, but only that something was wrong,
not the cause.

This is a long-standing issue, and there's been some discussion around
it, but let's just say that no consensus has emerged yet :/

-Toke