From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Don't touch NULL sg on i915_gem_object_get_pages_gtt() error
Date: Fri, 18 Nov 2016 17:19:58 +0000 [thread overview]
Message-ID: <CAM0jSHMEFix5JMwGMkO+8a3eKy8roL+BjJf44yjv1fGJdPKg6w@mail.gmail.com> (raw)
In-Reply-To: <20161114112930.2033-1-chris@chris-wilson.co.uk>
On 14 November 2016 at 11:29, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On the DMA mapping error path, sg may be NULL (it has already been
> marked as the last scatterlist entry), and we should avoid dereferencing
> it again.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: e227330223a7 ("drm/i915: avoid leaking DMA mappings")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Don't touch NULL sg on i915_gem_object_get_pages_gtt() error
Date: Fri, 18 Nov 2016 17:19:58 +0000 [thread overview]
Message-ID: <CAM0jSHMEFix5JMwGMkO+8a3eKy8roL+BjJf44yjv1fGJdPKg6w@mail.gmail.com> (raw)
In-Reply-To: <20161114112930.2033-1-chris@chris-wilson.co.uk>
On 14 November 2016 at 11:29, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On the DMA mapping error path, sg may be NULL (it has already been
> marked as the last scatterlist entry), and we should avoid dereferencing
> it again.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: e227330223a7 ("drm/i915: avoid leaking DMA mappings")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-18 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 11:14 [bug report] drm/i915: Allow compaction upto SWIOTLB max segment size Dan Carpenter
2016-11-14 11:23 ` Chris Wilson
2016-11-14 11:29 ` [PATCH] drm/i915: Don't touch NULL sg on i915_gem_object_get_pages_gtt() error Chris Wilson
2016-11-14 11:29 ` Chris Wilson
2016-11-18 17:19 ` Matthew Auld [this message]
2016-11-18 17:19 ` Matthew Auld
2016-11-18 20:52 ` [Intel-gfx] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHMEFix5JMwGMkO+8a3eKy8roL+BjJf44yjv1fGJdPKg6w@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.