* [PATCH] drm/i915: Mark up object tiling-and-stride getters as const
@ 2018-07-25 15:54 Chris Wilson
2018-07-25 16:27 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-25 15:54 UTC (permalink / raw)
To: intel-gfx
For that little bit of defense against a tired programmer.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem.c | 4 ++--
drivers/gpu/drm/i915/i915_gem_object.h | 10 +++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a4031fab57b0..0946e1932907 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1911,7 +1911,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data,
return 0;
}
-static unsigned int tile_row_pages(struct drm_i915_gem_object *obj)
+static unsigned int tile_row_pages(const struct drm_i915_gem_object *obj)
{
return i915_gem_object_get_tile_row_size(obj) >> PAGE_SHIFT;
}
@@ -1970,7 +1970,7 @@ int i915_gem_mmap_gtt_version(void)
}
static inline struct i915_ggtt_view
-compute_partial_view(struct drm_i915_gem_object *obj,
+compute_partial_view(const struct drm_i915_gem_object *obj,
pgoff_t page_offset,
unsigned int chunk)
{
diff --git a/drivers/gpu/drm/i915/i915_gem_object.h b/drivers/gpu/drm/i915/i915_gem_object.h
index 83e5e01fa9ea..a6dd7c46de0d 100644
--- a/drivers/gpu/drm/i915/i915_gem_object.h
+++ b/drivers/gpu/drm/i915/i915_gem_object.h
@@ -421,19 +421,19 @@ i915_gem_object_is_framebuffer(const struct drm_i915_gem_object *obj)
}
static inline unsigned int
-i915_gem_object_get_tiling(struct drm_i915_gem_object *obj)
+i915_gem_object_get_tiling(const struct drm_i915_gem_object *obj)
{
return obj->tiling_and_stride & TILING_MASK;
}
static inline bool
-i915_gem_object_is_tiled(struct drm_i915_gem_object *obj)
+i915_gem_object_is_tiled(const struct drm_i915_gem_object *obj)
{
return i915_gem_object_get_tiling(obj) != I915_TILING_NONE;
}
static inline unsigned int
-i915_gem_object_get_stride(struct drm_i915_gem_object *obj)
+i915_gem_object_get_stride(const struct drm_i915_gem_object *obj)
{
return obj->tiling_and_stride & STRIDE_MASK;
}
@@ -446,13 +446,13 @@ i915_gem_tile_height(unsigned int tiling)
}
static inline unsigned int
-i915_gem_object_get_tile_height(struct drm_i915_gem_object *obj)
+i915_gem_object_get_tile_height(const struct drm_i915_gem_object *obj)
{
return i915_gem_tile_height(i915_gem_object_get_tiling(obj));
}
static inline unsigned int
-i915_gem_object_get_tile_row_size(struct drm_i915_gem_object *obj)
+i915_gem_object_get_tile_row_size(const struct drm_i915_gem_object *obj)
{
return (i915_gem_object_get_stride(obj) *
i915_gem_object_get_tile_height(obj));
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Mark up object tiling-and-stride getters as const
2018-07-25 15:54 [PATCH] drm/i915: Mark up object tiling-and-stride getters as const Chris Wilson
@ 2018-07-25 16:27 ` Patchwork
2018-07-25 17:15 ` ✓ Fi.CI.IGT: " Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-25 16:27 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Mark up object tiling-and-stride getters as const
URL : https://patchwork.freedesktop.org/series/47230/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4540 -> Patchwork_9765 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9765 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9765, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47230/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9765:
=== IGT changes ===
==== Warnings ====
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9765 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-guc: PASS -> DMESG-FAIL (fdo#107174)
fi-skl-6600u: PASS -> DMESG-FAIL (fdo#107174, fdo#106560)
==== Possible fixes ====
igt@drv_selftest@live_workarounds:
fi-kbl-x1275: DMESG-FAIL (fdo#107292) -> PASS
igt@gem_exec_basic@gtt-bsd:
fi-glk-j4005: DMESG-WARN (fdo#105719) -> PASS
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: FAIL (fdo#103841) -> PASS
==== Warnings ====
igt@drv_selftest@live_workarounds:
fi-cnl-psr: DMESG-FAIL (fdo#107292) -> DMESG-WARN (fdo#105395)
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
== Participating hosts (52 -> 44) ==
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-icl-u fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4540 -> Patchwork_9765
CI_DRM_4540: 3389cdd19fe3ff96e35aab6cd357f26f7ac651c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4574: 24c5e07783222b5d6cf86003e8e545033e09bb3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9765: ea5ca329cbac142543de7d691ad62c72d76ff050 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ea5ca329cbac drm/i915: Mark up object tiling-and-stride getters as const
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9765/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Mark up object tiling-and-stride getters as const
2018-07-25 15:54 [PATCH] drm/i915: Mark up object tiling-and-stride getters as const Chris Wilson
2018-07-25 16:27 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-25 17:15 ` Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-25 17:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Mark up object tiling-and-stride getters as const
URL : https://patchwork.freedesktop.org/series/47230/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4540_full -> Patchwork_9765_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9765_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_wait@await-render:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558)
igt@kms_flip@2x-plain-flip-ts-check:
shard-glk: PASS -> FAIL (fdo#100368)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363, fdo#102887) -> PASS
igt@kms_flip@plain-flip-fb-recreate:
shard-glk: FAIL (fdo#100368) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4540 -> Patchwork_9765
CI_DRM_4540: 3389cdd19fe3ff96e35aab6cd357f26f7ac651c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4574: 24c5e07783222b5d6cf86003e8e545033e09bb3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9765: ea5ca329cbac142543de7d691ad62c72d76ff050 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9765/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Mark up object tiling-and-stride getters as const
2018-07-25 15:54 [PATCH] drm/i915: Mark up object tiling-and-stride getters as const Chris Wilson
2018-07-25 16:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-25 17:15 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-07-26 11:22 ` Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Matthew Auld @ 2018-07-26 11:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On 25 July 2018 at 16:54, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> For that little bit of defense against a tired programmer.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 11:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 15:54 [PATCH] drm/i915: Mark up object tiling-and-stride getters as const Chris Wilson
2018-07-25 16:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-25 17:15 ` ✓ Fi.CI.IGT: " Patchwork
2018-07-26 11:22 ` [PATCH] " Matthew Auld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.