* [PATCH] drm/i915: Disable THP until we have a read BW W/A
@ 2017-11-24 11:27 Joonas Lahtinen
2017-11-24 12:12 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2017-11-24 11:27 UTC (permalink / raw)
To: Intel graphics driver community testing & development
Cc: Eero Tamminen, Matthew Auld, Rodrigo Vivi
We seem to be missing some W/A for 2M pages and are getting
a hit on raw read bandwidths (even 30%) even though the write
bandwidths improve (even 10%).
For now, disable THP, which is our only practical source of
2M pages until we have a W/A for the issue.
Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Valtteri Rantala <valtteri.rantala@intel.com>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
---
drivers/gpu/drm/i915/i915_gemfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/drivers/gpu/drm/i915/i915_gemfs.c
index e2993857df37..851d827d83a8 100644
--- a/drivers/gpu/drm/i915/i915_gemfs.c
+++ b/drivers/gpu/drm/i915/i915_gemfs.c
@@ -52,7 +52,8 @@ int i915_gemfs_init(struct drm_i915_private *i915)
if (has_transparent_hugepage()) {
struct super_block *sb = gemfs->mnt_sb;
- char options[] = "huge=within_size";
+ /* FIXME: Disabled until we get W/A for read BW issue. */
+ char options[] = "huge=deny";
int flags = 0;
int err;
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Disable THP until we have a read BW W/A
2017-11-24 11:27 [PATCH] drm/i915: Disable THP until we have a read BW W/A Joonas Lahtinen
@ 2017-11-24 12:12 ` Chris Wilson
2017-11-24 15:03 ` Chris Wilson
2017-11-24 12:22 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2017-11-24 12:12 UTC (permalink / raw)
To: Joonas Lahtinen,
Intel graphics driver community testing & development
Cc: Eero Tamminen, Matthew Auld, Rodrigo Vivi
Quoting Joonas Lahtinen (2017-11-24 11:27:50)
> We seem to be missing some W/A for 2M pages and are getting
> a hit on raw read bandwidths (even 30%) even though the write
> bandwidths improve (even 10%).
>
> For now, disable THP, which is our only practical source of
> 2M pages until we have a W/A for the issue.
>
> Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
I don't have much to say, a lot of unknowns and you've already concisely
summed up everything that is known.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Disable THP until we have a read BW W/A
2017-11-24 12:12 ` Chris Wilson
@ 2017-11-24 15:03 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-11-24 15:03 UTC (permalink / raw)
To: Joonas Lahtinen,
Intel graphics driver community testing & development
Cc: Eero Tamminen, Matthew Auld, Rodrigo Vivi
Quoting Chris Wilson (2017-11-24 12:12:33)
> Quoting Joonas Lahtinen (2017-11-24 11:27:50)
> > We seem to be missing some W/A for 2M pages and are getting
> > a hit on raw read bandwidths (even 30%) even though the write
> > bandwidths improve (even 10%).
> >
> > For now, disable THP, which is our only practical source of
> > 2M pages until we have a W/A for the issue.
> >
> > Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
>
> I don't have much to say, a lot of unknowns and you've already concisely
> summed up everything that is known.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Bah, what works on the cmdline isn't allowed as an option!
Apparently, s/deny/never/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Disable THP until we have a read BW W/A
2017-11-24 11:27 [PATCH] drm/i915: Disable THP until we have a read BW W/A Joonas Lahtinen
2017-11-24 12:12 ` Chris Wilson
@ 2017-11-24 12:22 ` Patchwork
2017-11-24 14:58 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-24 16:56 ` [PATCH] " Matthew Auld
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-11-24 12:22 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable THP until we have a read BW W/A
URL : https://patchwork.freedesktop.org/series/34355/
State : success
== Summary ==
Series 34355v1 drm/i915: Disable THP until we have a read BW W/A
https://patchwork.freedesktop.org/api/1.0/series/34355/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:445s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:458s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:377s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:544s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:281s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:516s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:510s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:495s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:436s
fi-gdg-551 total:289 pass:179 dwarn:1 dfail:0 fail:0 skip:109 time:268s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:540s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:432s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:439s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:432s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:486s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:467s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:482s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:531s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:536s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:580s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:461s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:549s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:521s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:502s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:462s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:429s
Blacklisted hosts:
fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:618s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:560s
fi-glk-dsi total:72 pass:46 dwarn:0 dfail:0 fail:15 skip:10
8b78c9fb3da0e9f3011ad89d3f1cb0a4ac94c569 drm-tip: 2017y-11m-24d-10h-36m-28s UTC integration manifest
e8deabb68bb9 drm/i915: Disable THP until we have a read BW W/A
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7278/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✗ Fi.CI.IGT: warning for drm/i915: Disable THP until we have a read BW W/A
2017-11-24 11:27 [PATCH] drm/i915: Disable THP until we have a read BW W/A Joonas Lahtinen
2017-11-24 12:12 ` Chris Wilson
2017-11-24 12:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-24 14:58 ` Patchwork
2017-11-24 16:56 ` [PATCH] " Matthew Auld
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-11-24 14:58 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable THP until we have a read BW W/A
URL : https://patchwork.freedesktop.org/series/34355/
State : warning
== Summary ==
Warning: bzip CI_DRM_3381/shard-glkb6/results8.json.bz2 wasn't in correct JSON format
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
pass -> FAIL (shard-snb) fdo#101623
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test drv_selftest:
Subgroup mock_sanitycheck:
pass -> DMESG-WARN (shard-snb) fdo#103717
Subgroup mock_breadcrumbs:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_requests:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_objects:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_dmabuf:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_vma:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_evict:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_gtt:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Subgroup mock_hugepages:
pass -> DMESG-WARN (shard-snb)
pass -> DMESG-WARN (shard-hsw)
Test kms_flip:
Subgroup plain-flip-fb-recreate-interruptible:
fail -> PASS (shard-hsw) fdo#100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103717 https://bugs.freedesktop.org/show_bug.cgi?id=103717
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
shard-hsw total:2667 pass:1527 dwarn:9 dfail:0 fail:10 skip:1121 time:9590s
shard-snb total:2667 pass:1301 dwarn:10 dfail:0 fail:14 skip:1342 time:8123s
Blacklisted hosts:
shard-apl total:2667 pass:1680 dwarn:9 dfail:0 fail:23 skip:955 time:13587s
shard-kbl total:2667 pass:1685 dwarn:116 dfail:6 fail:22 skip:838 time:10901s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7278/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Disable THP until we have a read BW W/A
2017-11-24 11:27 [PATCH] drm/i915: Disable THP until we have a read BW W/A Joonas Lahtinen
` (2 preceding siblings ...)
2017-11-24 14:58 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-11-24 16:56 ` Matthew Auld
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2017-11-24 16:56 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Intel graphics driver community testing & development,
Rodrigo Vivi, Eero Tamminen, Matthew Auld
On 24 November 2017 at 11:27, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:
> We seem to be missing some W/A for 2M pages and are getting
> a hit on raw read bandwidths (even 30%) even though the write
> bandwidths improve (even 10%).
>
> For now, disable THP, which is our only practical source of
> 2M pages until we have a W/A for the issue.
>
> Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
With s/deny/never/:
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-24 16:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 11:27 [PATCH] drm/i915: Disable THP until we have a read BW W/A Joonas Lahtinen
2017-11-24 12:12 ` Chris Wilson
2017-11-24 15:03 ` Chris Wilson
2017-11-24 12:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-24 14:58 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-24 16:56 ` [PATCH] " Matthew Auld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.