From: Matthew Auld <matthew.william.auld@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Matthew Auld" <matthew.auld@intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"kernel test robot" <lkp@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/dmabuf: fix broken build
Date: Wed, 27 Oct 2021 10:03:49 +0100 [thread overview]
Message-ID: <CAM0jSHOCn120_-WZCJHa2+NzPrB_pErHPT3hA2BGarM-ZDw-Cg@mail.gmail.com> (raw)
In-Reply-To: <87k0hyj13f.fsf@intel.com>
On Wed, 27 Oct 2021 at 09:58, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Wed, 27 Oct 2021, Matthew Auld <matthew.william.auld@gmail.com> wrote:
> > On Thu, 21 Oct 2021 at 13:54, Matthew Auld <matthew.auld@intel.com> wrote:
> >>
> >> wbinvd_on_all_cpus() is only defined on x86 it seems, plus we need to
> >> include asm/smp.h here.
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> >
> > Jani, would it make sense to cherry-pick this to -fixes? The offending
> > commit is in drm-next, and there have been a few reports around this.
> >
> > Fixes: a035154da45d ("drm/i915/dmabuf: add paranoid flush-on-acquire")
>
> If the Fixes: tag is in place, our tooling will cherry-pick it where it
> belongs. (In this case, drm-intel-next-fixes, not drm-intel-fixes.)
Yeah, I forgot to add the fixes tag here unfortunately.
>
> Cc: Rodrigo who covers drm-intel-next-fixes atm.
>
> BR,
> Jani.
>
>
>
> >
> >
> >> ---
> >> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> index 1adcd8e02d29..a45d0ec2c5b6 100644
> >> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> @@ -12,6 +12,13 @@
> >> #include "i915_gem_object.h"
> >> #include "i915_scatterlist.h"
> >>
> >> +#if defined(CONFIG_X86)
> >> +#include <asm/smp.h>
> >> +#else
> >> +#define wbinvd_on_all_cpus() \
> >> + pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> >> +#endif
> >> +
> >> I915_SELFTEST_DECLARE(static bool force_different_devices;)
> >>
> >> static struct drm_i915_gem_object *dma_buf_to_obj(struct dma_buf *buf)
> >> --
> >> 2.26.3
> >>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.william.auld@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Matthew Auld" <matthew.auld@intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"kernel test robot" <lkp@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmabuf: fix broken build
Date: Wed, 27 Oct 2021 10:03:49 +0100 [thread overview]
Message-ID: <CAM0jSHOCn120_-WZCJHa2+NzPrB_pErHPT3hA2BGarM-ZDw-Cg@mail.gmail.com> (raw)
In-Reply-To: <87k0hyj13f.fsf@intel.com>
On Wed, 27 Oct 2021 at 09:58, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Wed, 27 Oct 2021, Matthew Auld <matthew.william.auld@gmail.com> wrote:
> > On Thu, 21 Oct 2021 at 13:54, Matthew Auld <matthew.auld@intel.com> wrote:
> >>
> >> wbinvd_on_all_cpus() is only defined on x86 it seems, plus we need to
> >> include asm/smp.h here.
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> >
> > Jani, would it make sense to cherry-pick this to -fixes? The offending
> > commit is in drm-next, and there have been a few reports around this.
> >
> > Fixes: a035154da45d ("drm/i915/dmabuf: add paranoid flush-on-acquire")
>
> If the Fixes: tag is in place, our tooling will cherry-pick it where it
> belongs. (In this case, drm-intel-next-fixes, not drm-intel-fixes.)
Yeah, I forgot to add the fixes tag here unfortunately.
>
> Cc: Rodrigo who covers drm-intel-next-fixes atm.
>
> BR,
> Jani.
>
>
>
> >
> >
> >> ---
> >> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> index 1adcd8e02d29..a45d0ec2c5b6 100644
> >> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> @@ -12,6 +12,13 @@
> >> #include "i915_gem_object.h"
> >> #include "i915_scatterlist.h"
> >>
> >> +#if defined(CONFIG_X86)
> >> +#include <asm/smp.h>
> >> +#else
> >> +#define wbinvd_on_all_cpus() \
> >> + pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> >> +#endif
> >> +
> >> I915_SELFTEST_DECLARE(static bool force_different_devices;)
> >>
> >> static struct drm_i915_gem_object *dma_buf_to_obj(struct dma_buf *buf)
> >> --
> >> 2.26.3
> >>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-10-27 9:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 12:53 [PATCH 1/2] drm/i915/dmabuf: fix broken build Matthew Auld
2021-10-21 12:53 ` [Intel-gfx] " Matthew Auld
2021-10-21 12:53 ` [PATCH 2/2] drm/i915/dmabuf: drop the flush on discrete Matthew Auld
2021-10-21 12:53 ` [Intel-gfx] " Matthew Auld
2021-10-22 9:26 ` Thomas Hellström
2021-10-22 9:26 ` [Intel-gfx] " Thomas Hellström
2021-10-22 9:47 ` Matthew Auld
2021-10-22 9:47 ` [Intel-gfx] " Matthew Auld
2021-10-28 15:31 ` Daniel Vetter
2021-10-21 14:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dmabuf: fix broken build Patchwork
2021-10-21 15:18 ` [PATCH 1/2] " Dixit, Ashutosh
2021-10-21 15:18 ` [Intel-gfx] " Dixit, Ashutosh
2021-10-21 15:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2021-10-21 18:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-27 7:57 ` [PATCH 1/2] " Matthew Auld
2021-10-27 7:57 ` [Intel-gfx] " Matthew Auld
2021-10-27 8:58 ` Jani Nikula
2021-10-27 8:58 ` [Intel-gfx] " Jani Nikula
2021-10-27 9:00 ` Jani Nikula
2021-10-27 9:00 ` [Intel-gfx] " Jani Nikula
2021-10-27 9:03 ` Matthew Auld [this message]
2021-10-27 9:03 ` Matthew Auld
2021-10-27 9:44 ` Jani Nikula
2021-10-27 9:44 ` [Intel-gfx] " Jani Nikula
2021-10-27 9:48 ` Matthew Auld
2021-10-27 9:48 ` [Intel-gfx] " Matthew Auld
2021-10-28 1:43 ` Vivi, Rodrigo
2021-10-28 1:43 ` [Intel-gfx] " Vivi, Rodrigo
2021-10-28 8:48 ` Matthew Auld
2021-10-28 8:48 ` [Intel-gfx] " Matthew Auld
2021-11-22 13:34 ` Tvrtko Ursulin
2021-11-22 13:34 ` [Intel-gfx] " Tvrtko Ursulin
2021-10-27 14:54 ` Lucas De Marchi
2021-10-27 14:54 ` Lucas De Marchi
2021-10-27 16:23 ` Matthew Auld
2021-10-27 16:23 ` [Intel-gfx] " Matthew Auld
2021-10-27 17:16 ` Lucas De Marchi
2021-10-27 17:16 ` [Intel-gfx] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHOCn120_-WZCJHa2+NzPrB_pErHPT3hA2BGarM-ZDw-Cg@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lkp@intel.com \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.