All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/selftests: Unse NOWARN for large allocations
@ 2017-11-22 12:06 Chris Wilson
  2017-11-22 12:11 ` Matthew Auld
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2017-11-22 12:06 UTC (permalink / raw)
  To: intel-gfx; +Cc: Matthew Auld

We may try to do a large kmalloc for the permutation array, falling back
to a smaller array/test if the first allocation fails. Since we are
intentionally trying a large allocation which may fail, pass __GFP_NOWARN.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/selftests/i915_random.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_random.c b/drivers/gpu/drm/i915/selftests/i915_random.c
index b85872cc7fbe..2088ae57aa89 100644
--- a/drivers/gpu/drm/i915/selftests/i915_random.c
+++ b/drivers/gpu/drm/i915/selftests/i915_random.c
@@ -57,7 +57,7 @@ unsigned int *i915_random_order(unsigned int count, struct rnd_state *state)
 {
 	unsigned int *order, i;
 
-	order = kmalloc_array(count, sizeof(*order), GFP_KERNEL);
+	order = kmalloc_array(count, sizeof(*order), GFP_KERNEL | __GFP_NOWARN);
 	if (!order)
 		return order;
 
-- 
2.15.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915/selftests: Unse NOWARN for large allocations
  2017-11-22 12:06 [PATCH] drm/i915/selftests: Unse NOWARN for large allocations Chris Wilson
@ 2017-11-22 12:11 ` Matthew Auld
  2017-11-22 12:13   ` Matthew Auld
  2017-11-22 12:26 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-11-22 14:35 ` ✗ Fi.CI.IGT: warning " Patchwork
  2 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2017-11-22 12:11 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On 22 November 2017 at 12:06, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We may try to do a large kmalloc for the permutation array, falling back
> to a smaller array/test if the first allocation fails. Since we are
> intentionally trying a large allocation which may fail, pass __GFP_NOWARN.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915/selftests: Unse NOWARN for large allocations
  2017-11-22 12:11 ` Matthew Auld
@ 2017-11-22 12:13   ` Matthew Auld
  2017-11-22 14:44     ` Chris Wilson
  0 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2017-11-22 12:13 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On 22 November 2017 at 12:11, Matthew Auld
<matthew.william.auld@gmail.com> wrote:
> On 22 November 2017 at 12:06, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> We may try to do a large kmalloc for the permutation array, falling back
>> to a smaller array/test if the first allocation fails. Since we are
>> intentionally trying a large allocation which may fail, pass __GFP_NOWARN.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>

s/Unse/Use/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/selftests: Unse NOWARN for large allocations
  2017-11-22 12:06 [PATCH] drm/i915/selftests: Unse NOWARN for large allocations Chris Wilson
  2017-11-22 12:11 ` Matthew Auld
@ 2017-11-22 12:26 ` Patchwork
  2017-11-22 14:35 ` ✗ Fi.CI.IGT: warning " Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-11-22 12:26 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/selftests: Unse NOWARN for large allocations
URL   : https://patchwork.freedesktop.org/series/34223/
State : success

== Summary ==

Series 34223v1 drm/i915/selftests: Unse NOWARN for large allocations
https://patchwork.freedesktop.org/api/1.0/series/34223/revisions/1/mbox/

Test gem_ringfill:
        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-blb-e6850) fdo#101600
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:450s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:461s
fi-blb-e6850     total:289  pass:224  dwarn:0   dfail:0   fail:0   skip:65  time:381s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:544s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:278s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:505s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:510s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:492s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:603s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:268s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:540s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:429s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:443s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:428s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:465s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:481s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:532s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:484s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:533s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:553s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:530s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:499s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:461s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:561s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:426s
Blacklisted hosts:
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:548s
fi-glk-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:500s
fi-pnv-d510 failed to collect. IGT log at Patchwork_7231/fi-pnv-d510/igt.log

d8251dc669fe85dff5cdd1cc91f504366b46d317 drm-tip: 2017y-11m-22d-10h-27m-38s UTC integration manifest
ce4e5410f535 drm/i915/selftests: Unse NOWARN for large allocations

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7231/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* ✗ Fi.CI.IGT: warning for drm/i915/selftests: Unse NOWARN for large allocations
  2017-11-22 12:06 [PATCH] drm/i915/selftests: Unse NOWARN for large allocations Chris Wilson
  2017-11-22 12:11 ` Matthew Auld
  2017-11-22 12:26 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-22 14:35 ` Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-11-22 14:35 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/selftests: Unse NOWARN for large allocations
URL   : https://patchwork.freedesktop.org/series/34223/
State : warning

== Summary ==

Test perf:
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623
Test gem_busy:
        Subgroup close-race:
                pass       -> FAIL       (shard-snb) fdo#103829
Test kms_draw_crc:
        Subgroup draw-method-xrgb2101010-render-xtiled:
                pass       -> SKIP       (shard-snb)
Test drv_module_reload:
        Subgroup basic-no-display:
                dmesg-warn -> PASS       (shard-hsw) fdo#102707

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103829 https://bugs.freedesktop.org/show_bug.cgi?id=103829
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707

shard-hsw        total:2585 pass:1474 dwarn:1   dfail:0   fail:11  skip:1099 time:9550s
shard-snb        total:2585 pass:1257 dwarn:1   dfail:0   fail:13  skip:1314 time:8077s
Blacklisted hosts:
shard-apl        total:2565 pass:1602 dwarn:1   dfail:0   fail:23  skip:938 time:13140s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7231/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/i915/selftests: Unse NOWARN for large allocations
  2017-11-22 12:13   ` Matthew Auld
@ 2017-11-22 14:44     ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-11-22 14:44 UTC (permalink / raw)
  To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

Quoting Matthew Auld (2017-11-22 12:13:52)
> On 22 November 2017 at 12:11, Matthew Auld
> <matthew.william.auld@gmail.com> wrote:
> > On 22 November 2017 at 12:06, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >> We may try to do a large kmalloc for the permutation array, falling back
> >> to a smaller array/test if the first allocation fails. Since we are
> >> intentionally trying a large allocation which may fail, pass __GFP_NOWARN.
> >>
> >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Matthew Auld <matthew.auld@intel.com>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> 
> s/Unse/Use/

Fixed and pushed, thanks.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-11-22 14:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-22 12:06 [PATCH] drm/i915/selftests: Unse NOWARN for large allocations Chris Wilson
2017-11-22 12:11 ` Matthew Auld
2017-11-22 12:13   ` Matthew Auld
2017-11-22 14:44     ` Chris Wilson
2017-11-22 12:26 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-22 14:35 ` ✗ Fi.CI.IGT: warning " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.