All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhilash Kesavan <kesavan.abhilash@gmail.com>
To: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Kevin Hilman <khilman@kernel.org>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	punit.agrawal@arm.com, Will Deacon <will.deacon@arm.com>,
	"mark.rutland" <mark.rutland@arm.com>
Cc: "Kukjin Kim" <kgene@kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Olof Johansson" <olof@lixom.net>,
	"Kukjin Kim" <kgene.kim@samsung.com>,
	"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
	"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	Me2 <kesavan.abhilash@gmail.com>, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH RFT 1/2] drivers: bus: check cci device tree node status
Date: Wed, 10 Dec 2014 09:31:34 +0530	[thread overview]
Message-ID: <CAM4voakjWgnEXoXT1LH2ZFBy=U4vfXFXS1Su8VB7Cd3s3wqmSA@mail.gmail.com> (raw)
In-Reply-To: <1417186209-5256-1-git-send-email-a.kesavan@samsung.com>

Hi,

On Fri, Nov 28, 2014 at 8:20 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
> The arm-cci driver completes the probe sequence even if the cci node is
> marked as disabled. Add a check in the driver to honour the cci status
> in the device tree.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>

This patch helps disable CCI on the Arndale Octa board thus resolving
some imprecise aborts seen on that board. Kindly review.

Regards,
Abhilash
> ---
>  drivers/bus/arm-cci.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 860da40..0ce5e2d 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -1312,6 +1312,9 @@ static int cci_probe(void)
>         if (!np)
>                 return -ENODEV;
>
> +       if (!of_device_is_available(np))
> +               return -ENODEV;
> +
>         cci_config = of_match_node(arm_cci_matches, np)->data;
>         if (!cci_config)
>                 return -ENODEV;
> --
> 1.7.9.5
>

WARNING: multiple messages have this Message-ID (diff)
From: kesavan.abhilash@gmail.com (Abhilash Kesavan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFT 1/2] drivers: bus: check cci device tree node status
Date: Wed, 10 Dec 2014 09:31:34 +0530	[thread overview]
Message-ID: <CAM4voakjWgnEXoXT1LH2ZFBy=U4vfXFXS1Su8VB7Cd3s3wqmSA@mail.gmail.com> (raw)
In-Reply-To: <1417186209-5256-1-git-send-email-a.kesavan@samsung.com>

Hi,

On Fri, Nov 28, 2014 at 8:20 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
> The arm-cci driver completes the probe sequence even if the cci node is
> marked as disabled. Add a check in the driver to honour the cci status
> in the device tree.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>

This patch helps disable CCI on the Arndale Octa board thus resolving
some imprecise aborts seen on that board. Kindly review.

Regards,
Abhilash
> ---
>  drivers/bus/arm-cci.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 860da40..0ce5e2d 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -1312,6 +1312,9 @@ static int cci_probe(void)
>         if (!np)
>                 return -ENODEV;
>
> +       if (!of_device_is_available(np))
> +               return -ENODEV;
> +
>         cci_config = of_match_node(arm_cci_matches, np)->data;
>         if (!cci_config)
>                 return -ENODEV;
> --
> 1.7.9.5
>

  parent reply	other threads:[~2014-12-10  4:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 14:50 [PATCH RFT 1/2] drivers: bus: check cci device tree node status Abhilash Kesavan
2014-11-28 14:50 ` Abhilash Kesavan
2014-11-28 14:50 ` [PATCH RFT 2/2] arm: dts: disable CCI on exynos420 based arndale-octa Abhilash Kesavan
2014-11-28 14:50   ` Abhilash Kesavan
2014-11-28 15:19   ` Krzysztof Kozlowski
2014-11-28 15:19     ` Krzysztof Kozlowski
2014-11-28 15:39     ` Abhilash Kesavan
2014-11-28 15:39       ` Abhilash Kesavan
2014-12-01  9:03       ` Krzysztof Kozlowski
2014-12-01  9:03         ` Krzysztof Kozlowski
2014-12-01 11:09         ` Russell King - ARM Linux
2014-12-01 11:09           ` Russell King - ARM Linux
2014-12-01 11:19           ` Krzysztof Kozlowski
2014-12-01 11:19             ` Krzysztof Kozlowski
2014-12-01 18:50   ` Kevin Hilman
2014-12-01 18:50     ` Kevin Hilman
2014-12-01 19:52     ` Tyler Baker
2014-12-01 19:52       ` Tyler Baker
2014-12-10  4:01 ` Abhilash Kesavan [this message]
2014-12-10  4:01   ` [PATCH RFT 1/2] drivers: bus: check cci device tree node status Abhilash Kesavan
2014-12-10  4:14   ` Sudeep Holla
2014-12-10  4:14     ` Sudeep Holla
2014-12-10  4:25     ` Abhilash Kesavan
2014-12-10  4:25       ` Abhilash Kesavan
2014-12-10  5:16       ` Sudeep Holla
2014-12-10  5:16         ` Sudeep Holla
2015-01-08  6:45         ` Sudeep Holla
2015-01-08  6:45           ` Sudeep Holla
2015-01-08 15:27           ` Abhilash Kesavan
2015-01-08 15:27             ` Abhilash Kesavan
2015-01-09  5:10             ` Sudeep Holla
2015-01-09  5:10               ` Sudeep Holla
2015-01-09 16:28               ` Abhilash Kesavan
2015-01-09 16:28                 ` Abhilash Kesavan
2015-01-09 21:09                 ` Kevin Hilman
2015-01-09 21:09                   ` Kevin Hilman
2015-01-10  3:21                   ` Abhilash Kesavan
2015-01-10  3:21                     ` Abhilash Kesavan
2014-12-10 18:29   ` Nicolas Pitre
2014-12-10 18:29     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM4voakjWgnEXoXT1LH2ZFBy=U4vfXFXS1Su8VB7Cd3s3wqmSA@mail.gmail.com' \
    --to=kesavan.abhilash@gmail.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=olof@lixom.net \
    --cc=punit.agrawal@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.