* + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree
@ 2021-07-14 23:44 akpm
2021-07-15 9:35 ` Oscar Salvador
2021-07-15 12:14 ` Pankaj Gupta
0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2021-07-14 23:44 UTC (permalink / raw)
To: aneesh.kumar, anshuman.khandual, anton, ardb, bauerman, benh,
bhe, borntraeger, bp, catalin.marinas, cheloha, christophe.leroy,
dalias, dan.j.williams, dave.hansen, dave.jiang, david, gor, hca,
hpa, jasowang, joe, justin.he, ldufour, lenb, luto, mhocko,
michel, mingo, mm-commits, mpe, mst, nathanl, npiggin, osalvador,
pankaj.gupta.linux, pankaj.gupta, pasha.tatashin, paulus, peterz,
pmorel, rafael.j.wysocki, richard.weiyang, rjw, rppt, slyfox,
tglx, vbabka, vishal.l.verma, vkuznets, wangkefeng.wang, will,
ysato
The patch titled
Subject: ACPI: memhotplug: memory resources cannot be enabled yet
has been added to the -mm tree. Its filename is
acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: David Hildenbrand <david@redhat.com>
Subject: ACPI: memhotplug: memory resources cannot be enabled yet
We allocate + initialize everything from scratch. In case enabling the
device fails, we free all memory resourcs.
Link: https://lkml.kernel.org/r/20210712124052.26491-5-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Anton Blanchard <anton@ozlabs.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Baoquan He <bhe@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Jia He <justin.he@arm.com>
Cc: Joe Perches <joe@perches.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Laurent Dufour <ldufour@linux.ibm.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Michel Lespinasse <michel@lespinasse.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nathan Lynch <nathanl@linux.ibm.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Pankaj Gupta <pankaj.gupta@ionos.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Pierre Morel <pmorel@linux.ibm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Rich Felker <dalias@libc.org>
Cc: Scott Cheloha <cheloha@linux.ibm.com>
Cc: Sergei Trofimovich <slyfox@gentoo.org>
Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/acpi_memhotplug.c | 4 ----
1 file changed, 4 deletions(-)
--- a/drivers/acpi/acpi_memhotplug.c~acpi-memhotplug-memory-resources-cannot-be-enabled-yet
+++ a/drivers/acpi/acpi_memhotplug.c
@@ -182,10 +182,6 @@ static int acpi_memory_enable_device(str
* (i.e. memory-hot-remove function)
*/
list_for_each_entry(info, &mem_device->res_list, list) {
- if (info->enabled) { /* just sanity check...*/
- num_enabled++;
- continue;
- }
/*
* If the memory block size is zero, please ignore it.
* Don't try to do the following memory hotplug flowchart.
_
Patches currently in -mm which might be from david@redhat.com are
memory-hotplugrst-remove-locking-details-from-admin-guide.patch
memory-hotplugrst-complete-admin-guide-overhaul.patch
mm-memory_hotplug-use-unsigned-long-for-pfn-in-zone_for_pfn_range.patch
mm-memory_hotplug-remove-nid-parameter-from-arch_remove_memory.patch
mm-memory_hotplug-remove-nid-parameter-from-remove_memory-and-friends.patch
acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree
2021-07-14 23:44 + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree akpm
@ 2021-07-15 9:35 ` Oscar Salvador
2021-07-15 12:14 ` Pankaj Gupta
1 sibling, 0 replies; 3+ messages in thread
From: Oscar Salvador @ 2021-07-15 9:35 UTC (permalink / raw)
To: akpm
Cc: aneesh.kumar, anshuman.khandual, anton, ardb, bauerman, benh,
bhe, borntraeger, bp, catalin.marinas, cheloha, christophe.leroy,
dalias, dan.j.williams, dave.hansen, dave.jiang, david, gor, hca,
hpa, jasowang, joe, justin.he, ldufour, lenb, luto, mhocko,
michel, mingo, mm-commits, mpe, mst, nathanl, npiggin,
pankaj.gupta.linux, pankaj.gupta, pasha.tatashin, paulus, peterz,
pmorel, rafael.j.wysocki, richard.weiyang, rjw, rppt, slyfox,
tglx, vbabka, vishal.l.verma, vkuznets, wangkefeng.wang, will,
ysato
> ------------------------------------------------------
> From: David Hildenbrand <david@redhat.com>
> Subject: ACPI: memhotplug: memory resources cannot be enabled yet
>
> We allocate + initialize everything from scratch. In case enabling the
> device fails, we free all memory resourcs.
>
> Link: https://lkml.kernel.org/r/20210712124052.26491-5-david@redhat.com
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Anton Blanchard <anton@ozlabs.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Jia He <justin.he@arm.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: Laurent Dufour <ldufour@linux.ibm.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Michel Lespinasse <michel@lespinasse.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Nathan Lynch <nathanl@linux.ibm.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Pankaj Gupta <pankaj.gupta@ionos.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Pierre Morel <pmorel@linux.ibm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Scott Cheloha <cheloha@linux.ibm.com>
> Cc: Sergei Trofimovich <slyfox@gentoo.org>
> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree
2021-07-14 23:44 + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree akpm
2021-07-15 9:35 ` Oscar Salvador
@ 2021-07-15 12:14 ` Pankaj Gupta
1 sibling, 0 replies; 3+ messages in thread
From: Pankaj Gupta @ 2021-07-15 12:14 UTC (permalink / raw)
To: Andrew Morton
Cc: Aneesh Kumar K.V, Anshuman Khandual, Anton Blanchard,
Ard Biesheuvel, Thiago Jung Bauermann, Benjamin Herrenschmidt,
Baoquan He, Christian Borntraeger, Borislav Petkov,
Catalin Marinas, Scott Cheloha, Christophe Leroy, Rich Felker,
Dan Williams, Dave Hansen, Dave Jiang, David Hildenbrand,
Vasily Gorbik, Heiko Carstens, H. Peter Anvin, Jason Wang,
Joe Perches, Jia He, Laurent Dufour, Len Brown, Andy Lutomirski,
Michal Hocko, Michel Lespinasse, Ingo Molnar, mm-commits,
Michael Ellerman, Michael S . Tsirkin, Nathan Lynch,
Nicholas Piggin, Oscar Salvador, Pankaj Gupta, Pavel Tatashin,
Paul Mackerras, Peter Zijlstra, Pierre Morel, Rafael J. Wysocki,
Wei Yang, Rafael J. Wysocki, Mike Rapoport, Sergei Trofimovich,
Thomas Gleixner, Vlastimil Babka, Vishal Verma, Vitaly Kuznetsov,
Kefeng Wang, Will Deacon, Yoshinori Sato
> The patch titled
> Subject: ACPI: memhotplug: memory resources cannot be enabled yet
> has been added to the -mm tree. Its filename is
> acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
>
> This patch should soon appear at
> https://ozlabs.org/~akpm/mmots/broken-out/acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
> and later at
> https://ozlabs.org/~akpm/mmotm/broken-out/acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: David Hildenbrand <david@redhat.com>
> Subject: ACPI: memhotplug: memory resources cannot be enabled yet
>
> We allocate + initialize everything from scratch. In case enabling the
> device fails, we free all memory resourcs.
>
> Link: https://lkml.kernel.org/r/20210712124052.26491-5-david@redhat.com
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Anton Blanchard <anton@ozlabs.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Jia He <justin.he@arm.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: Laurent Dufour <ldufour@linux.ibm.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Michel Lespinasse <michel@lespinasse.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Nathan Lynch <nathanl@linux.ibm.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Pankaj Gupta <pankaj.gupta@ionos.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Pierre Morel <pmorel@linux.ibm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Scott Cheloha <cheloha@linux.ibm.com>
> Cc: Sergei Trofimovich <slyfox@gentoo.org>
> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/acpi/acpi_memhotplug.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> --- a/drivers/acpi/acpi_memhotplug.c~acpi-memhotplug-memory-resources-cannot-be-enabled-yet
> +++ a/drivers/acpi/acpi_memhotplug.c
> @@ -182,10 +182,6 @@ static int acpi_memory_enable_device(str
> * (i.e. memory-hot-remove function)
> */
> list_for_each_entry(info, &mem_device->res_list, list) {
> - if (info->enabled) { /* just sanity check...*/
> - num_enabled++;
> - continue;
> - }
> /*
> * If the memory block size is zero, please ignore it.
> * Don't try to do the following memory hotplug flowchart.
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-15 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 23:44 + acpi-memhotplug-memory-resources-cannot-be-enabled-yet.patch added to -mm tree akpm
2021-07-15 9:35 ` Oscar Salvador
2021-07-15 12:14 ` Pankaj Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.