* [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
@ 2020-03-30 22:08 Wei Yang
2020-03-31 6:53 ` Pankaj Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yang @ 2020-03-30 22:08 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, jgg, david, jhubbard, bhe, Wei Yang
Slightly simplify the code by initializing user_mask with NODE_MASK_NONE,
instead of later calling nodes_clear(). This saves a line of code.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
v4: adjust subject/description as suggested by John Hubbard
v3: adjust the commit log a little
v2: use NODE_MASK_NONE as suggested by David Hildenbrand
---
mm/page_alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ef790dfad6aa..dfcf2682ed40 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
{
static int node_order[MAX_NUMNODES];
int node, load, nr_nodes = 0;
- nodemask_t used_mask;
+ nodemask_t used_mask = NODE_MASK_NONE;
int local_node, prev_node;
/* NUMA-aware ordering of nodes */
local_node = pgdat->node_id;
load = nr_online_nodes;
prev_node = local_node;
- nodes_clear(used_mask);
memset(node_order, 0, sizeof(node_order));
while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
2020-03-30 22:08 [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists() Wei Yang
@ 2020-03-31 6:53 ` Pankaj Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Pankaj Gupta @ 2020-03-31 6:53 UTC (permalink / raw)
To: Wei Yang
Cc: Andrew Morton, linux-mm, linux-kernel, jgg, David Hildenbrand,
jhubbard, Baoquan He
> Slightly simplify the code by initializing user_mask with NODE_MASK_NONE,
> instead of later calling nodes_clear(). This saves a line of code.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> ---
> v4: adjust subject/description as suggested by John Hubbard
> v3: adjust the commit log a little
> v2: use NODE_MASK_NONE as suggested by David Hildenbrand
> ---
> mm/page_alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ef790dfad6aa..dfcf2682ed40 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
> {
> static int node_order[MAX_NUMNODES];
> int node, load, nr_nodes = 0;
> - nodemask_t used_mask;
> + nodemask_t used_mask = NODE_MASK_NONE;
> int local_node, prev_node;
>
> /* NUMA-aware ordering of nodes */
> local_node = pgdat->node_id;
> load = nr_online_nodes;
> prev_node = local_node;
> - nodes_clear(used_mask);
>
> memset(node_order, 0, sizeof(node_order));
> while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
> --
> 2.23.0
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()
@ 2020-03-31 6:53 ` Pankaj Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Pankaj Gupta @ 2020-03-31 6:53 UTC (permalink / raw)
To: Wei Yang
Cc: Andrew Morton, linux-mm, linux-kernel, jgg, David Hildenbrand,
jhubbard, Baoquan He
> Slightly simplify the code by initializing user_mask with NODE_MASK_NONE,
> instead of later calling nodes_clear(). This saves a line of code.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> ---
> v4: adjust subject/description as suggested by John Hubbard
> v3: adjust the commit log a little
> v2: use NODE_MASK_NONE as suggested by David Hildenbrand
> ---
> mm/page_alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ef790dfad6aa..dfcf2682ed40 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
> {
> static int node_order[MAX_NUMNODES];
> int node, load, nr_nodes = 0;
> - nodemask_t used_mask;
> + nodemask_t used_mask = NODE_MASK_NONE;
> int local_node, prev_node;
>
> /* NUMA-aware ordering of nodes */
> local_node = pgdat->node_id;
> load = nr_online_nodes;
> prev_node = local_node;
> - nodes_clear(used_mask);
>
> memset(node_order, 0, sizeof(node_order));
> while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
> --
> 2.23.0
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-31 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 22:08 [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists() Wei Yang
2020-03-31 6:53 ` Pankaj Gupta
2020-03-31 6:53 ` Pankaj Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.