* [PATCH] docs/nvdimm: Update nvdimm option value in machine example
@ 2021-07-26 7:11 Pankaj Gupta
2021-09-23 9:47 ` Pankaj Gupta
2021-09-23 9:51 ` Laurent Vivier
0 siblings, 2 replies; 5+ messages in thread
From: Pankaj Gupta @ 2021-07-26 7:11 UTC (permalink / raw)
To: xiaoguangrong.eric, pankaj.gupta.linux; +Cc: qemu-devel, Pankaj Gupta
Update nvdimm option value in example command from "-machine pc,nvdimm"
to "-machine pc,nvdimm=on" as former complains with the below error:
"qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
---
docs/nvdimm.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
index 0aae682be3..fd7773dc5a 100644
--- a/docs/nvdimm.txt
+++ b/docs/nvdimm.txt
@@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
way to create a vNVDIMM device at startup time is done via the
following command line options:
- -machine pc,nvdimm
+ -machine pc,nvdimm=on
-m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
-object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
-device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example
2021-07-26 7:11 [PATCH] docs/nvdimm: Update nvdimm option value in machine example Pankaj Gupta
@ 2021-09-23 9:47 ` Pankaj Gupta
2021-09-23 9:56 ` Laurent Vivier
2021-09-23 9:51 ` Laurent Vivier
1 sibling, 1 reply; 5+ messages in thread
From: Pankaj Gupta @ 2021-09-23 9:47 UTC (permalink / raw)
To: Xiao Guangrong, Pankaj Gupta, Laurent Vivier, Stefan Hajnoczi
Cc: Qemu Developers, Pankaj Gupta
ping
> Update nvdimm option value in example command from "-machine pc,nvdimm"
> to "-machine pc,nvdimm=on" as former complains with the below error:
>
> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> ---
> docs/nvdimm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
> index 0aae682be3..fd7773dc5a 100644
> --- a/docs/nvdimm.txt
> +++ b/docs/nvdimm.txt
> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
> way to create a vNVDIMM device at startup time is done via the
> following command line options:
>
> - -machine pc,nvdimm
> + -machine pc,nvdimm=on
> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
> -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example
2021-07-26 7:11 [PATCH] docs/nvdimm: Update nvdimm option value in machine example Pankaj Gupta
2021-09-23 9:47 ` Pankaj Gupta
@ 2021-09-23 9:51 ` Laurent Vivier
1 sibling, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2021-09-23 9:51 UTC (permalink / raw)
To: Pankaj Gupta, xiaoguangrong.eric; +Cc: qemu-trivial, qemu-devel, Pankaj Gupta
Le 26/07/2021 à 09:11, Pankaj Gupta a écrit :
> Update nvdimm option value in example command from "-machine pc,nvdimm"
> to "-machine pc,nvdimm=on" as former complains with the below error:
>
> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> ---
> docs/nvdimm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
> index 0aae682be3..fd7773dc5a 100644
> --- a/docs/nvdimm.txt
> +++ b/docs/nvdimm.txt
> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
> way to create a vNVDIMM device at startup time is done via the
> following command line options:
>
> - -machine pc,nvdimm
> + -machine pc,nvdimm=on
> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
> -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
cc: qemu-trivial
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example
2021-09-23 9:47 ` Pankaj Gupta
@ 2021-09-23 9:56 ` Laurent Vivier
2021-09-23 10:32 ` Pankaj Gupta
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2021-09-23 9:56 UTC (permalink / raw)
To: Pankaj Gupta, Xiao Guangrong, Laurent Vivier, Stefan Hajnoczi
Cc: Qemu Developers, Pankaj Gupta
Le 23/09/2021 à 11:47, Pankaj Gupta a écrit :
> ping
Could you post your patch with an email address ("From") that is the same as the "Signed-off-by"?
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
Thanks,
Laurent
>> Update nvdimm option value in example command from "-machine pc,nvdimm"
>> to "-machine pc,nvdimm=on" as former complains with the below error:
>>
>> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
>>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
>> ---
>> docs/nvdimm.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
>> index 0aae682be3..fd7773dc5a 100644
>> --- a/docs/nvdimm.txt
>> +++ b/docs/nvdimm.txt
>> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
>> way to create a vNVDIMM device at startup time is done via the
>> following command line options:
>>
>> - -machine pc,nvdimm
>> + -machine pc,nvdimm=on
>> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
>> -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
>> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
>> --
>> 2.25.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example
2021-09-23 9:56 ` Laurent Vivier
@ 2021-09-23 10:32 ` Pankaj Gupta
0 siblings, 0 replies; 5+ messages in thread
From: Pankaj Gupta @ 2021-09-23 10:32 UTC (permalink / raw)
To: Laurent Vivier
Cc: Laurent Vivier, Pankaj Gupta, Xiao Guangrong, Stefan Hajnoczi,
Qemu Developers
> > ping
>
> Could you post your patch with an email address ("From") that is the same as the "Signed-off-by"?
Sure sent a V2.
Thank you,
Pankaj
>
> https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
>
> Thanks,
> Laurent
>
> >> Update nvdimm option value in example command from "-machine pc,nvdimm"
> >> to "-machine pc,nvdimm=on" as former complains with the below error:
> >>
> >> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
> >>
> >> Signed-off-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> >> ---
> >> docs/nvdimm.txt | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
> >> index 0aae682be3..fd7773dc5a 100644
> >> --- a/docs/nvdimm.txt
> >> +++ b/docs/nvdimm.txt
> >> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
> >> way to create a vNVDIMM device at startup time is done via the
> >> following command line options:
> >>
> >> - -machine pc,nvdimm
> >> + -machine pc,nvdimm=on
> >> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
> >> -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
> >> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
> >> --
> >> 2.25.1
> >>
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-23 10:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 7:11 [PATCH] docs/nvdimm: Update nvdimm option value in machine example Pankaj Gupta
2021-09-23 9:47 ` Pankaj Gupta
2021-09-23 9:56 ` Laurent Vivier
2021-09-23 10:32 ` Pankaj Gupta
2021-09-23 9:51 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.