* [PATCH] perf/core: Call LSM hook after copying perf_event_attr
@ 2022-06-02 22:47 Namhyung Kim
2022-06-03 15:05 ` Joel Fernandes
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2022-06-02 22:47 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Jiri Olsa, Mark Rutland,
Alexander Shishkin, LKML, Stephane Eranian, Andi Kleen,
Ian Rogers, James Morris, Joel Fernandes
It passes the attr struct to the security_perf_event_open() but it's
not initialized yet.
Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 7858bafffa9d..e035545f624f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12033,12 +12033,12 @@ SYSCALL_DEFINE5(perf_event_open,
if (flags & ~PERF_FLAG_ALL)
return -EINVAL;
- /* Do we allow access to perf_event_open(2) ? */
- err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
+ err = perf_copy_attr(attr_uptr, &attr);
if (err)
return err;
- err = perf_copy_attr(attr_uptr, &attr);
+ /* Do we allow access to perf_event_open(2) ? */
+ err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
if (err)
return err;
--
2.36.1.255.ge46751e96f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/core: Call LSM hook after copying perf_event_attr
2022-06-02 22:47 [PATCH] perf/core: Call LSM hook after copying perf_event_attr Namhyung Kim
@ 2022-06-03 15:05 ` Joel Fernandes
2022-06-24 17:30 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Joel Fernandes @ 2022-06-03 15:05 UTC (permalink / raw)
To: Namhyung Kim
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Jiri Olsa,
Mark Rutland, Alexander Shishkin, LKML, Stephane Eranian,
Andi Kleen, Ian Rogers, James Morris
On Thu, Jun 02, 2022 at 03:47:54PM -0700, Namhyung Kim wrote:
> It passes the attr struct to the security_perf_event_open() but it's
> not initialized yet.
>
> Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
> Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> kernel/events/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 7858bafffa9d..e035545f624f 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -12033,12 +12033,12 @@ SYSCALL_DEFINE5(perf_event_open,
> if (flags & ~PERF_FLAG_ALL)
> return -EINVAL;
>
> - /* Do we allow access to perf_event_open(2) ? */
> - err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
> + err = perf_copy_attr(attr_uptr, &attr);
> if (err)
> return err;
>
> - err = perf_copy_attr(attr_uptr, &attr);
> + /* Do we allow access to perf_event_open(2) ? */
> + err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
> if (err)
> return err;
>
> --
> 2.36.1.255.ge46751e96f-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/core: Call LSM hook after copying perf_event_attr
2022-06-03 15:05 ` Joel Fernandes
@ 2022-06-24 17:30 ` Namhyung Kim
0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2022-06-24 17:30 UTC (permalink / raw)
To: Joel Fernandes, Peter Zijlstra
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Jiri Olsa, Mark Rutland,
Alexander Shishkin, LKML, Stephane Eranian, Andi Kleen,
Ian Rogers, James Morris
Hi Peter,
On Fri, Jun 3, 2022 at 8:05 AM Joel Fernandes <joel@joelfernandes.org> wrote:
>
> On Thu, Jun 02, 2022 at 03:47:54PM -0700, Namhyung Kim wrote:
> > It passes the attr struct to the security_perf_event_open() but it's
> > not initialized yet.
> >
> > Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
> > Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> > kernel/events/core.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 7858bafffa9d..e035545f624f 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -12033,12 +12033,12 @@ SYSCALL_DEFINE5(perf_event_open,
> > if (flags & ~PERF_FLAG_ALL)
> > return -EINVAL;
> >
> > - /* Do we allow access to perf_event_open(2) ? */
> > - err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
> > + err = perf_copy_attr(attr_uptr, &attr);
> > if (err)
> > return err;
> >
> > - err = perf_copy_attr(attr_uptr, &attr);
> > + /* Do we allow access to perf_event_open(2) ? */
> > + err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
>
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Any chance you can pick this up?
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-24 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 22:47 [PATCH] perf/core: Call LSM hook after copying perf_event_attr Namhyung Kim
2022-06-03 15:05 ` Joel Fernandes
2022-06-24 17:30 ` Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.