All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti Datta <omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
	Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCHv3 8/8] i2c: omap: cleanup the sysc write
Date: Mon, 5 Nov 2012 23:59:07 +0530	[thread overview]
Message-ID: <CAM=Q2csELdqM2PRtaswx7Ug6KxB+CwVakXnBY6O=FJrKkBWz6A@mail.gmail.com> (raw)
In-Reply-To: <5097F642.9010803-l0cyMroinI0@public.gmane.org>

On 11/5/12, Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org> wrote:
> On 11/5/2012 3:25 PM, Felipe Balbi wrote:
>> Hi,
>>
>> On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote:
>>> On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote:
>>>>> -							dev->syscstate);
>>>>>> -		}
>>>> not sure if this will work. What about the first time you call reset()
>>>> ?
>>>> won't SYSC just contain the reset values ?
>>> No actually the hwmod sets the value.
>>
>> ahaaa, ok good. Let's get an Ack from Benoit, then.
>
> Well, in fact, I'm a little bit surprised that we still have to hack the

there was an attempt [1]

the pdata stuff may have issues with dt having to deal with more pdata [2]


> SYSC directly without using an omap_device API.

 Paul was not happy with omap device api  [3]

As far as the patch is concerned it is only getting rid of the hard coded flags
and the rev check.

> I know that we have to
> do some weird stuff for reseting that IP, but didn't we already exposed
> something to allow that?
>
> Regards,
> Benoit

[1]  http://www.spinics.net/lists/linux-i2c/msg06810.html
[2]  http://www.spinics.net/lists/linux-i2c/msg06937.html
[3] http://www.spinics.net/lists/linux-i2c/msg06943.html

WARNING: multiple messages have this Message-ID (diff)
From: omaplinuxkernel@gmail.com (Shubhrajyoti Datta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 8/8] i2c: omap: cleanup the sysc write
Date: Mon, 5 Nov 2012 23:59:07 +0530	[thread overview]
Message-ID: <CAM=Q2csELdqM2PRtaswx7Ug6KxB+CwVakXnBY6O=FJrKkBWz6A@mail.gmail.com> (raw)
In-Reply-To: <5097F642.9010803@ti.com>

On 11/5/12, Cousson, Benoit <b-cousson@ti.com> wrote:
> On 11/5/2012 3:25 PM, Felipe Balbi wrote:
>> Hi,
>>
>> On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote:
>>> On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote:
>>>>> -							dev->syscstate);
>>>>>> -		}
>>>> not sure if this will work. What about the first time you call reset()
>>>> ?
>>>> won't SYSC just contain the reset values ?
>>> No actually the hwmod sets the value.
>>
>> ahaaa, ok good. Let's get an Ack from Benoit, then.
>
> Well, in fact, I'm a little bit surprised that we still have to hack the

there was an attempt [1]

the pdata stuff may have issues with dt having to deal with more pdata [2]


> SYSC directly without using an omap_device API.

 Paul was not happy with omap device api  [3]

As far as the patch is concerned it is only getting rid of the hard coded flags
and the rev check.

> I know that we have to
> do some weird stuff for reseting that IP, but didn't we already exposed
> something to allow that?
>
> Regards,
> Benoit

[1]  http://www.spinics.net/lists/linux-i2c/msg06810.html
[2]  http://www.spinics.net/lists/linux-i2c/msg06937.html
[3] http://www.spinics.net/lists/linux-i2c/msg06943.html

  parent reply	other threads:[~2012-11-05 18:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 12:23 [PATCHv3 0/7] i2c: omap: updates Shubhrajyoti D
2012-11-05 12:23 ` Shubhrajyoti D
2012-11-05 12:23 ` [PATCHv3 2/8] i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207 Shubhrajyoti D
2012-11-05 12:23   ` Shubhrajyoti D
2012-11-05 12:23 ` [PATCHv3 4/8] ARM: i2c: omap: Remove the i207 errata flag Shubhrajyoti D
2012-11-05 12:23   ` Shubhrajyoti D
     [not found] ` <1352118223-3796-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 12:23   ` [PATCHv3 1/8] i2c: omap: Fix the revision register read Shubhrajyoti D
2012-11-05 12:23     ` Shubhrajyoti D
2012-11-05 14:11     ` Felipe Balbi
2012-11-05 14:11       ` Felipe Balbi
2012-11-05 12:23   ` [PATCHv3 3/8] i2c: omap: remove the dtrev Shubhrajyoti D
2012-11-05 12:23     ` Shubhrajyoti D
     [not found]     ` <1352118223-3796-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 14:11       ` Felipe Balbi
2012-11-05 14:11         ` Felipe Balbi
2012-11-05 12:23   ` [PATCHv3 5/8] i2c: omap: re-factor omap_i2c_init function Shubhrajyoti D
2012-11-05 12:23     ` Shubhrajyoti D
2012-11-05 12:23   ` [PATCHv3 7/8] i2c: omap: Restore i2c context always Shubhrajyoti D
2012-11-05 12:23     ` Shubhrajyoti D
2012-11-05 12:23   ` [PATCHv3 8/8] i2c: omap: cleanup the sysc write Shubhrajyoti D
2012-11-05 12:23     ` Shubhrajyoti D
     [not found]     ` <1352118223-3796-9-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 14:14       ` Felipe Balbi
2012-11-05 14:14         ` Felipe Balbi
2012-11-05 14:23         ` Shubhrajyoti
2012-11-05 14:23           ` Shubhrajyoti
     [not found]           ` <5097CBF1.6060108-l0cyMroinI0@public.gmane.org>
2012-11-05 14:25             ` Felipe Balbi
2012-11-05 14:25               ` Felipe Balbi
2012-11-05 17:24               ` Cousson, Benoit
2012-11-05 17:24                 ` Cousson, Benoit
     [not found]                 ` <5097F642.9010803-l0cyMroinI0@public.gmane.org>
2012-11-05 18:29                   ` Shubhrajyoti Datta [this message]
2012-11-05 18:29                     ` Shubhrajyoti Datta
2012-11-13 12:50   ` [PATCHv3 0/7] i2c: omap: updates Shubhrajyoti Datta
2012-11-13 12:50     ` Shubhrajyoti Datta
2012-11-14 12:04   ` Wolfram Sang
2012-11-14 12:04     ` Wolfram Sang
2012-11-14 13:09     ` Shubhrajyoti
2012-11-14 13:09       ` Shubhrajyoti
2012-11-05 12:23 ` [PATCHv3 6/8] i2c: omap: make reset a seperate function Shubhrajyoti D
2012-11-05 12:23   ` Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM=Q2csELdqM2PRtaswx7Ug6KxB+CwVakXnBY6O=FJrKkBWz6A@mail.gmail.com' \
    --to=omaplinuxkernel-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.