From: Shubhrajyoti Datta <omaplinuxkernel@gmail.com> To: Luciano Coelho <coelho@ti.com> Cc: balbi@ti.com, linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, tony@atomide.com, khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de, grant.likely@secretlab.ca, rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org, Benoit Cousson <b-cousson@ti.com> Subject: Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set Date: Wed, 8 Feb 2012 16:42:56 +0530 [thread overview] Message-ID: <CAM=Q2cvZWdUk-v4-EWUJzAf4br-4+tO2s3qS_dn4KhHp+mm2+g@mail.gmail.com> (raw) In-Reply-To: <1328699077.20197.51.camel@cumari> On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho <coelho@ti.com> wrote: > On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: >> On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: >> > Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building >> >> we generally like to see the commit subject here too. And adding the >> abbreviated commit instead of the full sha1, wouldn't hurt either ;-) > > Ok, different practices. :) However there was already a discurssion. Anyways thanks for the patch. http://permalink.gmane.org/gmane.linux.ports.arm.omap/69796 > > I'll send v2. I think there was already a fix for this. http://www.spinics.net/lists/linux-omap/msg63151.html Anyways thanks for the patch. > > >> > i2c_omap.c breaks if CONFIG_OF is not set: >> > >> > drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': >> > drivers/i2c/busses/i2c-omap.c:1021: error: 'omap_i2c_of_match' undeclared (first use in this function) >> > drivers/i2c/busses/i2c-omap.c:1021: error: (Each undeclared identifier is reported only once >> > drivers/i2c/busses/i2c-omap.c:1021: error: for each function it appears in.) >> > >> > This is because the definition of omap_i2c_of_match is #ifdef'd on >> > CONFIG_OF, but the usage of it is not. >> > >> > Since the places where omap_ic2_of_match are prepared to get NULL >> > pointers if CONFIG_OF is not defined, we can simply define it to NULL. >> > >> > Cc: Benoit Cousson <b-cousson@ti.com> >> > Signed-off-by: Luciano Coelho <coelho@ti.com> >> >> after fixing the commit log, you can add: >> >> Reviewed-by: Felipe Balbi <balbi@ti.com> >> >> if you want. > > Thanks for your quick review! > > -- > Cheers, > Luca. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shubhrajyoti Datta <omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org> Cc: balbi-l0cyMroinI0@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org> Subject: Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set Date: Wed, 8 Feb 2012 16:42:56 +0530 [thread overview] Message-ID: <CAM=Q2cvZWdUk-v4-EWUJzAf4br-4+tO2s3qS_dn4KhHp+mm2+g@mail.gmail.com> (raw) In-Reply-To: <1328699077.20197.51.camel@cumari> On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org> wrote: > On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: >> On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: >> > Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building >> >> we generally like to see the commit subject here too. And adding the >> abbreviated commit instead of the full sha1, wouldn't hurt either ;-) > > Ok, different practices. :) However there was already a discurssion. Anyways thanks for the patch. http://permalink.gmane.org/gmane.linux.ports.arm.omap/69796 > > I'll send v2. I think there was already a fix for this. http://www.spinics.net/lists/linux-omap/msg63151.html Anyways thanks for the patch. > > >> > i2c_omap.c breaks if CONFIG_OF is not set: >> > >> > drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': >> > drivers/i2c/busses/i2c-omap.c:1021: error: 'omap_i2c_of_match' undeclared (first use in this function) >> > drivers/i2c/busses/i2c-omap.c:1021: error: (Each undeclared identifier is reported only once >> > drivers/i2c/busses/i2c-omap.c:1021: error: for each function it appears in.) >> > >> > This is because the definition of omap_i2c_of_match is #ifdef'd on >> > CONFIG_OF, but the usage of it is not. >> > >> > Since the places where omap_ic2_of_match are prepared to get NULL >> > pointers if CONFIG_OF is not defined, we can simply define it to NULL. >> > >> > Cc: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org> >> > Signed-off-by: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org> >> >> after fixing the commit log, you can add: >> >> Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> >> >> if you want. > > Thanks for your quick review! > > -- > Cheers, > Luca. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-08 11:13 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-08 10:56 [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set Luciano Coelho 2012-02-08 10:59 ` Felipe Balbi 2012-02-08 10:59 ` Felipe Balbi 2012-02-08 11:04 ` Luciano Coelho 2012-02-08 11:12 ` Shubhrajyoti Datta [this message] 2012-02-08 11:12 ` Shubhrajyoti Datta 2012-02-08 11:25 ` Luciano Coelho 2012-02-08 11:25 ` Luciano Coelho 2012-02-08 15:48 ` Cousson, Benoit 2012-02-08 15:48 ` Cousson, Benoit 2012-02-08 15:54 ` Coelho, Luciano 2012-02-08 11:01 ` Luciano Coelho 2012-02-08 11:01 ` Luciano Coelho
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAM=Q2cvZWdUk-v4-EWUJzAf4br-4+tO2s3qS_dn4KhHp+mm2+g@mail.gmail.com' \ --to=omaplinuxkernel@gmail.com \ --cc=b-cousson@ti.com \ --cc=balbi@ti.com \ --cc=ben-linux@fluff.org \ --cc=coelho@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=khali@linux-fr.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=rob.herring@calxeda.com \ --cc=tony@atomide.com \ --cc=w.sang@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.