All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taehee Yoo <ap420073@gmail.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Netdev <netdev@vger.kernel.org>,
	martin.varghese@nokia.com
Subject: Re: [PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size
Date: Mon, 28 Dec 2020 11:26:44 +0900	[thread overview]
Message-ID: <CAMArcTVQmwrbeT=LNsNhSP4Cykz-ZchbpS4RQJpo=J_F8Pv-aQ@mail.gmail.com> (raw)
In-Reply-To: <20201227163331.GB27369@linux.home>

On Mon, 28 Dec 2020 at 01:33, Guillaume Nault <gnault@redhat.com> wrote:
>

Hi Guillaume,
Thank you for the review!

> On Sat, Dec 26, 2020 at 05:13:08PM +0000, Taehee Yoo wrote:
> > In the bareudp6_xmit_skb(), it calculates min_headroom.
> > At that point, it uses struct iphdr, but it's not correct.
> > So panic could occur.
> > The struct ipv6hdr should be used.
> >
> > Test commands:
> >     ip netns add A
> >     ip netns add B
> >     ip link add veth0 type veth peer name veth1
> >     ip link set veth0 netns A
>
> Missing "ip link set veth1 netns B", so the reproducer unfortunately
> doesn't work.
>

Sorry, This is my mistake.

> BTW, you can also simplify the script by creating the veth devices
> directly in the right netns:
>   ip link add name veth0 netns A type veth peer name veth1 netns B
>

Thanks, It's really useful to me :)

> Apart from that,
> Acked-by: Guillaume Nault <gnault@redhat.com>
>
> And thanks a lot for the reproducers!

Thank you so much for the review,
I will send a v2 patch, which will fix a reproducer script.

      reply	other threads:[~2020-12-28  2:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26 17:13 [PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size Taehee Yoo
2020-12-27 16:33 ` Guillaume Nault
2020-12-28  2:26   ` Taehee Yoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMArcTVQmwrbeT=LNsNhSP4Cykz-ZchbpS4RQJpo=J_F8Pv-aQ@mail.gmail.com' \
    --to=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gnault@redhat.com \
    --cc=kuba@kernel.org \
    --cc=martin.varghese@nokia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.