* Re: [PATCH 6/7] soundwire: intel: remove unnecessary init
@ 2023-06-22 22:37 K Smart
0 siblings, 0 replies; 5+ messages in thread
From: K Smart @ 2023-06-22 22:37 UTC (permalink / raw)
To: yung-chuan.liao
Cc: alsa-devel, bard.liao, broonie, gregkh, linux-kernel,
pierre-louis.bossart, sanyog.r.kale, srinivas.kandagatla, tiwai,
vinod.koul, vkoul
REMOVE NOW
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/7] soundwire: intel: remove unnecessary init
2021-12-13 5:46 ` Bard Liao
@ 2021-12-23 6:58 ` Vinod Koul
-1 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2021-12-23 6:58 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, linux-kernel, tiwai, broonie, gregkh,
srinivas.kandagatla, pierre-louis.bossart, sanyog.r.kale,
bard.liao
On 13-12-21, 13:46, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a
> value that is never used. [unreadVariable]
> int ret = 0;
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Rander Wang <rander.wang@intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> ---
> drivers/soundwire/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index e946d1283892..45ea55a7d0c8 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev)
> struct sdw_intel *sdw = cdns_to_intel(cdns);
> struct sdw_bus *bus = &cdns->bus;
> u32 clock_stop_quirks;
> - int ret = 0;
> + int ret;
Ideally this should not be part of this series!
If Mark wants to pick:
Acked-By: Vinod Koul <vkoul@kernel.org>
>
> if (bus->prop.hw_disabled || !sdw->startup_done) {
> dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",
> --
> 2.17.1
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/7] soundwire: intel: remove unnecessary init
@ 2021-12-23 6:58 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2021-12-23 6:58 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, tiwai, gregkh, linux-kernel, pierre-louis.bossart,
broonie, srinivas.kandagatla, sanyog.r.kale, bard.liao
On 13-12-21, 13:46, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a
> value that is never used. [unreadVariable]
> int ret = 0;
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Rander Wang <rander.wang@intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> ---
> drivers/soundwire/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index e946d1283892..45ea55a7d0c8 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev)
> struct sdw_intel *sdw = cdns_to_intel(cdns);
> struct sdw_bus *bus = &cdns->bus;
> u32 clock_stop_quirks;
> - int ret = 0;
> + int ret;
Ideally this should not be part of this series!
If Mark wants to pick:
Acked-By: Vinod Koul <vkoul@kernel.org>
>
> if (bus->prop.hw_disabled || !sdw->startup_done) {
> dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",
> --
> 2.17.1
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 6/7] soundwire: intel: remove unnecessary init
2021-12-13 5:46 [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao
@ 2021-12-13 5:46 ` Bard Liao
0 siblings, 0 replies; 5+ messages in thread
From: Bard Liao @ 2021-12-13 5:46 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, tiwai, broonie, gregkh,
srinivas.kandagatla, pierre-louis.bossart, sanyog.r.kale,
bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
cppcheck warning:
drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a
value that is never used. [unreadVariable]
int ret = 0;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index e946d1283892..45ea55a7d0c8 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev)
struct sdw_intel *sdw = cdns_to_intel(cdns);
struct sdw_bus *bus = &cdns->bus;
u32 clock_stop_quirks;
- int ret = 0;
+ int ret;
if (bus->prop.hw_disabled || !sdw->startup_done) {
dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 6/7] soundwire: intel: remove unnecessary init
@ 2021-12-13 5:46 ` Bard Liao
0 siblings, 0 replies; 5+ messages in thread
From: Bard Liao @ 2021-12-13 5:46 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, tiwai, gregkh, linux-kernel, pierre-louis.bossart,
broonie, srinivas.kandagatla, sanyog.r.kale, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
cppcheck warning:
drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a
value that is never used. [unreadVariable]
int ret = 0;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index e946d1283892..45ea55a7d0c8 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev)
struct sdw_intel *sdw = cdns_to_intel(cdns);
struct sdw_bus *bus = &cdns->bus;
u32 clock_stop_quirks;
- int ret = 0;
+ int ret;
if (bus->prop.hw_disabled || !sdw->startup_done) {
dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-26 11:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-22 22:37 [PATCH 6/7] soundwire: intel: remove unnecessary init K Smart
-- strict thread matches above, loose matches on Subject: below --
2021-12-13 5:46 [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao
2021-12-13 5:46 ` [PATCH 6/7] soundwire: intel: remove unnecessary init Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 6:58 ` Vinod Koul
2021-12-23 6:58 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.