All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Sundin <git@stefansundin.com>
To: git@vger.kernel.org
Cc: Stefan Sundin via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH] Makefile: suppress macOS deprecation warning
Date: Sat, 19 Nov 2022 18:14:36 -0800	[thread overview]
Message-ID: <CAMDaVWGFi6CD+MMbWG=N57yyb8=k6AouB5h33NkKvs2q4UxRmQ@mail.gmail.com> (raw)
In-Reply-To: <a3cfe081-1e68-edda-b797-e68356988046@gmail.com>

On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:
> > From: Stefan Sundin <git@stefansundin.com>
> >
> > Compiling git on macOS 13 emits the following deprecation warning:
> >
> >         CC compat/fsmonitor/fsm-listen-darwin.o
> >     compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
> >             FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
> >             ^
> >     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
> >     FSEventStreamScheduleWithRunLoop(
> >     ^
> >     1 warning generated.
> >
> > Setting a minimum macOS version will suppress this deprecation warning.
> > Using a version lower than 10.13 will cause other warning messages to
> > be emitted.
> >
>
> Why don't instead follow the suggestion on the warning message
> (FSEventStreamSetDispatchQueue) instead?
>
> --
> An old man doll... just what I always wanted! - Clara

You are right, Bagas. I assumed, without actually looking it up, that
the new function had a higher-than-acceptable minimum macOS version
requirement. It turns out that the new function was added in 10.6
which is far better than requiring 10.13.

Please disregard this patch and I will attempt to update the code to
use the new function instead.

  reply	other threads:[~2022-11-20  2:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 20:06 [PATCH] Makefile: suppress macOS deprecation warning Stefan Sundin via GitGitGadget
2022-11-20  1:48 ` Bagas Sanjaya
2022-11-20  2:14   ` Stefan Sundin [this message]
2022-11-20 12:29     ` Bagas Sanjaya
2022-12-01 18:53       ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMDaVWGFi6CD+MMbWG=N57yyb8=k6AouB5h33NkKvs2q4UxRmQ@mail.gmail.com' \
    --to=git@stefansundin.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.