* [PATCH] Makefile: suppress macOS deprecation warning
@ 2022-11-19 20:06 Stefan Sundin via GitGitGadget
2022-11-20 1:48 ` Bagas Sanjaya
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Sundin via GitGitGadget @ 2022-11-19 20:06 UTC (permalink / raw)
To: git; +Cc: Stefan Sundin, Stefan Sundin
From: Stefan Sundin <git@stefansundin.com>
Compiling git on macOS 13 emits the following deprecation warning:
CC compat/fsmonitor/fsm-listen-darwin.o
compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
FSEventStreamScheduleWithRunLoop(
^
1 warning generated.
Setting a minimum macOS version will suppress this deprecation warning.
Using a version lower than 10.13 will cause other warning messages to
be emitted.
Signed-off-by: Stefan Sundin <git@stefansundin.com>
---
Makefile: suppress macOS deprecation warning
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1422%2Fstefansundin%2Fmacosx-version-min-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1422/stefansundin/macosx-version-min-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1422
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 4927379184c..8a729efd2d1 100644
--- a/Makefile
+++ b/Makefile
@@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T))
endif
ifeq ($(uname_S),Darwin)
+ BASIC_CFLAGS += -mmacosx-version-min=10.13
ifndef NO_FINK
ifeq ($(shell test -d /sw/lib && echo y),y)
BASIC_CFLAGS += -I/sw/include
base-commit: eea7033409a0ed713c78437fc76486983d211e25
--
gitgitgadget
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: suppress macOS deprecation warning
2022-11-19 20:06 [PATCH] Makefile: suppress macOS deprecation warning Stefan Sundin via GitGitGadget
@ 2022-11-20 1:48 ` Bagas Sanjaya
2022-11-20 2:14 ` Stefan Sundin
0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2022-11-20 1:48 UTC (permalink / raw)
To: Stefan Sundin via GitGitGadget, git; +Cc: Stefan Sundin
On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:
> From: Stefan Sundin <git@stefansundin.com>
>
> Compiling git on macOS 13 emits the following deprecation warning:
>
> CC compat/fsmonitor/fsm-listen-darwin.o
> compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
> FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
> ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
> FSEventStreamScheduleWithRunLoop(
> ^
> 1 warning generated.
>
> Setting a minimum macOS version will suppress this deprecation warning.
> Using a version lower than 10.13 will cause other warning messages to
> be emitted.
>
Why don't instead follow the suggestion on the warning message
(FSEventStreamSetDispatchQueue) instead?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: suppress macOS deprecation warning
2022-11-20 1:48 ` Bagas Sanjaya
@ 2022-11-20 2:14 ` Stefan Sundin
2022-11-20 12:29 ` Bagas Sanjaya
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Sundin @ 2022-11-20 2:14 UTC (permalink / raw)
To: git; +Cc: Stefan Sundin via GitGitGadget
On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote:
> > From: Stefan Sundin <git@stefansundin.com>
> >
> > Compiling git on macOS 13 emits the following deprecation warning:
> >
> > CC compat/fsmonitor/fsm-listen-darwin.o
> > compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
> > FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode);
> > ^
> > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
> > FSEventStreamScheduleWithRunLoop(
> > ^
> > 1 warning generated.
> >
> > Setting a minimum macOS version will suppress this deprecation warning.
> > Using a version lower than 10.13 will cause other warning messages to
> > be emitted.
> >
>
> Why don't instead follow the suggestion on the warning message
> (FSEventStreamSetDispatchQueue) instead?
>
> --
> An old man doll... just what I always wanted! - Clara
You are right, Bagas. I assumed, without actually looking it up, that
the new function had a higher-than-acceptable minimum macOS version
requirement. It turns out that the new function was added in 10.6
which is far better than requiring 10.13.
Please disregard this patch and I will attempt to update the code to
use the new function instead.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: suppress macOS deprecation warning
2022-11-20 2:14 ` Stefan Sundin
@ 2022-11-20 12:29 ` Bagas Sanjaya
2022-12-01 18:53 ` Jeff Hostetler
0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2022-11-20 12:29 UTC (permalink / raw)
To: Stefan Sundin, git; +Cc: Stefan Sundin via GitGitGadget
On 11/20/22 09:14, Stefan Sundin wrote:
> You are right, Bagas. I assumed, without actually looking it up, that
> the new function had a higher-than-acceptable minimum macOS version
> requirement. It turns out that the new function was added in 10.6
> which is far better than requiring 10.13.
>
> Please disregard this patch and I will attempt to update the code to
> use the new function instead.
OK. But unfortunately, I don't have any macOS machines handy, so I can't
test your future patch.
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: suppress macOS deprecation warning
2022-11-20 12:29 ` Bagas Sanjaya
@ 2022-12-01 18:53 ` Jeff Hostetler
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Hostetler @ 2022-12-01 18:53 UTC (permalink / raw)
To: Bagas Sanjaya, Stefan Sundin, git; +Cc: Stefan Sundin via GitGitGadget
On 11/20/22 7:29 AM, Bagas Sanjaya wrote:
> On 11/20/22 09:14, Stefan Sundin wrote:
>> You are right, Bagas. I assumed, without actually looking it up, that
>> the new function had a higher-than-acceptable minimum macOS version
>> requirement. It turns out that the new function was added in 10.6
>> which is far better than requiring 10.13.
>>
>> Please disregard this patch and I will attempt to update the code to
>> use the new function instead.
>
> OK. But unfortunately, I don't have any macOS machines handy, so I can't
> test your future patch.
>
> Thanks.
>
As I mentioned in another thread, I'm working on a solution
for this deprecated function. As soon the CI builds finish
I'll submit it.
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-01 18:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-19 20:06 [PATCH] Makefile: suppress macOS deprecation warning Stefan Sundin via GitGitGadget
2022-11-20 1:48 ` Bagas Sanjaya
2022-11-20 2:14 ` Stefan Sundin
2022-11-20 12:29 ` Bagas Sanjaya
2022-12-01 18:53 ` Jeff Hostetler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.