From: Alexei Starovoitov <ast@plumgrid.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Arnaldo Carvalho de Melo <acme@infradead.org>, Jiri Olsa <jolsa@redhat.com>, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>, Linux API <linux-api@vger.kernel.org>, Network Development <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 linux-trace 1/8] tracing: attach eBPF programs to tracepoints and syscalls Date: Mon, 9 Feb 2015 22:10:45 -0800 [thread overview] Message-ID: <CAMEtUuztTca2jC9Su0YkTHEUHsD4p2PBRyukabrjGO0WfFzdfA@mail.gmail.com> (raw) On Mon, Feb 9, 2015 at 9:13 PM, Steven Rostedt <rostedt@goodmis.org> wrote: >> \ >> + if (prog) { \ >> + __maybe_unused const u64 z = 0; \ >> + struct bpf_context __ctx = ((struct bpf_context) { \ >> + __BPF_CAST6(args, z, z, z, z, z) \ > > Note, there is no guarantee that args is at most 6. For example, in > drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.h, the > trace_event brcms_txstatus has 8 args. > > But I guess that's OK if you do not need those last args, right? yeah, some tracepoints pass a lot of things. That's rare and in most of the cases they can be fetched from parent structure. > I'm nervous about showing args of tracepoints too, because we don't want > that to become a strict ABI either. One can argue that current TP_printk format is already an ABI, because somebody might be parsing the text output. so in some cases we cannot change tracepoints without somebody complaining that his tool broke. In other cases tracepoints are used for debugging only and no one will notice when they change... It was and still a grey area. bpf doesn't change any of that. It actually makes addition of new tracepoints easier. In the future we might add a tracepoint and pass a single pointer to interesting data struct to it. bpf programs will walk data structures 'as safe modules' via bpf_fetch*() methods without exposing it as ABI. whereas today we pass a lot of fields to tracepoints and make all of these fields immutable. To me tracepoints are like gdb breakpoints. and bpf programs like live debugger that examine things. the next step is to be able to write bpf scripts on the fly without leaving debugger. Something like perf probe + editor + live execution. Truly like gdb for kernel. while kernel is running.
WARNING: multiple messages have this Message-ID (diff)
From: Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org> To: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Namhyung Kim <namhyung-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Arnaldo Carvalho de Melo <acme-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Masami Hiramatsu <masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>, Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Network Development <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v3 linux-trace 1/8] tracing: attach eBPF programs to tracepoints and syscalls Date: Mon, 9 Feb 2015 22:10:45 -0800 [thread overview] Message-ID: <CAMEtUuztTca2jC9Su0YkTHEUHsD4p2PBRyukabrjGO0WfFzdfA@mail.gmail.com> (raw) On Mon, Feb 9, 2015 at 9:13 PM, Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote: >> \ >> + if (prog) { \ >> + __maybe_unused const u64 z = 0; \ >> + struct bpf_context __ctx = ((struct bpf_context) { \ >> + __BPF_CAST6(args, z, z, z, z, z) \ > > Note, there is no guarantee that args is at most 6. For example, in > drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.h, the > trace_event brcms_txstatus has 8 args. > > But I guess that's OK if you do not need those last args, right? yeah, some tracepoints pass a lot of things. That's rare and in most of the cases they can be fetched from parent structure. > I'm nervous about showing args of tracepoints too, because we don't want > that to become a strict ABI either. One can argue that current TP_printk format is already an ABI, because somebody might be parsing the text output. so in some cases we cannot change tracepoints without somebody complaining that his tool broke. In other cases tracepoints are used for debugging only and no one will notice when they change... It was and still a grey area. bpf doesn't change any of that. It actually makes addition of new tracepoints easier. In the future we might add a tracepoint and pass a single pointer to interesting data struct to it. bpf programs will walk data structures 'as safe modules' via bpf_fetch*() methods without exposing it as ABI. whereas today we pass a lot of fields to tracepoints and make all of these fields immutable. To me tracepoints are like gdb breakpoints. and bpf programs like live debugger that examine things. the next step is to be able to write bpf scripts on the fly without leaving debugger. Something like perf probe + editor + live execution. Truly like gdb for kernel. while kernel is running.
next reply other threads:[~2015-02-10 6:11 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-02-10 6:10 Alexei Starovoitov [this message] 2015-02-10 6:10 ` [PATCH v3 linux-trace 1/8] tracing: attach eBPF programs to tracepoints and syscalls Alexei Starovoitov 2015-02-10 13:05 ` Steven Rostedt 2015-02-10 13:05 ` Steven Rostedt -- strict thread matches above, loose matches on Subject: below -- 2015-02-23 18:55 Alexei Starovoitov 2015-02-23 18:55 ` Alexei Starovoitov 2015-02-14 23:02 Alexei Starovoitov 2015-02-14 23:02 ` Alexei Starovoitov 2015-02-14 22:54 Alexei Starovoitov 2015-02-14 22:54 ` Alexei Starovoitov 2015-02-14 22:48 Alexei Starovoitov 2015-02-14 22:48 ` Alexei Starovoitov 2015-02-11 6:33 Alexei Starovoitov 2015-02-11 6:33 ` Alexei Starovoitov 2015-02-11 12:51 ` Steven Rostedt 2015-02-11 12:51 ` Steven Rostedt 2015-02-11 3:04 Alexei Starovoitov 2015-02-11 4:31 ` Steven Rostedt 2015-02-11 4:31 ` Steven Rostedt 2015-02-11 0:22 Alexei Starovoitov 2015-02-11 0:50 ` Steven Rostedt 2015-02-11 0:50 ` Steven Rostedt 2015-02-11 9:33 ` Peter Zijlstra 2015-02-11 9:45 ` Peter Zijlstra 2015-02-11 9:45 ` Peter Zijlstra 2015-02-11 10:15 ` Peter Zijlstra 2015-02-11 10:15 ` Peter Zijlstra 2015-02-12 4:58 ` Hekuang 2015-02-12 4:58 ` Hekuang 2015-02-12 4:58 ` Hekuang 2015-02-16 11:26 ` He Kuang 2015-02-16 11:26 ` He Kuang 2015-02-10 19:53 Alexei Starovoitov 2015-02-10 21:53 ` Steven Rostedt 2015-02-10 21:53 ` Steven Rostedt 2015-02-11 10:28 ` Peter Zijlstra 2015-02-11 10:28 ` Peter Zijlstra 2015-02-10 5:51 Alexei Starovoitov 2015-02-10 5:51 ` Alexei Starovoitov 2015-02-10 12:27 ` Steven Rostedt 2015-02-10 3:45 [PATCH v3 linux-trace 0/8] tracing: attach eBPF programs to tracepoints/syscalls/kprobe Alexei Starovoitov 2015-02-10 3:45 ` [PATCH v3 linux-trace 1/8] tracing: attach eBPF programs to tracepoints and syscalls Alexei Starovoitov 2015-02-10 3:45 ` Alexei Starovoitov 2015-02-10 4:46 ` Steven Rostedt 2015-02-10 4:46 ` Steven Rostedt 2015-02-10 5:13 ` Steven Rostedt 2015-02-10 5:13 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMEtUuztTca2jC9Su0YkTHEUHsD4p2PBRyukabrjGO0WfFzdfA@mail.gmail.com \ --to=ast@plumgrid.com \ --cc=acme@infradead.org \ --cc=jolsa@redhat.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=masami.hiramatsu.pt@hitachi.com \ --cc=mingo@kernel.org \ --cc=namhyung@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.