All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinpu Wang <jinpu.wang@profitbricks.com>
To: wharms@bfs.de
Cc: Colin King <colin.king@canonical.com>,
	lindar_liu <lindar_liu@usish.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	pmchba@pmcs.com, linux-scsi@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX
Date: Thu, 23 Mar 2017 09:17:46 +0000	[thread overview]
Message-ID: <CAMGffEm6cvJ121K9ME6Tgk_uYSRJQgMq=bvKyYzKuQZP=sNwow@mail.gmail.com> (raw)
In-Reply-To: <58D3889B.7030400@bfs.de>

On Thu, Mar 23, 2017 at 9:34 AM, walter harms <wharms@bfs.de> wrote:

>> @@ -4613,15 +4616,15 @@ static int pm8001_chip_phy_ctl_req(struct pm8001_hba_info *pm8001_ha,
>>
>>  static u32 pm8001_chip_is_our_interupt(struct pm8001_hba_info *pm8001_ha)
>>  {
>> -     u32 value;
>>  #ifdef PM8001_USE_MSIX
>>       return 1;
>> -#endif
>> -     value = pm8001_cr32(pm8001_ha, 0, MSGU_ODR);
>> +#else
>> +     u32 value = pm8001_cr32(pm8001_ha, 0, MSGU_ODR);
>> +
>>       if (value)
>>               return 1;
>>       return 0;
>> -
>> +#endif
>>  }
>>
>
> This is a bit strange, why do this function return u32 ?
>
> re,
>  wh
>
>>  /**

Hi Walter,

Feel free to submit a patch to change it to bool.

Thanks

-- 
Jinpu Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:       +49 30 577 008  042
Fax:      +49 30 577 008 299
Email:    jinpu.wang@profitbricks.com
URL:      https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss

WARNING: multiple messages have this Message-ID (diff)
From: Jinpu Wang <jinpu.wang@profitbricks.com>
To: wharms@bfs.de
Cc: Colin King <colin.king@canonical.com>,
	lindar_liu <lindar_liu@usish.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	pmchba@pmcs.com, linux-scsi@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX
Date: Thu, 23 Mar 2017 10:17:46 +0100	[thread overview]
Message-ID: <CAMGffEm6cvJ121K9ME6Tgk_uYSRJQgMq=bvKyYzKuQZP=sNwow@mail.gmail.com> (raw)
In-Reply-To: <58D3889B.7030400@bfs.de>

On Thu, Mar 23, 2017 at 9:34 AM, walter harms <wharms@bfs.de> wrote:

>> @@ -4613,15 +4616,15 @@ static int pm8001_chip_phy_ctl_req(struct pm8001_hba_info *pm8001_ha,
>>
>>  static u32 pm8001_chip_is_our_interupt(struct pm8001_hba_info *pm8001_ha)
>>  {
>> -     u32 value;
>>  #ifdef PM8001_USE_MSIX
>>       return 1;
>> -#endif
>> -     value = pm8001_cr32(pm8001_ha, 0, MSGU_ODR);
>> +#else
>> +     u32 value = pm8001_cr32(pm8001_ha, 0, MSGU_ODR);
>> +
>>       if (value)
>>               return 1;
>>       return 0;
>> -
>> +#endif
>>  }
>>
>
> This is a bit strange, why do this function return u32 ?
>
> re,
>  wh
>
>>  /**

Hi Walter,

Feel free to submit a patch to change it to bool.

Thanks

-- 
Jinpu Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:       +49 30 577 008  042
Fax:      +49 30 577 008 299
Email:    jinpu.wang@profitbricks.com
URL:      https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss

  reply	other threads:[~2017-03-23  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 18:50 [PATCH] scsi: pm8001: build in relevant functions and code on PM8001_USE_MSIX Colin King
2017-03-23  8:34 ` walter harms
2017-03-23  8:34   ` walter harms
2017-03-23  9:17   ` Jinpu Wang [this message]
2017-03-23  9:17     ` Jinpu Wang
2017-03-23  9:16 ` Jinpu Wang
2017-03-23  9:16   ` Jinpu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMGffEm6cvJ121K9ME6Tgk_uYSRJQgMq=bvKyYzKuQZP=sNwow@mail.gmail.com' \
    --to=jinpu.wang@profitbricks.com \
    --cc=colin.king@canonical.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lindar_liu@usish.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pmchba@pmcs.com \
    --cc=wharms@bfs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.