All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Oliveira <cmroliv@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, Larry.Finger@lwfinger.net,
	linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
Date: Mon, 1 Sep 2014 13:55:52 +0200	[thread overview]
Message-ID: <CAMGgR5vActZ6Cnv4LCvj1YQSmP26qCc4rps7iPkNhuTvQoVTrg@mail.gmail.com> (raw)
In-Reply-To: <20140901095446.GF5122@mwanda>

>> > Same comments as the previous ones, please redo all of these patches.
>> >
>> Should all the alterations be in one big single patch, insted of small ones?
>
> Your first version broke the build if we applied only the first patch.
> That's not allowed.
I now understand that, thank you.

> Also the new rtw_sys_remove_one() function isn't called.  I was confused
> by it as well.  It doesn't "remove one", it removes everything.
The function it's not new, I just converted it from the proc to
defugfs, It can be renamed.

> Do we need to support llseek?
Probably not... I'll check it.

> How have you tested this?  Have you tested module unloading?
Yes, I've tested it several times and unloaded without issues.

Thank you for your comments,
Best Regards,
Miguel Oliveira

  reply	other threads:[~2014-09-01 11:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 10:32 [PATCH 1/4] staging: rtl8188eu: os_intfs.c Miguel Oliveira
2014-08-22 10:33 ` [PATCH 2/4] staging: rtl8188eu: rtw_debug.c Miguel Oliveira
2014-08-30 20:40   ` Greg KH
2014-08-22 10:33 ` [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c Miguel Oliveira
2014-08-30 20:41   ` Greg KH
2014-08-30 21:22     ` Miguel Oliveira
2014-08-30 22:05       ` Greg KH
2014-09-01  9:54       ` Dan Carpenter
2014-09-01 11:55         ` Miguel Oliveira [this message]
2014-08-22 10:33 ` [PATCH 4/4] staging: rtl8188eu: rtw_debug.h Miguel Oliveira
2014-08-30 20:41   ` Greg KH
2014-08-30 21:24     ` Miguel Oliveira
2014-08-30 20:40 ` [PATCH 1/4] staging: rtl8188eu: os_intfs.c Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMGgR5vActZ6Cnv4LCvj1YQSmP26qCc4rps7iPkNhuTvQoVTrg@mail.gmail.com \
    --to=cmroliv@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.