All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Oliveira <cmroliv@gmail.com>
Cc: devel@driverdev.osuosl.org, Larry.Finger@lwfinger.net,
	linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c
Date: Sat, 30 Aug 2014 15:05:58 -0700	[thread overview]
Message-ID: <20140830220558.GB15000@kroah.com> (raw)
In-Reply-To: <CAMGgR5tmQE2nWJwBkc5jv_TF=xM+XRf6exGUOA6A-X+7iXqbFg@mail.gmail.com>

On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote:
> > Same comments as the previous ones, please redo all of these patches.
> >
> Should all the alterations be in one big single patch, insted of small ones?

I don't know, I don't remember what this patch even contained given that
it was 100+ patches ago in my review queue and I have the short term
memory of a squirrel.  Please fix up and resend and I'll be glad to
review it then.

thanks,

greg k-h

  reply	other threads:[~2014-08-30 22:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 10:32 [PATCH 1/4] staging: rtl8188eu: os_intfs.c Miguel Oliveira
2014-08-22 10:33 ` [PATCH 2/4] staging: rtl8188eu: rtw_debug.c Miguel Oliveira
2014-08-30 20:40   ` Greg KH
2014-08-22 10:33 ` [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c Miguel Oliveira
2014-08-30 20:41   ` Greg KH
2014-08-30 21:22     ` Miguel Oliveira
2014-08-30 22:05       ` Greg KH [this message]
2014-09-01  9:54       ` Dan Carpenter
2014-09-01 11:55         ` Miguel Oliveira
2014-08-22 10:33 ` [PATCH 4/4] staging: rtl8188eu: rtw_debug.h Miguel Oliveira
2014-08-30 20:41   ` Greg KH
2014-08-30 21:24     ` Miguel Oliveira
2014-08-30 20:40 ` [PATCH 1/4] staging: rtl8188eu: os_intfs.c Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140830220558.GB15000@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=cmroliv@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.