[PATCH 1/2] systemtap: Test latest and greatest for 5.2 kernel

[PATCH 1/2] systemtap: Test latest and greatest for 5.2 kernel

[Richard Purdie]

Systemtap has issues with the 5.2 kernel which are fixed in master, we helped
debug and submitted some of the patches. Update to a git version which includes
all the fixes.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-kernel/systemtap/systemtap_git.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
index c5348b3204b..f16f851e610 100644
--- a/meta/recipes-kernel/systemtap/systemtap_git.inc
+++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
@@ -1,7 +1,7 @@
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
-SRCREV = "984d6d1696ed06626b07cb65ab55d6ae0ece1131"
-PV = "4.1"
+SRCREV = "a25199c9580b9b66424c494d3bf39c4d1b7e1f7b"
+PV = "4.1+git${SRCPV}"
 
 SRC_URI = "git://sourceware.org/git/systemtap.git \
            file://configure-allow-to-disable-libvirt.patch \
-- 
2.20.1

[PATCH 2/2] gcc-cross: Fix header file corruption problems

[Richard Purdie]

gcc's makefile can move files, replacing with the contents "timestamp". This
corrupts the headers and breaks things like the gcc testsuite.

Add in a fix to ensure the headers are not corrupted through their hardlink copies.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index e417b898734..95af6d89a9d 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] = "${BUILDDIRSTASH}"
 do_gcc_stash_builddir () {
 	dest=${BUILDDIRSTASH}
 	hardlinkdir . $dest
+	# Makefile does move-if-change which can end up with 'timestamp' as file contents so break links to those files
+	rm $dest/gcc/include/*.h
+	cp gcc/include/*.h $dest/gcc/include/
 }
 addtask do_gcc_stash_builddir after do_compile before do_install
 SSTATETASKS += "do_gcc_stash_builddir"
-- 
2.20.1

Re: [PATCH 2/2] gcc-cross: Fix header file corruption problems

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

On Fri, Sep 6, 2019 at 12:24 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> gcc's makefile can move files, replacing with the contents "timestamp".
> This
> corrupts the headers and breaks things like the gcc testsuite.
>
> Add in a fix to ensure the headers are not corrupted through their
> hardlink copies.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc
> b/meta/recipes-devtools/gcc/gcc-cross.inc
> index e417b898734..95af6d89a9d 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> @@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] = "${BUILDDIRSTASH}"
>  do_gcc_stash_builddir () {
>         dest=${BUILDDIRSTASH}
>         hardlinkdir . $dest
> +       # Makefile does move-if-change which can end up with 'timestamp'
> as file contents so break links to those files
> +       rm $dest/gcc/include/*.h
> +       cp gcc/include/*.h $dest/gcc/include/
>  }


I think we moved them outside gcc dir isn’t it

>
>  addtask do_gcc_stash_builddir after do_compile before do_install
>  SSTATETASKS += "do_gcc_stash_builddir"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2379 bytes --]

Re: [PATCH 2/2] gcc-cross: Fix header file corruption problems

[richard.purdie]

On Fri, 2019-09-06 at 07:15 -0700, Khem Raj wrote:
> 
> 
> On Fri, Sep 6, 2019 at 12:24 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > gcc's makefile can move files, replacing with the contents
> > "timestamp". This
> > corrupts the headers and breaks things like the gcc testsuite.
> > 
> > Add in a fix to ensure the headers are not corrupted through their
> > hardlink copies.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc
> > b/meta/recipes-devtools/gcc/gcc-cross.inc
> > index e417b898734..95af6d89a9d 100644
> > --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> > @@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] =
> > "${BUILDDIRSTASH}"
> >  do_gcc_stash_builddir () {
> >         dest=${BUILDDIRSTASH}
> >         hardlinkdir . $dest
> > +       # Makefile does move-if-change which can end up with
> > 'timestamp' as file contents so break links to those files
> > +       rm $dest/gcc/include/*.h
> > +       cp gcc/include/*.h $dest/gcc/include/
> >  }
> 
> I think we moved them outside gcc dir isn’t it 

Not sure I follow? I think the patch is correct?

Cheers,

Richard

Re: [PATCH 2/2] gcc-cross: Fix header file corruption problems

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Fri, Sep 6, 2019 at 7:23 AM <richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2019-09-06 at 07:15 -0700, Khem Raj wrote:
> >
> >
> > On Fri, Sep 6, 2019 at 12:24 AM Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> > > gcc's makefile can move files, replacing with the contents
> > > "timestamp". This
> > > corrupts the headers and breaks things like the gcc testsuite.
> > >
> > > Add in a fix to ensure the headers are not corrupted through their
> > > hardlink copies.
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > ---
> > >  meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc
> > > b/meta/recipes-devtools/gcc/gcc-cross.inc
> > > index e417b898734..95af6d89a9d 100644
> > > --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> > > +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> > > @@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] =
> > > "${BUILDDIRSTASH}"
> > >  do_gcc_stash_builddir () {
> > >         dest=${BUILDDIRSTASH}
> > >         hardlinkdir . $dest
> > > +       # Makefile does move-if-change which can end up with
> > > 'timestamp' as file contents so break links to those files
> > > +       rm $dest/gcc/include/*.h
> > > +       cp gcc/include/*.h $dest/gcc/include/
> > >  }
> >
> > I think we moved them outside gcc dir isn’t it
>
> Not sure I follow? I think the patch is correct?
>

Yeah I think patch is fine since I was wondering about files from
gcc-runtime which got move

>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 2566 bytes --]

✗ patchtest: failure for "systemtap: Test latest and gre..." and 1 more

[Patchwork]

== Series Details ==

Series: "systemtap: Test latest and gre..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/19745/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 7e75ed5aec)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH 1/2] systemtap: Test latest and greatest for 5.2 kernel

[Bruce Ashfield]

On Fri, Sep 6, 2019 at 3:24 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> Systemtap has issues with the 5.2 kernel which are fixed in master, we helped
> debug and submitted some of the patches. Update to a git version which includes
> all the fixes.

And I can confirm that I can now run the stap test on all the arches with 5.2.

I'll send the rest of my 5.2 queue in a few hours (the removal of 5.0,
and setting 5.2 as default where needed). I just want to run a few
more tests before sending.

Cheers,

Bruce

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-kernel/systemtap/systemtap_git.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
> index c5348b3204b..f16f851e610 100644
> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> @@ -1,7 +1,7 @@
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> -SRCREV = "984d6d1696ed06626b07cb65ab55d6ae0ece1131"
> -PV = "4.1"
> +SRCREV = "a25199c9580b9b66424c494d3bf39c4d1b7e1f7b"
> +PV = "4.1+git${SRCPV}"
>
>  SRC_URI = "git://sourceware.org/git/systemtap.git \
>             file://configure-allow-to-disable-libvirt.patch \
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [PATCH 1/2] systemtap: Test latest and greatest for 5.2 kernel

[richard.purdie]

On Fri, 2019-09-06 at 08:24 -0400, Bruce Ashfield wrote:
> On Fri, Sep 6, 2019 at 3:24 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Systemtap has issues with the 5.2 kernel which are fixed in master,
> > we helped
> > debug and submitted some of the patches. Update to a git version
> > which includes
> > all the fixes.
> 
> And I can confirm that I can now run the stap test on all the arches
> with 5.2.

Cool. I also got a few more systemtap patches accepted upstream so we
can clean up the patches there a bit.

> 
> I'll send the rest of my 5.2 queue in a few hours (the removal of
> 5.0,
> and setting 5.2 as default where needed). I just want to run a few
> more tests before sending.

I actually merged my patch to poky which changed the default FWIW since
it made it though the autobuilder...

Cheers,

Richard

Re: [PATCH 1/2] systemtap: Test latest and greatest for 5.2 kernel

[Bruce Ashfield]

On Fri, Sep 6, 2019 at 8:43 AM <richard.purdie@linuxfoundation.org> wrote:
>
> On Fri, 2019-09-06 at 08:24 -0400, Bruce Ashfield wrote:
> > On Fri, Sep 6, 2019 at 3:24 AM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > Systemtap has issues with the 5.2 kernel which are fixed in master,
> > > we helped
> > > debug and submitted some of the patches. Update to a git version
> > > which includes
> > > all the fixes.
> >
> > And I can confirm that I can now run the stap test on all the arches
> > with 5.2.
>
> Cool. I also got a few more systemtap patches accepted upstream so we
> can clean up the patches there a bit.

We will soon declare you a systemtap expert ;)

>
> >
> > I'll send the rest of my 5.2 queue in a few hours (the removal of
> > 5.0,
> > and setting 5.2 as default where needed). I just want to run a few
> > more tests before sending.
>
> I actually merged my patch to poky which changed the default FWIW since
> it made it though the autobuilder...

No worries. I'll make sure to check master and master-next before
sending anything! That really just leaves me with the 5.0 removal, so
I'll double check for lingering references to it and send the patch
along.

Bruce

>
> Cheers,
>
> Richard
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II