[PATCH] gcc-cross-canadian: Do not create symlink to real-ld

[PATCH] gcc-cross-canadian: Do not create symlink to real-ld

[Samuli Piippo]

real-ld is always used if that is found, which means you cannot
switch between bfd and gold linkers using -fuse-ld=gold.

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
 meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
index e7c08d3a61..ececec4965 100644
--- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
@@ -137,8 +137,6 @@ do_install () {
 
 		ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
 	done
-	t=real-ld
-	ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
 
 	# libquadmath headers need to  be available in the gcc libexec dir
 	install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
-- 
2.17.1

Re: [PATCH] gcc-cross-canadian: Do not create symlink to real-ld

[Khem Raj]

On Mon, Jan 28, 2019 at 11:19 PM Samuli Piippo <samuli.piippo@qt.io> wrote:
>
> real-ld is always used if that is found, which means you cannot
> switch between bfd and gold linkers using -fuse-ld=gold.
>
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> ---
>  meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> index e7c08d3a61..ececec4965 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> @@ -137,8 +137,6 @@ do_install () {
>
>                 ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
>         done
> -       t=real-ld
> -       ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
>

this patch is essentially, reverting
https://git.openembedded.org/openembedded-core/commit/?id=cdd86896c8d29135f937968e9aa07f919cf543d3

so lets do a revert instead to keep the context clear

secondly, please test with the mips/mips64 as those were primary drivers for
the patch in first place.  Richard might add more context if he remembers.


>         # libquadmath headers need to  be available in the gcc libexec dir
>         install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[PATCH v2] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Samuli Piippo]

This reverts commit cdd86896c8d29135f937968e9aa07f919cf543d3.

real-ld is always used if that is found, which means you cannot
switch between bfd and gold linkers using -fuse-ld=gold.

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
 meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
index e7c08d3a61..ececec4965 100644
--- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
@@ -137,8 +137,6 @@ do_install () {
 
 		ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
 	done
-	t=real-ld
-	ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
 
 	# libquadmath headers need to  be available in the gcc libexec dir
 	install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
-- 
2.17.1

Re: [PATCH] gcc-cross-canadian: Do not create symlink to real-ld

[Samuli Piippo]

Sent v2 as a revert patch.

Simple compilation test with mips64 toolchain works fine, as does arm64/armv7.
Richard, would you happen to remember more details where this failed
in the first place?

-samuli

On Tue, 29 Jan 2019 at 20:20, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Jan 28, 2019 at 11:19 PM Samuli Piippo <samuli.piippo@qt.io> wrote:
> >
> > real-ld is always used if that is found, which means you cannot
> > switch between bfd and gold linkers using -fuse-ld=gold.
> >
> > Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> > ---
> >  meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > index e7c08d3a61..ececec4965 100644
> > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > @@ -137,8 +137,6 @@ do_install () {
> >
> >                 ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
> >         done
> > -       t=real-ld
> > -       ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
> >
>
> this patch is essentially, reverting
> https://git.openembedded.org/openembedded-core/commit/?id=cdd86896c8d29135f937968e9aa07f919cf543d3
>
> so lets do a revert instead to keep the context clear
>
> secondly, please test with the mips/mips64 as those were primary drivers for
> the patch in first place.  Richard might add more context if he remembers.
>
>
> >         # libquadmath headers need to  be available in the gcc libexec dir
> >         install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core