All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] Recipe for docopt.cpp option parsing library
@ 2019-08-23 10:54 Aaltonen Eero
  2019-08-24 17:34 ` Khem Raj
  2019-08-26 18:04 ` Adrian Bunk
  0 siblings, 2 replies; 6+ messages in thread
From: Aaltonen Eero @ 2019-08-23 10:54 UTC (permalink / raw)
  To: openembedded-devel

Upstream is at
https://github.com/docopt/docopt.cpp/

Installs with a small build modification to pass QA checks.

Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com>
---
 file                                          |  0
 ...01-Set-library-VERSION-and-SOVERSION.patch | 31 +++++++++++++++++++
 .../docopt.cpp/docopt.cpp_git.bb              | 29 +++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 file
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb

diff --git a/file b/file
new file mode 100644
index 000000000..e69de29bb
diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
new file mode 100644
index 000000000..d4c776569
--- /dev/null
+++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
@@ -0,0 +1,31 @@
+From a47ca75702318ff43446c70120f7aacde4ccee1b Mon Sep 17 00:00:00 2001
+From: Eero Aaltonen <eero.aaltonen@vaisala.com>
+Date: Thu, 20 Jun 2019 16:21:20 +0300
+Subject: [PATCH] Set library VERSION and SOVERSION
+
+With soversion and version specified, `install` target will install the
+library with the specified version and also create the proper symlink.
+
+Upstream-Status: Submitted [https://github.com/docopt/docopt.cpp/pull/112]
+but unlikely to be merged soon as it is a duplicate of
+[https://github.com/docopt/docopt.cpp/pull/112] which has been **Open**
+since 2016-12-08.
+---
+ CMakeLists.txt | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 23da468..feff32e 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -50,6 +50,10 @@ else()
+     set_target_properties(docopt_o PROPERTIES POSITION_INDEPENDENT_CODE TRUE)
+ 
+     add_library(docopt SHARED $<TARGET_OBJECTS:docopt_o>)
++	set_target_properties(docopt PROPERTIES
++		VERSION ${PROJECT_VERSION}
++		SOVERSION ${PROJECT_VERSION_MAJOR}
++		)
+     add_library(docopt_s STATIC $<TARGET_OBJECTS:docopt_o>)
+ endif()
+ 
diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
new file mode 100644
index 000000000..95c60617c
--- /dev/null
+++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
@@ -0,0 +1,29 @@
+SUMMARY = "C++11 port of docopt command-line interface description language and parser"
+
+DESCRIPTION = "docopt is library that lets you define a command line interface with the \
+utility argument syntax that has been used by command line utilities for \
+decades (formalized in POSIX.1-2017). From the description, docopt \
+automatically generates a parser for the command line arguments."
+
+HOMEPAGE = "https://github.com/docopt/docopt.cpp"
+
+LICENSE = "MIT | BSL-1.0"
+LIC_FILES_CHKSUM = "\
+    file://LICENSE-Boost-1.0;md5=e4224ccaecb14d942c71d31bef20d78c \
+    file://LICENSE-MIT;md5=4b242fd9ef20207e18286d73da8a6677 \
+"
+
+DEPENDS = "boost"
+SRCREV = "3dd23e3280f213bacefdf5fcb04857bf52e90917"
+PV = "0.6.2+git${SRCPV}"
+
+SRC_URI = "\
+    git://git@github.com/docopt/docopt.cpp.git;protocol=ssh \
+    file://0001-Set-library-VERSION-and-SOVERSION.patch \
+"
+
+S = "${WORKDIR}/git"
+
+inherit cmake gitpkgv
+
+PKGV = "0.6.2+git${GITPKGV}"
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH] Recipe for docopt.cpp option parsing library
  2019-08-23 10:54 [meta-oe][PATCH] Recipe for docopt.cpp option parsing library Aaltonen Eero
@ 2019-08-24 17:34 ` Khem Raj
  2019-08-26 18:04 ` Adrian Bunk
  1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2019-08-24 17:34 UTC (permalink / raw)
  To: Aaltonen Eero; +Cc: openembedded-devel

On Fri, Aug 23, 2019 at 3:55 AM Aaltonen Eero <eero.aaltonen@vaisala.com> wrote:
>
> Upstream is at
> https://github.com/docopt/docopt.cpp/
>
> Installs with a small build modification to pass QA checks.
>
> Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com>
> ---
>  file                                          |  0
>  ...01-Set-library-VERSION-and-SOVERSION.patch | 31 +++++++++++++++++++
>  .../docopt.cpp/docopt.cpp_git.bb              | 29 +++++++++++++++++
>  3 files changed, 60 insertions(+)
>  create mode 100644 file
>  create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
>  create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
>
> diff --git a/file b/file
> new file mode 100644
> index 000000000..e69de29bb
> diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
> new file mode 100644
> index 000000000..d4c776569
> --- /dev/null
> +++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
> @@ -0,0 +1,31 @@
> +From a47ca75702318ff43446c70120f7aacde4ccee1b Mon Sep 17 00:00:00 2001
> +From: Eero Aaltonen <eero.aaltonen@vaisala.com>
> +Date: Thu, 20 Jun 2019 16:21:20 +0300
> +Subject: [PATCH] Set library VERSION and SOVERSION
> +
> +With soversion and version specified, `install` target will install the
> +library with the specified version and also create the proper symlink.
> +
> +Upstream-Status: Submitted [https://github.com/docopt/docopt.cpp/pull/112]
> +but unlikely to be merged soon as it is a duplicate of
> +[https://github.com/docopt/docopt.cpp/pull/112] which has been **Open**
> +since 2016-12-08.
> +---
> + CMakeLists.txt | 4 ++++
> + 1 file changed, 4 insertions(+)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index 23da468..feff32e 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -50,6 +50,10 @@ else()
> +     set_target_properties(docopt_o PROPERTIES POSITION_INDEPENDENT_CODE TRUE)
> +
> +     add_library(docopt SHARED $<TARGET_OBJECTS:docopt_o>)
> ++      set_target_properties(docopt PROPERTIES
> ++              VERSION ${PROJECT_VERSION}
> ++              SOVERSION ${PROJECT_VERSION_MAJOR}
> ++              )
> +     add_library(docopt_s STATIC $<TARGET_OBJECTS:docopt_o>)
> + endif()
> +
> diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
> new file mode 100644
> index 000000000..95c60617c
> --- /dev/null
> +++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
> @@ -0,0 +1,29 @@
> +SUMMARY = "C++11 port of docopt command-line interface description language and parser"
> +
> +DESCRIPTION = "docopt is library that lets you define a command line interface with the \
> +utility argument syntax that has been used by command line utilities for \
> +decades (formalized in POSIX.1-2017). From the description, docopt \
> +automatically generates a parser for the command line arguments."
> +
> +HOMEPAGE = "https://github.com/docopt/docopt.cpp"
> +
> +LICENSE = "MIT | BSL-1.0"
> +LIC_FILES_CHKSUM = "\
> +    file://LICENSE-Boost-1.0;md5=e4224ccaecb14d942c71d31bef20d78c \
> +    file://LICENSE-MIT;md5=4b242fd9ef20207e18286d73da8a6677 \
> +"
> +
> +DEPENDS = "boost"
> +SRCREV = "3dd23e3280f213bacefdf5fcb04857bf52e90917"
> +PV = "0.6.2+git${SRCPV}"
> +
> +SRC_URI = "\
> +    git://git@github.com/docopt/docopt.cpp.git;protocol=ssh \
> +    file://0001-Set-library-VERSION-and-SOVERSION.patch \
> +"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit cmake gitpkgv

lets just use SRCPV

> +
> +PKGV = "0.6.2+git${GITPKGV}"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH] Recipe for docopt.cpp option parsing library
  2019-08-23 10:54 [meta-oe][PATCH] Recipe for docopt.cpp option parsing library Aaltonen Eero
  2019-08-24 17:34 ` Khem Raj
@ 2019-08-26 18:04 ` Adrian Bunk
  2019-08-28 10:34   ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
  1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2019-08-26 18:04 UTC (permalink / raw)
  To: Aaltonen Eero; +Cc: openembedded-devel

On Fri, Aug 23, 2019 at 10:54:46AM +0000, Aaltonen Eero wrote:
>...
> +SRC_URI = "\
> +    git://git@github.com/docopt/docopt.cpp.git;protocol=ssh \
>...

  The authenticity of host 'github.com (140.82.118.3)' can't be established.
  RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
  Are you sure you want to continue connecting (yes/no)?

Please use a protocol=https URI, similar to other github URIs.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH v2 0/1] Recipe for docopt.cpp option parsing library
  2019-08-26 18:04 ` Adrian Bunk
@ 2019-08-28 10:34   ` Aaltonen Eero
  2019-08-28 10:34     ` [meta-oe][PATCH v2 1/1] " Aaltonen Eero
  2019-09-03  6:50     ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
  0 siblings, 2 replies; 6+ messages in thread
From: Aaltonen Eero @ 2019-08-28 10:34 UTC (permalink / raw)
  To: openembedded-devel

Thank you for the feedback. Here is the revised patch.

Changes:
* SRC_URI prototocol is "https"
* Removed use of gitpkgv

An open question. I earlier wondered whether the resulting packages should be
named "docopt.cpp" or "libdocopt.cpp". I did a quick search and it seems on
Ubuntu the packagers are naming the resulting binary packages with the
"lib" prefix
https://ubuntu.pkgs.org/18.04/ubuntu-universe-amd64/libdocopt-dev_0.6.2-2_amd64.deb.html

Eero Aaltonen (1):
  Recipe for docopt.cpp option parsing library

 file                                          |  0
 ...01-Set-library-VERSION-and-SOVERSION.patch | 31 +++++++++++++++++++
 .../docopt.cpp/docopt.cpp_git.bb              | 27 ++++++++++++++++
 3 files changed, 58 insertions(+)
 create mode 100644 file
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb

-- 
2.17.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH v2 1/1] Recipe for docopt.cpp option parsing library
  2019-08-28 10:34   ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
@ 2019-08-28 10:34     ` Aaltonen Eero
  2019-09-03  6:50     ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
  1 sibling, 0 replies; 6+ messages in thread
From: Aaltonen Eero @ 2019-08-28 10:34 UTC (permalink / raw)
  To: openembedded-devel

Upstream is at
https://github.com/docopt/docopt.cpp/

Installs with a small build modification to pass QA checks.

Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com>
---
 file                                          |  0
 ...01-Set-library-VERSION-and-SOVERSION.patch | 31 +++++++++++++++++++
 .../docopt.cpp/docopt.cpp_git.bb              | 27 ++++++++++++++++
 3 files changed, 58 insertions(+)
 create mode 100644 file
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
 create mode 100644 meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb

diff --git a/file b/file
new file mode 100644
index 000000000..e69de29bb
diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
new file mode 100644
index 000000000..d4c776569
--- /dev/null
+++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp/0001-Set-library-VERSION-and-SOVERSION.patch
@@ -0,0 +1,31 @@
+From a47ca75702318ff43446c70120f7aacde4ccee1b Mon Sep 17 00:00:00 2001
+From: Eero Aaltonen <eero.aaltonen@vaisala.com>
+Date: Thu, 20 Jun 2019 16:21:20 +0300
+Subject: [PATCH] Set library VERSION and SOVERSION
+
+With soversion and version specified, `install` target will install the
+library with the specified version and also create the proper symlink.
+
+Upstream-Status: Submitted [https://github.com/docopt/docopt.cpp/pull/112]
+but unlikely to be merged soon as it is a duplicate of
+[https://github.com/docopt/docopt.cpp/pull/112] which has been **Open**
+since 2016-12-08.
+---
+ CMakeLists.txt | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 23da468..feff32e 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -50,6 +50,10 @@ else()
+     set_target_properties(docopt_o PROPERTIES POSITION_INDEPENDENT_CODE TRUE)
+ 
+     add_library(docopt SHARED $<TARGET_OBJECTS:docopt_o>)
++	set_target_properties(docopt PROPERTIES
++		VERSION ${PROJECT_VERSION}
++		SOVERSION ${PROJECT_VERSION_MAJOR}
++		)
+     add_library(docopt_s STATIC $<TARGET_OBJECTS:docopt_o>)
+ endif()
+ 
diff --git a/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
new file mode 100644
index 000000000..aa55ebf84
--- /dev/null
+++ b/meta-oe/recipes-extended/docopt.cpp/docopt.cpp_git.bb
@@ -0,0 +1,27 @@
+SUMMARY = "C++11 port of docopt command-line interface description language and parser"
+
+DESCRIPTION = "docopt is library that lets you define a command line interface with the \
+utility argument syntax that has been used by command line utilities for \
+decades (formalized in POSIX.1-2017). From the description, docopt \
+automatically generates a parser for the command line arguments."
+
+HOMEPAGE = "https://github.com/docopt/docopt.cpp"
+
+LICENSE = "MIT | BSL-1.0"
+LIC_FILES_CHKSUM = "\
+    file://LICENSE-Boost-1.0;md5=e4224ccaecb14d942c71d31bef20d78c \
+    file://LICENSE-MIT;md5=4b242fd9ef20207e18286d73da8a6677 \
+"
+
+DEPENDS = "boost"
+SRCREV = "3dd23e3280f213bacefdf5fcb04857bf52e90917"
+PV = "0.6.2+git${SRCPV}"
+
+SRC_URI = "\
+    git://github.com/docopt/docopt.cpp.git;protocol=https \
+    file://0001-Set-library-VERSION-and-SOVERSION.patch \
+"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH v2 0/1] Recipe for docopt.cpp option parsing library
  2019-08-28 10:34   ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
  2019-08-28 10:34     ` [meta-oe][PATCH v2 1/1] " Aaltonen Eero
@ 2019-09-03  6:50     ` Aaltonen Eero
  1 sibling, 0 replies; 6+ messages in thread
From: Aaltonen Eero @ 2019-09-03  6:50 UTC (permalink / raw)
  To: openembedded-devel

On Wed, 2019-08-28 at 10:34 +0000, Aaltonen Eero wrote:
> Thank you for the feedback. Here is the revised patch.
> 
> Changes:
> * SRC_URI prototocol is "https"
> * Removed use of gitpkgv
> 
> An open question. I earlier wondered whether the resulting packages
> should be
> named "docopt.cpp" or "libdocopt.cpp". I did a quick search and it
> seems on
> Ubuntu the packagers are naming the resulting binary packages with
> the
> "lib" prefix
> 
https://ubuntu.pkgs.org/18.04/ubuntu-universe-amd64/libdocopt-dev_0.6.2-2_amd64.deb.html


Bump. Any more comments on this?
And which name would be more appropriate in OE?

-Eero Aaltonen


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-03  6:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 10:54 [meta-oe][PATCH] Recipe for docopt.cpp option parsing library Aaltonen Eero
2019-08-24 17:34 ` Khem Raj
2019-08-26 18:04 ` Adrian Bunk
2019-08-28 10:34   ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero
2019-08-28 10:34     ` [meta-oe][PATCH v2 1/1] " Aaltonen Eero
2019-09-03  6:50     ` [meta-oe][PATCH v2 0/1] " Aaltonen Eero

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.