From: "Khem Raj" <raj.khem@gmail.com>
To: Anastasios Kavoukis <anastasios.kavoukis@arm.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>,
nd <nd@arm.com>
Subject: Re: [oe] [PATCH] [meta-oe] pm-qa: fix paths for shell scripts
Date: Wed, 28 Jul 2021 10:24:21 -0700 [thread overview]
Message-ID: <CAMKF1soxQEtozKDYLuQ_vgneSAhKXZHMctu39X2v=DmP8mmZeA@mail.gmail.com> (raw)
In-Reply-To: <20210728093300.7665-1-anastasios.kavoukis@arm.com>
Thanks Anastasios for contribution sadly it fails to parse
ERROR: /mnt/b/yoe/master/sources/meta-openembedded/meta-oe/recipes-test/pm-qa/pm-qa_git.bb:
Error during parse shell code, the last 5 lines are:
| ETA: --:--:--
script_basename=`basename ${script}`
install -m 0755 $script
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/pm-qa/0.5.2-r0/image/usr/bin/${script_basename}
done
On Wed, Jul 28, 2021 at 2:33 AM Anastasios Kavoukis
<anastasios.kavoukis@arm.com> wrote:
>
> A commit in the repo of pm-qa:
>
> "adf9df9 Fix path to library files and change shebang line"
>
> Changed the text that sed was using to replace relative to
> absolute paths.
>
> As a result sed was not effectively finding the text
> "source ../include" to replace it, as the sed should be now
> searching for ". ../include".
>
> Similarly for "../Switches"
>
> Signed-off-by: Anastasios Kavoukis <anastasios.kavoukis@arm.com>
> ---
> meta-oe/recipes-test/pm-qa/pm-qa_git.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> index 7e9971ea4..9a60caa6d 100644
> --- a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> +++ b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> @@ -42,6 +42,7 @@ do_install () {
> do
> # Remove hardcoded relative paths
> sed -i -e 's#..\/utils\/##' ${script}
> + sed -i -e 's#. ..\/Switches#${bindir}#g" ${script}
>
> script_basename=`basename ${script}`
> install -m 0755 $script ${D}${libdir}/${BPN}/${script_basename}
> @@ -54,7 +55,7 @@ do_install () {
> # if the script includes any helper scripts from the $libdir
> # directory then change the source path to the absolute path
> # to reflect the install location of the helper scripts.
> - sed -i -e "s#source ../include#source ${libdir}/${BPN}#g" ${script}
> + sed -i -e "s#. ../include#. ${libdir}/${BPN}#g" ${script}
> # Remove hardcoded relative paths
> sed -i -e 's#..\/utils\/##' ${script}
>
> --
> 2.17.1
>
>
>
>
prev parent reply other threads:[~2021-07-28 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 9:33 [PATCH] [meta-oe] pm-qa: fix paths for shell scripts Anastasios Kavoukis
2021-07-28 17:24 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1soxQEtozKDYLuQ_vgneSAhKXZHMctu39X2v=DmP8mmZeA@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=anastasios.kavoukis@arm.com \
--cc=nd@arm.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.