All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [meta-oe] pm-qa: fix paths for shell scripts
@ 2021-07-28  9:33 Anastasios Kavoukis
  2021-07-28 17:24 ` [oe] " Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Anastasios Kavoukis @ 2021-07-28  9:33 UTC (permalink / raw)
  To: openembedded-devel; +Cc: nd, Anastasios Kavoukis

A commit in the repo of pm-qa:

"adf9df9 Fix path to library files and change shebang line"

Changed the text that sed was using to replace relative to
absolute paths.

As a result sed was not effectively finding the text
"source ../include" to replace it, as the sed should be now
searching for ". ../include".

Similarly for "../Switches"

Signed-off-by: Anastasios Kavoukis <anastasios.kavoukis@arm.com>
---
 meta-oe/recipes-test/pm-qa/pm-qa_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
index 7e9971ea4..9a60caa6d 100644
--- a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
+++ b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
@@ -42,6 +42,7 @@ do_install () {
     do
         # Remove hardcoded relative paths
         sed -i -e 's#..\/utils\/##' ${script}
+        sed -i -e 's#. ..\/Switches#${bindir}#g' ${script}
 
         script_basename=`basename ${script}`
         install -m 0755 $script ${D}${libdir}/${BPN}/${script_basename}
@@ -54,7 +55,7 @@ do_install () {
         # if the script includes any helper scripts from the $libdir
         # directory then change the source path to the absolute path
         # to reflect the install location of the helper scripts.
-        sed -i -e "s#source ../include#source ${libdir}/${BPN}#g" ${script}
+        sed -i -e "s#. ../include#. ${libdir}/${BPN}#g" ${script}
         # Remove hardcoded relative paths
         sed -i -e 's#..\/utils\/##' ${script}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [oe] [PATCH] [meta-oe] pm-qa: fix paths for shell scripts
  2021-07-28  9:33 [PATCH] [meta-oe] pm-qa: fix paths for shell scripts Anastasios Kavoukis
@ 2021-07-28 17:24 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2021-07-28 17:24 UTC (permalink / raw)
  To: Anastasios Kavoukis; +Cc: openembeded-devel, nd

Thanks Anastasios for contribution sadly it fails to parse

ERROR: /mnt/b/yoe/master/sources/meta-openembedded/meta-oe/recipes-test/pm-qa/pm-qa_git.bb:
Error during parse shell code, the last 5 lines are:
                             | ETA:  --:--:--

        script_basename=`basename ${script}`
        install -m 0755 $script
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/pm-qa/0.5.2-r0/image/usr/bin/${script_basename}
    done

On Wed, Jul 28, 2021 at 2:33 AM Anastasios Kavoukis
<anastasios.kavoukis@arm.com> wrote:
>
> A commit in the repo of pm-qa:
>
> "adf9df9 Fix path to library files and change shebang line"
>
> Changed the text that sed was using to replace relative to
> absolute paths.
>
> As a result sed was not effectively finding the text
> "source ../include" to replace it, as the sed should be now
> searching for ". ../include".
>
> Similarly for "../Switches"
>
> Signed-off-by: Anastasios Kavoukis <anastasios.kavoukis@arm.com>
> ---
>  meta-oe/recipes-test/pm-qa/pm-qa_git.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> index 7e9971ea4..9a60caa6d 100644
> --- a/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> +++ b/meta-oe/recipes-test/pm-qa/pm-qa_git.bb
> @@ -42,6 +42,7 @@ do_install () {
>      do
>          # Remove hardcoded relative paths
>          sed -i -e 's#..\/utils\/##' ${script}
> +        sed -i -e 's#. ..\/Switches#${bindir}#g" ${script}
>
>          script_basename=`basename ${script}`
>          install -m 0755 $script ${D}${libdir}/${BPN}/${script_basename}
> @@ -54,7 +55,7 @@ do_install () {
>          # if the script includes any helper scripts from the $libdir
>          # directory then change the source path to the absolute path
>          # to reflect the install location of the helper scripts.
> -        sed -i -e "s#source ../include#source ${libdir}/${BPN}#g" ${script}
> +        sed -i -e "s#. ../include#. ${libdir}/${BPN}#g" ${script}
>          # Remove hardcoded relative paths
>          sed -i -e 's#..\/utils\/##' ${script}
>
> --
> 2.17.1
>
>
> 
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-28 17:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28  9:33 [PATCH] [meta-oe] pm-qa: fix paths for shell scripts Anastasios Kavoukis
2021-07-28 17:24 ` [oe] " Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.