[PATCH v2 0/2] Add recipe of xfce4-datetime-setter

[PATCH v2 0/2] Add recipe of xfce4-datetime-setter

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

v2:
* make xfce4-datetime-setter rdepends on systemd

Kai Kang (2):
  xfce4-datetime-setter: add recipe
  xfce4-settings: rrecommends xfce4-datetime-setter

 .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
 .../xfce4-settings/xfce4-settings_4.13.7.bb    |  1 +
 2 files changed, 19 insertions(+)
 create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb

-- 
2.20.0

[PATCH v2 1/2] xfce4-datetime-setter: add recipe

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

Because xfce4-settings turn back to its official upstream, it missing
function to set date and time. Add it from Andreas's repo on github.
It depends on dbus service org.freedesktop.timedate1 which is provided
by systemd, so add systemd to RDEPENDS.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb

diff --git a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
new file mode 100644
index 000000000..7a28b6101
--- /dev/null
+++ b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"
-- 
2.20.0

[PATCH v2 2/2] xfce4-settings: rrecommends xfce4-datetime-setter

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

xfce4-datetime-setter provides function to set date and time. But it
depends on dbus service org.freedesktop.timedate1 which is provided by
systemd. Make xfce4-settings rrecommends xfce4-datetime-setter only
systemd is set in DISTRO_FEATURES.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb
index e79b0ab0b..2d16a02ce 100644
--- a/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb
+++ b/meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb
@@ -30,3 +30,4 @@ FILES_${PN} += " \
 RRECOMMENDS_${PN} += "adwaita-icon-theme"
 RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','alsa','libcanberra-alsa','',d)}"
 RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','pulseaudio','libcanberra-pulse','',d)}"
+RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','systemd','xfce4-datetime-setter','',d)}"
-- 
2.20.0

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

[Khem Raj]

On Thu, Aug 8, 2019 at 2:33 AM <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> Because xfce4-settings turn back to its official upstream, it missing
> function to set date and time. Add it from Andreas's repo on github.
> It depends on dbus service org.freedesktop.timedate1 which is provided
> by systemd, so add systemd to RDEPENDS.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>
> diff --git a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> new file mode 100644
> index 000000000..7a28b6101
> --- /dev/null
> +++ b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
> +It is based upon GTK3 and embedds into recent xfce4-settings."
> +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
> +
> +DEPENDS = "glib-2.0-native libxfce4ui"
> +
> +SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
> +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit gettext meson
> +
> +FILES_${PN} += "${datadir}/icons/hicolor"
> +
> +RDEPENDS_${PN} = "systemd tzdata"

On systemd-less systems it wont work

ERROR: Nothing RPROVIDES 'systemd' (but
/mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
RDEPENDS on or otherwise requires it)
systemd was skipped: missing required distro feature 'systemd' (not in
DISTRO_FEATURES)

> --
> 2.20.0
>

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

[Kang Kai]

On 2019/8/9 上午5:52, Khem Raj wrote:
> On Thu, Aug 8, 2019 at 2:33 AM <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> Because xfce4-settings turn back to its official upstream, it missing
>> function to set date and time. Add it from Andreas's repo on github.
>> It depends on dbus service org.freedesktop.timedate1 which is provided
>> by systemd, so add systemd to RDEPENDS.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>   create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>>
>> diff --git a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>> new file mode 100644
>> index 000000000..7a28b6101
>> --- /dev/null
>> +++ b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>> @@ -0,0 +1,18 @@
>> +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
>> +It is based upon GTK3 and embedds into recent xfce4-settings."
>> +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
>> +
>> +DEPENDS = "glib-2.0-native libxfce4ui"
>> +
>> +SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
>> +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit gettext meson
>> +
>> +FILES_${PN} += "${datadir}/icons/hicolor"
>> +
>> +RDEPENDS_${PN} = "systemd tzdata"
> On systemd-less systems it wont work
>
> ERROR: Nothing RPROVIDES 'systemd' (but
> /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> RDEPENDS on or otherwise requires it)
> systemd was skipped: missing required distro feature 'systemd' (not in
> DISTRO_FEATURES)

It uses functions from dbus service org.freedesktop.timedate1 to set 
time and date. Without this dbus service, xfce4-datetime-setter doesn't 
work.
And this dbus service is provides by systemd. The alternative is to 
require distro feature 'systemd'. But I think RRDEPENDS should be more 
proper.

Regards,
Kai


>> --
>> 2.20.0
>>

-- 
Kai Kang

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

[Khem Raj]

On Thu, Aug 8, 2019 at 6:43 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>
> On 2019/8/9 上午5:52, Khem Raj wrote:
> > On Thu, Aug 8, 2019 at 2:33 AM <kai.kang@windriver.com> wrote:
> >> From: Kai Kang <kai.kang@windriver.com>
> >>
> >> Because xfce4-settings turn back to its official upstream, it missing
> >> function to set date and time. Add it from Andreas's repo on github.
> >> It depends on dbus service org.freedesktop.timedate1 which is provided
> >> by systemd, so add systemd to RDEPENDS.
> >>
> >> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> >> ---
> >>   .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
> >>   1 file changed, 18 insertions(+)
> >>   create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> >>
> >> diff --git a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> >> new file mode 100644
> >> index 000000000..7a28b6101
> >> --- /dev/null
> >> +++ b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> >> @@ -0,0 +1,18 @@
> >> +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
> >> +It is based upon GTK3 and embedds into recent xfce4-settings."
> >> +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
> >> +LICENSE = "GPLv2"
> >> +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
> >> +
> >> +DEPENDS = "glib-2.0-native libxfce4ui"
> >> +
> >> +SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
> >> +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +inherit gettext meson
> >> +
> >> +FILES_${PN} += "${datadir}/icons/hicolor"
> >> +
> >> +RDEPENDS_${PN} = "systemd tzdata"
> > On systemd-less systems it wont work
> >
> > ERROR: Nothing RPROVIDES 'systemd' (but
> > /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
> > RDEPENDS on or otherwise requires it)
> > systemd was skipped: missing required distro feature 'systemd' (not in
> > DISTRO_FEATURES)
>
> It uses functions from dbus service org.freedesktop.timedate1 to set
> time and date. Without this dbus service, xfce4-datetime-setter doesn't
> work.
> And this dbus service is provides by systemd. The alternative is to
> require distro feature 'systemd'. But I think RRDEPENDS should be more
> proper.

In such cases, it means the package is systemd specific and since we
can only have one init system for a distro this package
should be guarded with that distro feature as well. rdepends does not
know distro nuances.

>
> Regards,
> Kai
>
>
> >> --
> >> 2.20.0
> >>
>
> --
> Kai Kang
>

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

[Kang Kai]

On 2019/8/9 上午10:04, Khem Raj wrote:
> On Thu, Aug 8, 2019 at 6:43 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>> On 2019/8/9 上午5:52, Khem Raj wrote:
>>> On Thu, Aug 8, 2019 at 2:33 AM <kai.kang@windriver.com> wrote:
>>>> From: Kai Kang <kai.kang@windriver.com>
>>>>
>>>> Because xfce4-settings turn back to its official upstream, it missing
>>>> function to set date and time. Add it from Andreas's repo on github.
>>>> It depends on dbus service org.freedesktop.timedate1 which is provided
>>>> by systemd, so add systemd to RDEPENDS.
>>>>
>>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>>> ---
>>>>    .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
>>>>    1 file changed, 18 insertions(+)
>>>>    create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>>>>
>>>> diff --git a/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>>>> new file mode 100644
>>>> index 000000000..7a28b6101
>>>> --- /dev/null
>>>> +++ b/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>>>> @@ -0,0 +1,18 @@
>>>> +DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
>>>> +It is based upon GTK3 and embedds into recent xfce4-settings."
>>>> +HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
>>>> +LICENSE = "GPLv2"
>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
>>>> +
>>>> +DEPENDS = "glib-2.0-native libxfce4ui"
>>>> +
>>>> +SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
>>>> +SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +inherit gettext meson
>>>> +
>>>> +FILES_${PN} += "${datadir}/icons/hicolor"
>>>> +
>>>> +RDEPENDS_${PN} = "systemd tzdata"
>>> On systemd-less systems it wont work
>>>
>>> ERROR: Nothing RPROVIDES 'systemd' (but
>>> /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
>>> RDEPENDS on or otherwise requires it)
>>> systemd was skipped: missing required distro feature 'systemd' (not in
>>> DISTRO_FEATURES)
>> It uses functions from dbus service org.freedesktop.timedate1 to set
>> time and date. Without this dbus service, xfce4-datetime-setter doesn't
>> work.
>> And this dbus service is provides by systemd. The alternative is to
>> require distro feature 'systemd'. But I think RRDEPENDS should be more
>> proper.
> In such cases, it means the package is systemd specific and since we
> can only have one init system for a distro this package
> should be guarded with that distro feature as well. rdepends does not
> know distro nuances.

OK. v3 will sent with respecting distro feature systemd.

Kai


>
>> Regards,
>> Kai
>>
>>
>>>> --
>>>> 2.20.0
>>>>
>> --
>> Kai Kang
>>

-- 
Kai Kang