* [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
@ 2020-08-25 4:08 Arthur She
2020-08-25 18:34 ` [oe] " Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Arthur She @ 2020-08-25 4:08 UTC (permalink / raw)
To: openembedded-devel; +Cc: Arthur She
This error caused the curl library not to be linked.
Signed-off-by: Arthur She <arthur.she@linaro.org>
---
.../0003-Fix-Makefile-macro-error.patch | 26 +++++++++++++++++++
.../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
2 files changed, 27 insertions(+)
create mode 100644 meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
new file mode 100644
index 000000000..e0be24bf7
--- /dev/null
+++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
@@ -0,0 +1,26 @@
+From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00 2001
+From: Arthur She <arthur.she@linaro.org>
+Date: Mon, 24 Aug 2020 20:50:58 -0700
+Subject: [PATCH] Fix Makefile macro error
+
+The libcurl will not be liked due to this error.
+---
+ src/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile b/src/Makefile
+index 1cdf8b0..acd04dd 100644
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
+ TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
+ TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
+ TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
+- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
+ TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
+ endif
+ ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
+--
+2.25.1
+
diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
index c1f0b78ca..eec945824 100644
--- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
+++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
@@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
file://0002-fix-formatting-issues.patch \
+ file://0003-Fix-Makefile-macro-error.patch \
"
#Release 1.54.02
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
2020-08-25 4:08 [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error Arthur She
@ 2020-08-25 18:34 ` Khem Raj
2020-08-26 4:57 ` Arthur She
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-08-25 18:34 UTC (permalink / raw)
To: Arthur She; +Cc: openembeded-devel
On Mon, Aug 24, 2020 at 9:08 PM Arthur She <arthur.she@linaro.org> wrote:
>
> This error caused the curl library not to be linked.
>
> Signed-off-by: Arthur She <arthur.she@linaro.org>
> ---
> .../0003-Fix-Makefile-macro-error.patch | 26 +++++++++++++++++++
> .../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
> 2 files changed, 27 insertions(+)
> create mode 100644 meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>
> diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> new file mode 100644
> index 000000000..e0be24bf7
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> @@ -0,0 +1,26 @@
> +From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00 2001
> +From: Arthur She <arthur.she@linaro.org>
> +Date: Mon, 24 Aug 2020 20:50:58 -0700
> +Subject: [PATCH] Fix Makefile macro error
> +
> +The libcurl will not be liked due to this error.
> +---
> + src/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/Makefile b/src/Makefile
> +index 1cdf8b0..acd04dd 100644
> +--- a/src/Makefile
> ++++ b/src/Makefile
> +@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
> + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
> + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
> + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
> +- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
> ++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
do we then point CURL_CONFIG to PKGCONFIG or pkgconfig ?
I think it would be better to do so as well while here.
> + TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
> + endif
> + ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
> +--
> +2.25.1
> +
> diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> index c1f0b78ca..eec945824 100644
> --- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> @@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
> SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
> file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
> file://0002-fix-formatting-issues.patch \
> + file://0003-Fix-Makefile-macro-error.patch \
> "
>
> #Release 1.54.02
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
2020-08-25 18:34 ` [oe] " Khem Raj
@ 2020-08-26 4:57 ` Arthur She
2020-08-26 5:26 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Arthur She @ 2020-08-26 4:57 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 2967 bytes --]
Hi Khem,
I am not sure I understand what you mean.
Could you share some more details?
Thanks,
Arthur
On Tue, Aug 25, 2020 at 11:34 AM Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Aug 24, 2020 at 9:08 PM Arthur She <arthur.she@linaro.org> wrote:
> >
> > This error caused the curl library not to be linked.
> >
> > Signed-off-by: Arthur She <arthur.she@linaro.org>
> > ---
> > .../0003-Fix-Makefile-macro-error.patch | 26 +++++++++++++++++++
> > .../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
> > 2 files changed, 27 insertions(+)
> > create mode 100644
> meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> >
> > diff --git
> a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> > new file mode 100644
> > index 000000000..e0be24bf7
> > --- /dev/null
> > +++
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> > @@ -0,0 +1,26 @@
> > +From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00 2001
> > +From: Arthur She <arthur.she@linaro.org>
> > +Date: Mon, 24 Aug 2020 20:50:58 -0700
> > +Subject: [PATCH] Fix Makefile macro error
> > +
> > +The libcurl will not be liked due to this error.
> > +---
> > + src/Makefile | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/src/Makefile b/src/Makefile
> > +index 1cdf8b0..acd04dd 100644
> > +--- a/src/Makefile
> > ++++ b/src/Makefile
> > +@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
> > +- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
> > ++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
>
> do we then point CURL_CONFIG to PKGCONFIG or pkgconfig ?
> I think it would be better to do so as well while here.
>
> > + TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
> > + endif
> > + ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
> > +--
> > +2.25.1
> > +
> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> > index c1f0b78ca..eec945824 100644
> > --- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> > @@ -8,6 +8,7 @@ LIC_FILES_CHKSUM =
> "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
> > SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
> >
> file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
> > file://0002-fix-formatting-issues.patch \
> > + file://0003-Fix-Makefile-macro-error.patch \
> > "
> >
> > #Release 1.54.02
> > --
> > 2.25.1
> >
> >
>
[-- Attachment #2: Type: text/html, Size: 4306 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
2020-08-26 4:57 ` Arthur She
@ 2020-08-26 5:26 ` Khem Raj
2020-08-26 20:28 ` Arthur She
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-08-26 5:26 UTC (permalink / raw)
To: Arthur She; +Cc: openembeded-devel
On Tue, Aug 25, 2020 at 9:58 PM Arthur She <arthur.she@linaro.org> wrote:
>
> Hi Khem,
> I am not sure I understand what you mean.
> Could you share some more details?
>
We have replaced many of these config files with pkgconfig calls,
since they do not work reliably in cross compile envs
but I don't see this being done for curl-config yet so perhaps it does
work ok in cross builds.
> Thanks,
> Arthur
>
> On Tue, Aug 25, 2020 at 11:34 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Mon, Aug 24, 2020 at 9:08 PM Arthur She <arthur.she@linaro.org> wrote:
>> >
>> > This error caused the curl library not to be linked.
>> >
>> > Signed-off-by: Arthur She <arthur.she@linaro.org>
>> > ---
>> > .../0003-Fix-Makefile-macro-error.patch | 26 +++++++++++++++++++
>> > .../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
>> > 2 files changed, 27 insertions(+)
>> > create mode 100644 meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> >
>> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> > new file mode 100644
>> > index 000000000..e0be24bf7
>> > --- /dev/null
>> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> > @@ -0,0 +1,26 @@
>> > +From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00 2001
>> > +From: Arthur She <arthur.she@linaro.org>
>> > +Date: Mon, 24 Aug 2020 20:50:58 -0700
>> > +Subject: [PATCH] Fix Makefile macro error
>> > +
>> > +The libcurl will not be liked due to this error.
>> > +---
>> > + src/Makefile | 2 +-
>> > + 1 file changed, 1 insertion(+), 1 deletion(-)
>> > +
>> > +diff --git a/src/Makefile b/src/Makefile
>> > +index 1cdf8b0..acd04dd 100644
>> > +--- a/src/Makefile
>> > ++++ b/src/Makefile
>> > +@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
>> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
>> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
>> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
>> > +- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
>> > ++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
>>
>> do we then point CURL_CONFIG to PKGCONFIG or pkgconfig ?
>> I think it would be better to do so as well while here.
>>
>> > + TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
>> > + endif
>> > + ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
>> > +--
>> > +2.25.1
>> > +
>> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> > index c1f0b78ca..eec945824 100644
>> > --- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> > @@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
>> > SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
>> > file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
>> > file://0002-fix-formatting-issues.patch \
>> > + file://0003-Fix-Makefile-macro-error.patch \
>> > "
>> >
>> > #Release 1.54.02
>> > --
>> > 2.25.1
>> >
>> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
2020-08-26 5:26 ` Khem Raj
@ 2020-08-26 20:28 ` Arthur She
2020-08-26 22:11 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Arthur She @ 2020-08-26 20:28 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 3840 bytes --]
We built curl and xmlrpc-c for arm and aarch64 architectures.
Except for the Makefile macro error of xmlrpc-c-1.54.02, everything works
fine so far.
Could you give me an example of the config files with pkgconfig calls?
Thanks,
Arthur
On Tue, Aug 25, 2020 at 10:26 PM Khem Raj <raj.khem@gmail.com> wrote:
> On Tue, Aug 25, 2020 at 9:58 PM Arthur She <arthur.she@linaro.org> wrote:
> >
> > Hi Khem,
> > I am not sure I understand what you mean.
> > Could you share some more details?
> >
>
> We have replaced many of these config files with pkgconfig calls,
> since they do not work reliably in cross compile envs
> but I don't see this being done for curl-config yet so perhaps it does
> work ok in cross builds.
>
> > Thanks,
> > Arthur
> >
> > On Tue, Aug 25, 2020 at 11:34 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On Mon, Aug 24, 2020 at 9:08 PM Arthur She <arthur.she@linaro.org>
> wrote:
> >> >
> >> > This error caused the curl library not to be linked.
> >> >
> >> > Signed-off-by: Arthur She <arthur.she@linaro.org>
> >> > ---
> >> > .../0003-Fix-Makefile-macro-error.patch | 26
> +++++++++++++++++++
> >> > .../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
> >> > 2 files changed, 27 insertions(+)
> >> > create mode 100644
> meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> >> >
> >> > diff --git
> a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> >> > new file mode 100644
> >> > index 000000000..e0be24bf7
> >> > --- /dev/null
> >> > +++
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
> >> > @@ -0,0 +1,26 @@
> >> > +From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00
> 2001
> >> > +From: Arthur She <arthur.she@linaro.org>
> >> > +Date: Mon, 24 Aug 2020 20:50:58 -0700
> >> > +Subject: [PATCH] Fix Makefile macro error
> >> > +
> >> > +The libcurl will not be liked due to this error.
> >> > +---
> >> > + src/Makefile | 2 +-
> >> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> >> > +
> >> > +diff --git a/src/Makefile b/src/Makefile
> >> > +index 1cdf8b0..acd04dd 100644
> >> > +--- a/src/Makefile
> >> > ++++ b/src/Makefile
> >> > +@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
> >> > + TRANSPORT_MODS +=
> $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
> >> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
> >> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
> >> > +- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
> >> > ++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
> >>
> >> do we then point CURL_CONFIG to PKGCONFIG or pkgconfig ?
> >> I think it would be better to do so as well while here.
> >>
> >> > + TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
> >> > + endif
> >> > + ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
> >> > +--
> >> > +2.25.1
> >> > +
> >> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> >> > index c1f0b78ca..eec945824 100644
> >> > --- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> >> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
> >> > @@ -8,6 +8,7 @@ LIC_FILES_CHKSUM =
> "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
> >> > SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
> >> >
> file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
> >> > file://0002-fix-formatting-issues.patch \
> >> > + file://0003-Fix-Makefile-macro-error.patch \
> >> > "
> >> >
> >> > #Release 1.54.02
> >> > --
> >> > 2.25.1
> >> >
> >> >
>
[-- Attachment #2: Type: text/html, Size: 5766 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error
2020-08-26 20:28 ` Arthur She
@ 2020-08-26 22:11 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-08-26 22:11 UTC (permalink / raw)
To: Arthur She; +Cc: openembeded-devel
On Wed, Aug 26, 2020 at 1:28 PM Arthur She <arthur.she@linaro.org> wrote:
>
> We built curl and xmlrpc-c for arm and aarch64 architectures.
> Except for the Makefile macro error of xmlrpc-c-1.54.02, everything works fine so far.
>
> Could you give me an example of the config files with pkgconfig calls?
>
see meta/recipes-support/gnupg/gnupg/0002-use-pkgconfig-instead-of-npth-config.patch
> Thanks,
> Arthur
>
>
> On Tue, Aug 25, 2020 at 10:26 PM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Tue, Aug 25, 2020 at 9:58 PM Arthur She <arthur.she@linaro.org> wrote:
>> >
>> > Hi Khem,
>> > I am not sure I understand what you mean.
>> > Could you share some more details?
>> >
>>
>> We have replaced many of these config files with pkgconfig calls,
>> since they do not work reliably in cross compile envs
>> but I don't see this being done for curl-config yet so perhaps it does
>> work ok in cross builds.
>>
>> > Thanks,
>> > Arthur
>> >
>> > On Tue, Aug 25, 2020 at 11:34 AM Khem Raj <raj.khem@gmail.com> wrote:
>> >>
>> >> On Mon, Aug 24, 2020 at 9:08 PM Arthur She <arthur.she@linaro.org> wrote:
>> >> >
>> >> > This error caused the curl library not to be linked.
>> >> >
>> >> > Signed-off-by: Arthur She <arthur.she@linaro.org>
>> >> > ---
>> >> > .../0003-Fix-Makefile-macro-error.patch | 26 +++++++++++++++++++
>> >> > .../xmlrpc-c/xmlrpc-c_1.54.02.bb | 1 +
>> >> > 2 files changed, 27 insertions(+)
>> >> > create mode 100644 meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> >> >
>> >> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> >> > new file mode 100644
>> >> > index 000000000..e0be24bf7
>> >> > --- /dev/null
>> >> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c/0003-Fix-Makefile-macro-error.patch
>> >> > @@ -0,0 +1,26 @@
>> >> > +From bb4057f06dd4a0b7823c1952b14cee7882664f1b Mon Sep 17 00:00:00 2001
>> >> > +From: Arthur She <arthur.she@linaro.org>
>> >> > +Date: Mon, 24 Aug 2020 20:50:58 -0700
>> >> > +Subject: [PATCH] Fix Makefile macro error
>> >> > +
>> >> > +The libcurl will not be liked due to this error.
>> >> > +---
>> >> > + src/Makefile | 2 +-
>> >> > + 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> > +
>> >> > +diff --git a/src/Makefile b/src/Makefile
>> >> > +index 1cdf8b0..acd04dd 100644
>> >> > +--- a/src/Makefile
>> >> > ++++ b/src/Makefile
>> >> > +@@ -57,7 +57,7 @@ ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
>> >> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/xmlrpc_curl_transport
>> >> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curltransaction
>> >> > + TRANSPORT_MODS += $(BLDDIR)/lib/curl_transport/curlmulti
>> >> > +- TRANSPORT_LIBDEP += $(shell $CURL_CONFIG --libs)
>> >> > ++ TRANSPORT_LIBDEP += $(shell $(CURL_CONFIG) --libs)
>> >>
>> >> do we then point CURL_CONFIG to PKGCONFIG or pkgconfig ?
>> >> I think it would be better to do so as well while here.
>> >>
>> >> > + TRANSPORT_INCLUDES += -Isrcdir/lib/curl_transport
>> >> > + endif
>> >> > + ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
>> >> > +--
>> >> > +2.25.1
>> >> > +
>> >> > diff --git a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> >> > index c1f0b78ca..eec945824 100644
>> >> > --- a/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> >> > +++ b/meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.54.02.bb
>> >> > @@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=aefbf81ba0750f02176b6f86752ea951"
>> >> > SRC_URI = "git://github.com/mirror/xmlrpc-c.git \
>> >> > file://0001-test-cpp-server_abyss-Fix-build-with-clang-libc.patch \
>> >> > file://0002-fix-formatting-issues.patch \
>> >> > + file://0003-Fix-Makefile-macro-error.patch \
>> >> > "
>> >> >
>> >> > #Release 1.54.02
>> >> > --
>> >> > 2.25.1
>> >> >
>> >> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-26 22:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 4:08 [meta-oe][PATCH] xmlrpc-c: fix Makefile macro error Arthur She
2020-08-25 18:34 ` [oe] " Khem Raj
2020-08-26 4:57 ` Arthur She
2020-08-26 5:26 ` Khem Raj
2020-08-26 20:28 ` Arthur She
2020-08-26 22:11 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.