All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gtk+3: Fix build failure with gold linker
Date: Sun, 24 Feb 2019 16:50:00 -0800	[thread overview]
Message-ID: <CAMKF1spJMRRvxZh6=6+pMP5+0q9EGLKE-zfcqSYdgPgn2=p-EA@mail.gmail.com> (raw)
In-Reply-To: <CAJTo0Lb_aF90SE4Exc80P5SH31u1SErPSsvsWtkfYiPz6xHVpQ@mail.gmail.com>

On Sun, Feb 24, 2019 at 3:02 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> Have you sent this upstream?
>
No, I haven't

> Ross
>
> On Thu, 21 Feb 2019 at 22:19, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Explicitly link in libfribidi
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../gtk+/gtk+3/link_fribidi.patch             | 19 +++++++++++++++++++
> >  meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb       |  1 +
> >  2 files changed, 20 insertions(+)
> >  create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> >
> > diff --git a/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> > new file mode 100644
> > index 0000000000..e4bbd799f1
> > --- /dev/null
> > +++ b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> > @@ -0,0 +1,19 @@
> > +Link with libfribidi, this is to avoid under linking where these functions are
> > +used but the library is not linked in, and they are marked undefined by BFD linker
> > +but gold linker refuses to link
> > +
> > +| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
> > +
> > +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > +Upstream-Status: Pending
> > +
> > +--- a/gdk/Makefile.am
> > ++++ b/gdk/Makefile.am
> > +@@ -55,6 +55,7 @@ LDADD =                                      \
> > +       -version-info $(LT_VERSION_INFO)        \
> > +       -export-dynamic                         \
> > +       -rpath $(libdir)                        \
> > ++      -lfribidi                               \
> > +       $(no_undefined)
> > +
> > + #
> > diff --git a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > index 799cbd4707..92c9a3ebfb 100644
> > --- a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > +++ b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > @@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
> >             file://0001-Hardcoded-libtool.patch \
> >             file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
> >             file://0003-Add-disable-opengl-configure-option.patch \
> > +           file://link_fribidi.patch \
> >            "
> >  SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
> >  SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core


      reply	other threads:[~2019-02-25  0:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 22:18 [PATCH] gtk+3: Fix build failure with gold linker Khem Raj
2019-02-24 20:13 ` Martin Jansa
2019-02-24 23:02 ` Burton, Ross
2019-02-25  0:50   ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1spJMRRvxZh6=6+pMP5+0q9EGLKE-zfcqSYdgPgn2=p-EA@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.