* [PATCH] gtk+3: Fix build failure with gold linker
@ 2019-02-21 22:18 Khem Raj
2019-02-24 20:13 ` Martin Jansa
2019-02-24 23:02 ` Burton, Ross
0 siblings, 2 replies; 4+ messages in thread
From: Khem Raj @ 2019-02-21 22:18 UTC (permalink / raw)
To: openembedded-core
Explicitly link in libfribidi
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../gtk+/gtk+3/link_fribidi.patch | 19 +++++++++++++++++++
meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb | 1 +
2 files changed, 20 insertions(+)
create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
diff --git a/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
new file mode 100644
index 0000000000..e4bbd799f1
--- /dev/null
+++ b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
@@ -0,0 +1,19 @@
+Link with libfribidi, this is to avoid under linking where these functions are
+used but the library is not linked in, and they are marked undefined by BFD linker
+but gold linker refuses to link
+
+| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Upstream-Status: Pending
+
+--- a/gdk/Makefile.am
++++ b/gdk/Makefile.am
+@@ -55,6 +55,7 @@ LDADD = \
+ -version-info $(LT_VERSION_INFO) \
+ -export-dynamic \
+ -rpath $(libdir) \
++ -lfribidi \
+ $(no_undefined)
+
+ #
diff --git a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
index 799cbd4707..92c9a3ebfb 100644
--- a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
+++ b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
@@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
file://0001-Hardcoded-libtool.patch \
file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
file://0003-Add-disable-opengl-configure-option.patch \
+ file://link_fribidi.patch \
"
SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gtk+3: Fix build failure with gold linker
2019-02-21 22:18 [PATCH] gtk+3: Fix build failure with gold linker Khem Raj
@ 2019-02-24 20:13 ` Martin Jansa
2019-02-24 23:02 ` Burton, Ross
1 sibling, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2019-02-24 20:13 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
On Thu, Feb 21, 2019 at 02:18:34PM -0800, Khem Raj wrote:
> Explicitly link in libfribidi
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../gtk+/gtk+3/link_fribidi.patch | 19 +++++++++++++++++++
> meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb | 1 +
> 2 files changed, 20 insertions(+)
> create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
+1
Tested-by: Martin Jansa <Martin.Jansa@gmail.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gtk+3: Fix build failure with gold linker
2019-02-21 22:18 [PATCH] gtk+3: Fix build failure with gold linker Khem Raj
2019-02-24 20:13 ` Martin Jansa
@ 2019-02-24 23:02 ` Burton, Ross
2019-02-25 0:50 ` Khem Raj
1 sibling, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2019-02-24 23:02 UTC (permalink / raw)
To: Khem Raj; +Cc: OE-core
Have you sent this upstream?
Ross
On Thu, 21 Feb 2019 at 22:19, Khem Raj <raj.khem@gmail.com> wrote:
>
> Explicitly link in libfribidi
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../gtk+/gtk+3/link_fribidi.patch | 19 +++++++++++++++++++
> meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb | 1 +
> 2 files changed, 20 insertions(+)
> create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
>
> diff --git a/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> new file mode 100644
> index 0000000000..e4bbd799f1
> --- /dev/null
> +++ b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> @@ -0,0 +1,19 @@
> +Link with libfribidi, this is to avoid under linking where these functions are
> +used but the library is not linked in, and they are marked undefined by BFD linker
> +but gold linker refuses to link
> +
> +| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +Upstream-Status: Pending
> +
> +--- a/gdk/Makefile.am
> ++++ b/gdk/Makefile.am
> +@@ -55,6 +55,7 @@ LDADD = \
> + -version-info $(LT_VERSION_INFO) \
> + -export-dynamic \
> + -rpath $(libdir) \
> ++ -lfribidi \
> + $(no_undefined)
> +
> + #
> diff --git a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> index 799cbd4707..92c9a3ebfb 100644
> --- a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> +++ b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> @@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
> file://0001-Hardcoded-libtool.patch \
> file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
> file://0003-Add-disable-opengl-configure-option.patch \
> + file://link_fribidi.patch \
> "
> SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
> SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gtk+3: Fix build failure with gold linker
2019-02-24 23:02 ` Burton, Ross
@ 2019-02-25 0:50 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2019-02-25 0:50 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Sun, Feb 24, 2019 at 3:02 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> Have you sent this upstream?
>
No, I haven't
> Ross
>
> On Thu, 21 Feb 2019 at 22:19, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Explicitly link in libfribidi
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > .../gtk+/gtk+3/link_fribidi.patch | 19 +++++++++++++++++++
> > meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb | 1 +
> > 2 files changed, 20 insertions(+)
> > create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> >
> > diff --git a/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> > new file mode 100644
> > index 0000000000..e4bbd799f1
> > --- /dev/null
> > +++ b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
> > @@ -0,0 +1,19 @@
> > +Link with libfribidi, this is to avoid under linking where these functions are
> > +used but the library is not linked in, and they are marked undefined by BFD linker
> > +but gold linker refuses to link
> > +
> > +| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
> > +
> > +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > +Upstream-Status: Pending
> > +
> > +--- a/gdk/Makefile.am
> > ++++ b/gdk/Makefile.am
> > +@@ -55,6 +55,7 @@ LDADD = \
> > + -version-info $(LT_VERSION_INFO) \
> > + -export-dynamic \
> > + -rpath $(libdir) \
> > ++ -lfribidi \
> > + $(no_undefined)
> > +
> > + #
> > diff --git a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > index 799cbd4707..92c9a3ebfb 100644
> > --- a/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > +++ b/meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb
> > @@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
> > file://0001-Hardcoded-libtool.patch \
> > file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
> > file://0003-Add-disable-opengl-configure-option.patch \
> > + file://link_fribidi.patch \
> > "
> > SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
> > SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-25 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 22:18 [PATCH] gtk+3: Fix build failure with gold linker Khem Raj
2019-02-24 20:13 ` Martin Jansa
2019-02-24 23:02 ` Burton, Ross
2019-02-25 0:50 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.