[PATCH] zstd: do verbose builds

[PATCH] zstd: do verbose builds

[Ross Burton]

Set V=1 so that the compile log is useful when things go wrong.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-extended/zstd/zstd_1.5.2.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/zstd/zstd_1.5.2.bb b/meta/recipes-extended/zstd/zstd_1.5.2.bb
index 3887f31ecfa..2a638eb4269 100644
--- a/meta/recipes-extended/zstd/zstd_1.5.2.bb
+++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
@@ -26,6 +26,8 @@ PACKAGECONFIG[zlib] = "HAVE_ZLIB=1,HAVE_ZLIB=0,zlib"
 # See programs/README.md for how to use this
 ZSTD_LEGACY_SUPPORT ??= "4"
 
+EXTRA_OEMAKE += "V=1"
+
 do_compile () {
     oe_runmake ${PACKAGECONFIG_CONFARGS} ZSTD_LEGACY_SUPPORT=${ZSTD_LEGACY_SUPPORT}
     oe_runmake ${PACKAGECONFIG_CONFARGS} ZSTD_LEGACY_SUPPORT=${ZSTD_LEGACY_SUPPORT} -C contrib/pzstd
-- 
2.34.1

Re: [OE-core] [PATCH] zstd: do verbose builds

[Khem Raj]

On Fri, Jul 22, 2022 at 7:13 AM Ross Burton <ross.burton@arm.com> wrote:
>
> Set V=1 so that the compile log is useful when things go wrong.
>

verbose logs do add to build time, usually when build fails the error
parts are good with dumping error and
compiler cmdline, is that not the case here ?

> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-extended/zstd/zstd_1.5.2.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-extended/zstd/zstd_1.5.2.bb b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> index 3887f31ecfa..2a638eb4269 100644
> --- a/meta/recipes-extended/zstd/zstd_1.5.2.bb
> +++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> @@ -26,6 +26,8 @@ PACKAGECONFIG[zlib] = "HAVE_ZLIB=1,HAVE_ZLIB=0,zlib"
>  # See programs/README.md for how to use this
>  ZSTD_LEGACY_SUPPORT ??= "4"
>
> +EXTRA_OEMAKE += "V=1"
> +
>  do_compile () {
>      oe_runmake ${PACKAGECONFIG_CONFARGS} ZSTD_LEGACY_SUPPORT=${ZSTD_LEGACY_SUPPORT}
>      oe_runmake ${PACKAGECONFIG_CONFARGS} ZSTD_LEGACY_SUPPORT=${ZSTD_LEGACY_SUPPORT} -C contrib/pzstd
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168402): https://lists.openembedded.org/g/openembedded-core/message/168402
> Mute This Topic: https://lists.openembedded.org/mt/92545058/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [PATCH] zstd: do verbose builds

[Ross Burton]

> On 22 Jul 2022, at 15:54, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> 
> On Fri, Jul 22, 2022 at 7:13 AM Ross Burton <ross.burton@arm.com> wrote:
>> 
>> Set V=1 so that the compile log is useful when things go wrong.
>> 
> 
> verbose logs do add to build time, usually when build fails the error
> parts are good with dumping error and
> compiler cmdline, is that not the case here ?

It doesn’t dump the command that failed, just the errors.  There is no meaningful increase in build time.

Ross

Re: [OE-core] [PATCH] zstd: do verbose builds

[Khem Raj]

On Fri, Jul 22, 2022 at 12:17 PM Ross Burton <Ross.Burton@arm.com> wrote:
>
>
>
> > On 22 Jul 2022, at 15:54, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >
> > On Fri, Jul 22, 2022 at 7:13 AM Ross Burton <ross.burton@arm.com> wrote:
> >>
> >> Set V=1 so that the compile log is useful when things go wrong.
> >>
> >
> > verbose logs do add to build time, usually when build fails the error
> > parts are good with dumping error and
> > compiler cmdline, is that not the case here ?
>
> It doesn’t dump the command that failed, just the errors.  There is no meaningful increase in build time.
>

OK. Perhaps because its not a big component.

> Ross