[PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[Khem Raj]

From: pino-kim <sungwon.pino@gmail.com>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

Signed-off-by: pino-kim <sungwon.pino@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index 475e4f08ef..e54766bbb2 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
-           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
+           virtual/nativesdk-libc bison-native"
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
-- 
2.20.1

[PATCH 2/2] busybox: Enable mountpoint and setsid applets

[Khem Raj]

This is needed by some init system services and if
init system is not sysvinit then we dont have it, therefore
its useful to have it provided via busybox as a backup

Enable CONFIG_SETSID to get setsid, needed by runit

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/busybox/busybox/defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
index 0c4099031f..d11707abc3 100644
--- a/meta/recipes-core/busybox/busybox/defconfig
+++ b/meta/recipes-core/busybox/busybox/defconfig
@@ -815,13 +815,13 @@ CONFIG_DC=y
 # CONFIG_FEATURE_MAKEDEVS_TABLE is not set
 # CONFIG_MAN is not set
 CONFIG_MICROCOM=y
-# CONFIG_MOUNTPOINT is not set
+CONFIG_MOUNTPOINT=y
 # CONFIG_MT is not set
 # CONFIG_RAIDAUTORUN is not set
 # CONFIG_READAHEAD is not set
 # CONFIG_RUNLEVEL is not set
 # CONFIG_RX is not set
-# CONFIG_SETSID is not set
+CONFIG_SETSID=y
 # CONFIG_SETFATTR is not set
 CONFIG_STRINGS=y
 CONFIG_TIME=y
-- 
2.20.1

Re: [PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[Jacob Kroon]

On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> From: pino-kim <sungwon.pino@gmail.com>
>
> This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.
>
> Signed-off-by: pino-kim <sungwon.pino@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> index 475e4f08ef..e54766bbb2 100644
> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
>  BPN = "gdb"
>
>  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
> -           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
> +           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
> +           virtual/nativesdk-libc bison-native"
>

Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

>  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

✗ patchtest: failure for "gdb-cross-canadian: Add bison-..." and 1 more

[Patchwork]

== Series Details ==

Series: "gdb-cross-canadian: Add bison-..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/15503/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 65c419b8c4)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[Khem Raj]

On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>
> On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > From: pino-kim <sungwon.pino@gmail.com>
> >
> > This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.
> >
> > Signed-off-by: pino-kim <sungwon.pino@gmail.com>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > index 475e4f08ef..e54766bbb2 100644
> > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
> >  BPN = "gdb"
> >
> >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
> > -           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
> > +           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
> > +           virtual/nativesdk-libc bison-native"
> >
>
> Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

Its not particular to riscv, it just happens to unearth the problem
for us since its building gdb from upstream
master, we are going to land into this problem eventually when we upgrade.

>
> >  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
> >
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[Richard Purdie]

On Wed, 2019-01-02 at 11:42 -0800, Khem Raj wrote:
> On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com>
> wrote:
> > On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > From: pino-kim <sungwon.pino@gmail.com>
> > > 
> > > This fixes RISC-V gdb-cross-canadian cross compile configure
> > > failure on missing bison.
> > > 
> > > Signed-off-by: pino-kim <sungwon.pino@gmail.com>
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > index 475e4f08ef..e54766bbb2 100644
> > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-
> > > ${TRANSLATED_TARGET_ARCH}"
> > >  BPN = "gdb"
> > > 
> > >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
> > > -           virtual/${HOST_PREFIX}gcc-crosssdk
> > > virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
> > > +           virtual/${HOST_PREFIX}gcc-crosssdk
> > > virtual/${HOST_PREFIX}binutils-crosssdk \
> > > +           virtual/nativesdk-libc bison-native"
> > > 
> > 
> > Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?
> 
> Its not particular to riscv, it just happens to unearth the problem
> for us since its building gdb from upstream
> master, we are going to land into this problem eventually when we
> upgrade.

Is this not a tarball verses source control issue (the git version
needs the dependency, the tarball doesn't)?

Cheers,

Richard

Re: [PATCH 1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

[Khem Raj]

On Wed, Jan 2, 2019 at 1:31 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2019-01-02 at 11:42 -0800, Khem Raj wrote:
> > On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com>
> > wrote:
> > > On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > > From: pino-kim <sungwon.pino@gmail.com>
> > > >
> > > > This fixes RISC-V gdb-cross-canadian cross compile configure
> > > > failure on missing bison.
> > > >
> > > > Signed-off-by: pino-kim <sungwon.pino@gmail.com>
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > > b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > > index 475e4f08ef..e54766bbb2 100644
> > > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-
> > > > ${TRANSLATED_TARGET_ARCH}"
> > > >  BPN = "gdb"
> > > >
> > > >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
> > > > -           virtual/${HOST_PREFIX}gcc-crosssdk
> > > > virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
> > > > +           virtual/${HOST_PREFIX}gcc-crosssdk
> > > > virtual/${HOST_PREFIX}binutils-crosssdk \
> > > > +           virtual/nativesdk-libc bison-native"
> > > >
> > >
> > > Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?
> >
> > Its not particular to riscv, it just happens to unearth the problem
> > for us since its building gdb from upstream
> > master, we are going to land into this problem eventually when we
> > upgrade.
>
> Is this not a tarball verses source control issue (the git version
> needs the dependency, the tarball doesn't)?

yes that has triggered it but I have also seen it on certain bare
minimum build host OSes in past
even with tarballs.