All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] allarch: Generate same package for MIPS and non-MIPS targets
@ 2014-07-24 11:24 Mike Crowe
  2014-07-24 20:29 ` Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Crowe @ 2014-07-24 11:24 UTC (permalink / raw)
  To: openembedded-core; +Cc: Mike Crowe

LINKER_HASH_STYLE differs between MIPS and non-MIPS targets. This means
that LDFLAGS differs too. LDFLAGS is exported so it influences all task
hashes. Unfortunately this means that packages with architecture "all"
differ depending on whether they are built for a MIPS or non-MIPS target.
This causes a lot of unnecessary churn in the ipk/all directory when
switching build targets.

The simplest way to fix this is to ensure that LDFLAGS stays the same for
architecture "all" packages by clearing it. It shouldn't being used by such
packages anyway.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 meta/classes/allarch.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass
index d41dd4b..c953e7c 100644
--- a/meta/classes/allarch.bbclass
+++ b/meta/classes/allarch.bbclass
@@ -28,6 +28,11 @@ python () {
         d.setVar("SDK_ARCH", "none")
         d.setVar("SDK_CC_ARCH", "none")
 
+        # Avoid this being unnecessarily different due to nuances of
+        # the target machine that aren't important for "all" arch
+        # packages.
+        d.setVar("LDFLAGS", "")
+
         # No need to do shared library processing or debug symbol handling
         d.setVar("EXCLUDE_FROM_SHLIBS", "1")
         d.setVar("INHIBIT_PACKAGE_DEBUG_SPLIT", "1")
-- 
2.0.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] allarch: Generate same package for MIPS and non-MIPS targets
  2014-07-24 11:24 [PATCH] allarch: Generate same package for MIPS and non-MIPS targets Mike Crowe
@ 2014-07-24 20:29 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2014-07-24 20:29 UTC (permalink / raw)
  To: Mike Crowe; +Cc: Patches and discussions about the oe-core layer

On Thu, Jul 24, 2014 at 4:24 AM, Mike Crowe <mac@mcrowe.com> wrote:
> LINKER_HASH_STYLE differs between MIPS and non-MIPS targets. This means
> that LDFLAGS differs too. LDFLAGS is exported so it influences all task
> hashes. Unfortunately this means that packages with architecture "all"
> differ depending on whether they are built for a MIPS or non-MIPS target.
> This causes a lot of unnecessary churn in the ipk/all directory when
> switching build targets.
>
> The simplest way to fix this is to ensure that LDFLAGS stays the same for
> architecture "all" packages by clearing it. It shouldn't being used by such
> packages anyway.
>
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
>  meta/classes/allarch.bbclass | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass
> index d41dd4b..c953e7c 100644
> --- a/meta/classes/allarch.bbclass
> +++ b/meta/classes/allarch.bbclass
> @@ -28,6 +28,11 @@ python () {
>          d.setVar("SDK_ARCH", "none")
>          d.setVar("SDK_CC_ARCH", "none")
>
> +        # Avoid this being unnecessarily different due to nuances of
> +        # the target machine that aren't important for "all" arch
> +        # packages.
> +        d.setVar("LDFLAGS", "")
> +


Looks good.

>          # No need to do shared library processing or debug symbol handling
>          d.setVar("EXCLUDE_FROM_SHLIBS", "1")
>          d.setVar("INHIBIT_PACKAGE_DEBUG_SPLIT", "1")
> --
> 2.0.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-24 20:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-24 11:24 [PATCH] allarch: Generate same package for MIPS and non-MIPS targets Mike Crowe
2014-07-24 20:29 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.