* [PATCH v2] lubusb1: Add udev support
@ 2019-01-24 22:35 Alistair Francis
2019-01-26 23:27 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Alistair Francis @ 2019-01-24 22:35 UTC (permalink / raw)
To: openembedded-core
I don't see circular dependencies anymore between libusb1 and udev, so
enable udev support for libusb1.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb b/meta/recipes-support/libusb/libusb1_1.0.22.bb
index 0c6e116dd7..35c1d705b6 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
@@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
inherit autotools pkgconfig ptest
-# Don't configure udev by default since it will cause a circular
-# dependecy with udev package, which depends on libusb
-EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
+PACKAGECONFIG ??= "udev"
+PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
+
+EXTRA_OECONF = "--libdir=${base_libdir}"
do_install_append() {
install -d ${D}${libdir}
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lubusb1: Add udev support
2019-01-24 22:35 [PATCH v2] lubusb1: Add udev support Alistair Francis
@ 2019-01-26 23:27 ` Richard Purdie
2019-01-27 1:10 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-01-26 23:27 UTC (permalink / raw)
To: Alistair Francis, openembedded-core
On Thu, 2019-01-24 at 22:35 +0000, Alistair Francis wrote:
> I don't see circular dependencies anymore between libusb1 and udev,
> so
> enable udev support for libusb1.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> index 0c6e116dd7..35c1d705b6 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> @@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
>
> inherit autotools pkgconfig ptest
>
> -# Don't configure udev by default since it will cause a circular
> -# dependecy with udev package, which depends on libusb
> -EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
> +PACKAGECONFIG ??= "udev"
> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> +
> +EXTRA_OECONF = "--libdir=${base_libdir}"
Fails in testing with:
WARNING: Nothing PROVIDES 'nativesdk-udev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
WARNING: Nothing PROVIDES 'udev-native' (but virtual:native:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
WARNING: Nothing RPROVIDES 'nativesdk-libusb1-dev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
WARNING: Nothing RPROVIDES 'nativesdk-libusb1' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
Before someone sends a patch creating a nativesdk-udev please think
very carefully about whether a nativesdk-udev makes sense and what it
may need to look like.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lubusb1: Add udev support
2019-01-26 23:27 ` Richard Purdie
@ 2019-01-27 1:10 ` Khem Raj
2019-01-27 7:15 ` Alistair Francis
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2019-01-27 1:10 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Sat, Jan 26, 2019 at 3:27 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Thu, 2019-01-24 at 22:35 +0000, Alistair Francis wrote:
> > I don't see circular dependencies anymore between libusb1 and udev,
> > so
> > enable udev support for libusb1.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > index 0c6e116dd7..35c1d705b6 100644
> > --- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > +++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > @@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
> >
> > inherit autotools pkgconfig ptest
> >
> > -# Don't configure udev by default since it will cause a circular
> > -# dependecy with udev package, which depends on libusb
> > -EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
> > +PACKAGECONFIG ??= "udev"
> > +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> > +
> > +EXTRA_OECONF = "--libdir=${base_libdir}"
>
> Fails in testing with:
>
> WARNING: Nothing PROVIDES 'nativesdk-udev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
> WARNING: Nothing PROVIDES 'udev-native' (but virtual:native:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
> WARNING: Nothing RPROVIDES 'nativesdk-libusb1-dev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
> WARNING: Nothing RPROVIDES 'nativesdk-libusb1' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
>
I am seeing these fails too
> Before someone sends a patch creating a nativesdk-udev please think
> very carefully about whether a nativesdk-udev makes sense and what it
> may need to look like.
>
> Cheers,
>
> Richard
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lubusb1: Add udev support
2019-01-27 1:10 ` Khem Raj
@ 2019-01-27 7:15 ` Alistair Francis
2019-01-27 12:07 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Alistair Francis @ 2019-01-27 7:15 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On Sat, Jan 26, 2019 at 5:11 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sat, Jan 26, 2019 at 3:27 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Thu, 2019-01-24 at 22:35 +0000, Alistair Francis wrote:
> > > I don't see circular dependencies anymore between libusb1 and udev,
> > > so
> > > enable udev support for libusb1.
> > >
> > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > ---
> > > meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > index 0c6e116dd7..35c1d705b6 100644
> > > --- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > +++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > @@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
> > >
> > > inherit autotools pkgconfig ptest
> > >
> > > -# Don't configure udev by default since it will cause a circular
> > > -# dependecy with udev package, which depends on libusb
> > > -EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
> > > +PACKAGECONFIG ??= "udev"
> > > +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> > > +
> > > +EXTRA_OECONF = "--libdir=${base_libdir}"
> >
> > Fails in testing with:
> >
> > WARNING: Nothing PROVIDES 'nativesdk-udev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
> > WARNING: Nothing PROVIDES 'udev-native' (but virtual:native:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS on or otherwise requires it). Close matches:
> > WARNING: Nothing RPROVIDES 'nativesdk-libusb1-dev' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
> > WARNING: Nothing RPROVIDES 'nativesdk-libusb1' (but virtual:nativesdk:/home/pokybuild/yocto-worker/a-quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb RDEPENDS on or otherwise requires it)
> >
>
> I am seeing these fails too
>
> > Before someone sends a patch creating a nativesdk-udev please think
> > very carefully about whether a nativesdk-udev makes sense and what it
> > may need to look like.
What about just disabling the packageconfig for nativesdk? Would that
be a better option?
Alistair
>
> >
> > Cheers,
> >
> > Richard
> >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lubusb1: Add udev support
2019-01-27 7:15 ` Alistair Francis
@ 2019-01-27 12:07 ` Richard Purdie
2019-01-29 22:56 ` Alistair Francis
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-01-27 12:07 UTC (permalink / raw)
To: Alistair Francis, Khem Raj; +Cc: openembedded-core
On Sat, 2019-01-26 at 23:15 -0800, Alistair Francis wrote:
> On Sat, Jan 26, 2019 at 5:11 PM Khem Raj <raj.khem@gmail.com> wrote:
> > On Sat, Jan 26, 2019 at 3:27 PM Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Thu, 2019-01-24 at 22:35 +0000, Alistair Francis wrote:
> > > > I don't see circular dependencies anymore between libusb1 and
> > > > udev,
> > > > so
> > > > enable udev support for libusb1.
> > > >
> > > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > > ---
> > > > meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
> > > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > index 0c6e116dd7..35c1d705b6 100644
> > > > --- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > +++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > @@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
> > > >
> > > > inherit autotools pkgconfig ptest
> > > >
> > > > -# Don't configure udev by default since it will cause a
> > > > circular
> > > > -# dependecy with udev package, which depends on libusb
> > > > -EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
> > > > +PACKAGECONFIG ??= "udev"
> > > > +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> > > > +
> > > > +EXTRA_OECONF = "--libdir=${base_libdir}"
> > >
> > > Fails in testing with:
> > >
> > > WARNING: Nothing PROVIDES 'nativesdk-udev' (but
> > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS
> > > on or otherwise requires it). Close matches:
> > > WARNING: Nothing PROVIDES 'udev-native' (but
> > > virtual:native:/home/pokybuild/yocto-worker/a-
> > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS
> > > on or otherwise requires it). Close matches:
> > > WARNING: Nothing RPROVIDES 'nativesdk-libusb1-dev' (but
> > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > RDEPENDS on or otherwise requires it)
> > > WARNING: Nothing RPROVIDES 'nativesdk-libusb1' (but
> > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > RDEPENDS on or otherwise requires it)
> > >
> >
> > I am seeing these fails too
> >
> > > Before someone sends a patch creating a nativesdk-udev please
> > > think
> > > very carefully about whether a nativesdk-udev makes sense and
> > > what it
> > > may need to look like.
>
> What about just disabling the packageconfig for nativesdk? Would that
> be a better option?
Probably easier but what functionality are we missing out on in libusb
and do we need it? This might limit the functionality of tools in the
SDK?
That said, we've been without this so far so you have to wonder how
useful it is even on target...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] lubusb1: Add udev support
2019-01-27 12:07 ` Richard Purdie
@ 2019-01-29 22:56 ` Alistair Francis
0 siblings, 0 replies; 6+ messages in thread
From: Alistair Francis @ 2019-01-29 22:56 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Sun, Jan 27, 2019 at 4:07 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sat, 2019-01-26 at 23:15 -0800, Alistair Francis wrote:
> > On Sat, Jan 26, 2019 at 5:11 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > On Sat, Jan 26, 2019 at 3:27 PM Richard Purdie
> > > <richard.purdie@linuxfoundation.org> wrote:
> > > > On Thu, 2019-01-24 at 22:35 +0000, Alistair Francis wrote:
> > > > > I don't see circular dependencies anymore between libusb1 and
> > > > > udev,
> > > > > so
> > > > > enable udev support for libusb1.
> > > > >
> > > > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > > > ---
> > > > > meta/recipes-support/libusb/libusb1_1.0.22.bb | 7 ++++---
> > > > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > > b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > > index 0c6e116dd7..35c1d705b6 100644
> > > > > --- a/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > > +++ b/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > > @@ -20,9 +20,10 @@ S = "${WORKDIR}/libusb-${PV}"
> > > > >
> > > > > inherit autotools pkgconfig ptest
> > > > >
> > > > > -# Don't configure udev by default since it will cause a
> > > > > circular
> > > > > -# dependecy with udev package, which depends on libusb
> > > > > -EXTRA_OECONF = "--libdir=${base_libdir} --disable-udev"
> > > > > +PACKAGECONFIG ??= "udev"
> > > > > +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> > > > > +
> > > > > +EXTRA_OECONF = "--libdir=${base_libdir}"
> > > >
> > > > Fails in testing with:
> > > >
> > > > WARNING: Nothing PROVIDES 'nativesdk-udev' (but
> > > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS
> > > > on or otherwise requires it). Close matches:
> > > > WARNING: Nothing PROVIDES 'udev-native' (but
> > > > virtual:native:/home/pokybuild/yocto-worker/a-
> > > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb DEPENDS
> > > > on or otherwise requires it). Close matches:
> > > > WARNING: Nothing RPROVIDES 'nativesdk-libusb1-dev' (but
> > > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > RDEPENDS on or otherwise requires it)
> > > > WARNING: Nothing RPROVIDES 'nativesdk-libusb1' (but
> > > > virtual:nativesdk:/home/pokybuild/yocto-worker/a-
> > > > quick/build/meta/recipes-support/libusb/libusb1_1.0.22.bb
> > > > RDEPENDS on or otherwise requires it)
> > > >
> > >
> > > I am seeing these fails too
> > >
> > > > Before someone sends a patch creating a nativesdk-udev please
> > > > think
> > > > very carefully about whether a nativesdk-udev makes sense and
> > > > what it
> > > > may need to look like.
> >
> > What about just disabling the packageconfig for nativesdk? Would that
> > be a better option?
>
> Probably easier but what functionality are we missing out on in libusb
> and do we need it? This might limit the functionality of tools in the
> SDK?
>
> That said, we've been without this so far so you have to wonder how
> useful it is even on target...
It helped me with some debugging, but in the end I don't think (I
haven't checked) that I actually need it. Still it does seem useful to
have.
Alistair
>
> Cheers,
>
> Richard
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-29 22:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-24 22:35 [PATCH v2] lubusb1: Add udev support Alistair Francis
2019-01-26 23:27 ` Richard Purdie
2019-01-27 1:10 ` Khem Raj
2019-01-27 7:15 ` Alistair Francis
2019-01-27 12:07 ` Richard Purdie
2019-01-29 22:56 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.