[PATCH] go-dep: Add 0.2.0 release

[PATCH] go-dep: Add 0.2.0 release

[Otavio Salvador]

This is the Golang dependency management tool under development; it is
ready for production use and intended to be merged onto Golang
1.10. Until that, projects are starting to use it and making it
available on OE-Core reduces the Golang integration work for new
recipes.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 meta/recipes-devtools/go/go-dep_0.2.0.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go-dep_0.2.0.bb

diff --git a/meta/recipes-devtools/go/go-dep_0.2.0.bb b/meta/recipes-devtools/go/go-dep_0.2.0.bb
new file mode 100644
index 0000000000..2b116c9af2
--- /dev/null
+++ b/meta/recipes-devtools/go/go-dep_0.2.0.bb
@@ -0,0 +1,18 @@
+SUMMARY = "Dependency management tool for Golang"
+HOMEPAGE = "https://github.com/golang/dep"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=1bad315647751fab0007812f70d42c0d"
+
+GO_IMPORT = "github.com/golang/dep"
+SRC_URI = "git://${GO_IMPORT};destsuffix=${BPN}-${PV}/src/${GO_IMPORT};nobranch=1"
+
+# Points to 0.2.0 tag
+SRCREV = "6a17782ed25ba4ccd2adf191990cc32e65c3934c"
+
+inherit go
+
+GO_INSTALL = "${GO_IMPORT}/cmd/dep"
+
+INSANE_SKIP_${PN} += "ldflags"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.13.3

Re: [PATCH] go-dep: Add 0.2.0 release

[Khem Raj]

On Fri, Jul 28, 2017 at 11:07 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> This is the Golang dependency management tool under development; it is
> ready for production use and intended to be merged onto Golang
> 1.10. Until that, projects are starting to use it and making it
> available on OE-Core reduces the Golang integration work for new
> recipes.
>

Looks good. Thanks

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
>  meta/recipes-devtools/go/go-dep_0.2.0.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta/recipes-devtools/go/go-dep_0.2.0.bb
>
> diff --git a/meta/recipes-devtools/go/go-dep_0.2.0.bb b/meta/recipes-devtools/go/go-dep_0.2.0.bb
> new file mode 100644
> index 0000000000..2b116c9af2
> --- /dev/null
> +++ b/meta/recipes-devtools/go/go-dep_0.2.0.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "Dependency management tool for Golang"
> +HOMEPAGE = "https://github.com/golang/dep"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=1bad315647751fab0007812f70d42c0d"
> +
> +GO_IMPORT = "github.com/golang/dep"
> +SRC_URI = "git://${GO_IMPORT};destsuffix=${BPN}-${PV}/src/${GO_IMPORT};nobranch=1"
> +
> +# Points to 0.2.0 tag
> +SRCREV = "6a17782ed25ba4ccd2adf191990cc32e65c3934c"
> +
> +inherit go
> +
> +GO_INSTALL = "${GO_IMPORT}/cmd/dep"
> +
> +INSANE_SKIP_${PN} += "ldflags"
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.13.3
>

Re: [PATCH] go-dep: Add 0.2.0 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

Failed in the no-x11 builder at least so far:

ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories were
installed but not shipped in any package:
  /usr/lib/x86_64-poky-linux/go/bin/dep
Please set FILES such that these items are packaged. Alternatively if they
are unneeded, avoid installing them or delete them within do_install.

https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/537

Ross

On 28 July 2017 at 19:07, Otavio Salvador <otavio@ossystems.com.br> wrote:

> This is the Golang dependency management tool under development; it is
> ready for production use and intended to be merged onto Golang
> 1.10. Until that, projects are starting to use it and making it
> available on OE-Core reduces the Golang integration work for new
> recipes.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
>  meta/recipes-devtools/go/go-dep_0.2.0.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta/recipes-devtools/go/go-dep_0.2.0.bb
>
> diff --git a/meta/recipes-devtools/go/go-dep_0.2.0.bb
> b/meta/recipes-devtools/go/go-dep_0.2.0.bb
> new file mode 100644
> index 0000000000..2b116c9af2
> --- /dev/null
> +++ b/meta/recipes-devtools/go/go-dep_0.2.0.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "Dependency management tool for Golang"
> +HOMEPAGE = "https://github.com/golang/dep"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=
> 1bad315647751fab0007812f70d42c0d"
> +
> +GO_IMPORT = "github.com/golang/dep"
> +SRC_URI = "git://${GO_IMPORT};destsuffix=${BPN}-${PV}/src/${
> GO_IMPORT};nobranch=1"
> +
> +# Points to 0.2.0 tag
> +SRCREV = "6a17782ed25ba4ccd2adf191990cc32e65c3934c"
> +
> +inherit go
> +
> +GO_INSTALL = "${GO_IMPORT}/cmd/dep"
> +
> +INSANE_SKIP_${PN} += "ldflags"
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.13.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3593 bytes --]

Re: [PATCH] go-dep: Add 0.2.0 release

[Otavio Salvador]

Hello Ross,
Hello Khem,

On Sat, Jul 29, 2017 at 3:28 PM, Burton, Ross <ross.burton@intel.com> wrote:
> Failed in the no-x11 builder at least so far:
>
> ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories were
> installed but not shipped in any package:
>   /usr/lib/x86_64-poky-linux/go/bin/dep
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
>
> https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/537

I did reproduce this; I could only reproduce it if I built it with a
machine which matches the architecture of host, in my case x86-64.
When building for other arch (e.g: ARM) it works as expected.

The problem seems to be a generic problem and I am not experienced
enough on the Golang toolchain to look at this. Khem could you take a
look and see if you find the root cause?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] go-dep: Add 0.2.0 release

[Khem Raj]

[-- Attachment #1.1: Type: text/plain, Size: 1127 bytes --]



On 7/31/17 12:12 PM, Otavio Salvador wrote:
> Hello Ross,
> Hello Khem,
> 
> On Sat, Jul 29, 2017 at 3:28 PM, Burton, Ross <ross.burton@intel.com> wrote:
>> Failed in the no-x11 builder at least so far:
>>
>> ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories were
>> installed but not shipped in any package:
>>   /usr/lib/x86_64-poky-linux/go/bin/dep
>> Please set FILES such that these items are packaged. Alternatively if they
>> are unneeded, avoid installing them or delete them within do_install.
>>
>> https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/537
> 
> I did reproduce this; I could only reproduce it if I built it with a
> machine which matches the architecture of host, in my case x86-64.
> When building for other arch (e.g: ARM) it works as expected.
> 
> The problem seems to be a generic problem and I am not experienced
> enough on the Golang toolchain to look at this. Khem could you take a
> look and see if you find the root cause?

Delete this file, its building it on x86_64 because it can. We only need
cross version.

> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

Re: [PATCH] go-dep: Add 0.2.0 release

[Otavio Salvador]

On Mon, Jul 31, 2017 at 4:20 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
>
> On 7/31/17 12:12 PM, Otavio Salvador wrote:
>> Hello Ross,
>> Hello Khem,
>>
>> On Sat, Jul 29, 2017 at 3:28 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>> Failed in the no-x11 builder at least so far:
>>>
>>> ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories were
>>> installed but not shipped in any package:
>>>   /usr/lib/x86_64-poky-linux/go/bin/dep
>>> Please set FILES such that these items are packaged. Alternatively if they
>>> are unneeded, avoid installing them or delete them within do_install.
>>>
>>> https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/537
>>
>> I did reproduce this; I could only reproduce it if I built it with a
>> machine which matches the architecture of host, in my case x86-64.
>> When building for other arch (e.g: ARM) it works as expected.
>>
>> The problem seems to be a generic problem and I am not experienced
>> enough on the Golang toolchain to look at this. Khem could you take a
>> look and see if you find the root cause?
>
> Delete this file, its building it on x86_64 because it can. We only need
> cross version.

I am not sure I follow you here.

Using qemux86-64 as target it does NOT install on ${bindir} and
surprisingly the installation path does also not match GOBIN_FINAL
value.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] go-dep: Add 0.2.0 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]

Verifying this here.

Building for qemuarm puts the binary in /usr/bin/dep.  Building for
intel-corei7-64 puts the binary in /usr/lib/x86_64-poky-linux/go/bin/dep.

Ross

On 31 July 2017 at 20:52, Otavio Salvador <otavio.salvador@ossystems.com.br>
wrote:

> On Mon, Jul 31, 2017 at 4:20 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >
> >
> > On 7/31/17 12:12 PM, Otavio Salvador wrote:
> >> Hello Ross,
> >> Hello Khem,
> >>
> >> On Sat, Jul 29, 2017 at 3:28 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> >>> Failed in the no-x11 builder at least so far:
> >>>
> >>> ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories
> were
> >>> installed but not shipped in any package:
> >>>   /usr/lib/x86_64-poky-linux/go/bin/dep
> >>> Please set FILES such that these items are packaged. Alternatively if
> they
> >>> are unneeded, avoid installing them or delete them within do_install.
> >>>
> >>> https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/
> builds/537
> >>
> >> I did reproduce this; I could only reproduce it if I built it with a
> >> machine which matches the architecture of host, in my case x86-64.
> >> When building for other arch (e.g: ARM) it works as expected.
> >>
> >> The problem seems to be a generic problem and I am not experienced
> >> enough on the Golang toolchain to look at this. Khem could you take a
> >> look and see if you find the root cause?
> >
> > Delete this file, its building it on x86_64 because it can. We only need
> > cross version.
>
> I am not sure I follow you here.
>
> Using qemux86-64 as target it does NOT install on ${bindir} and
> surprisingly the installation path does also not match GOBIN_FINAL
> value.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 3179 bytes --]

Re: [PATCH] go-dep: Add 0.2.0 release

[Khem Raj]

On Tue, Aug 1, 2017 at 6:50 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Verifying this here.
>
> Building for qemuarm puts the binary in /usr/bin/dep.  Building for
> intel-corei7-64 puts the binary in /usr/lib/x86_64-poky-linux/go/bin/dep.
>

may be configure logs can tell why is it making this distinction.
Since we are not building
for multiarch, using /usr/bin/dep might be ok

> Ross
>
> On 31 July 2017 at 20:52, Otavio Salvador <otavio.salvador@ossystems.com.br>
> wrote:
>>
>> On Mon, Jul 31, 2017 at 4:20 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> >
>> >
>> > On 7/31/17 12:12 PM, Otavio Salvador wrote:
>> >> Hello Ross,
>> >> Hello Khem,
>> >>
>> >> On Sat, Jul 29, 2017 at 3:28 PM, Burton, Ross <ross.burton@intel.com>
>> >> wrote:
>> >>> Failed in the no-x11 builder at least so far:
>> >>>
>> >>> ERROR: go-dep-0.2.0-r0 do_package: QA Issue: go-dep: Files/directories
>> >>> were
>> >>> installed but not shipped in any package:
>> >>>   /usr/lib/x86_64-poky-linux/go/bin/dep
>> >>> Please set FILES such that these items are packaged. Alternatively if
>> >>> they
>> >>> are unneeded, avoid installing them or delete them within do_install.
>> >>>
>> >>>
>> >>> https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/537
>> >>
>> >> I did reproduce this; I could only reproduce it if I built it with a
>> >> machine which matches the architecture of host, in my case x86-64.
>> >> When building for other arch (e.g: ARM) it works as expected.
>> >>
>> >> The problem seems to be a generic problem and I am not experienced
>> >> enough on the Golang toolchain to look at this. Khem could you take a
>> >> look and see if you find the root cause?
>> >
>> > Delete this file, its building it on x86_64 because it can. We only need
>> > cross version.
>>
>> I am not sure I follow you here.
>>
>> Using qemux86-64 as target it does NOT install on ${bindir} and
>> surprisingly the installation path does also not match GOBIN_FINAL
>> value.
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>
>