All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
@ 2017-10-03 21:54 Juro Bystricky
  2017-10-04  2:01 ` Andre McCurdy
  0 siblings, 1 reply; 6+ messages in thread
From: Juro Bystricky @ 2017-10-03 21:54 UTC (permalink / raw)
  To: openembedded-core; +Cc: marex, jurobystricky, yau.wai.gan

With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b some nios2 builds
(uboot, core-image-minimal, etc) were broken due to db trying to use ARM instructions
in mutexes. The reason was db "configure" used the cached entry from nios2-linux
(which was incorrect). So the remedy was to remove the incorrect cached entry
and let db "configure" figure out which is the proper mutex to use.

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 meta/site/nios2-linux | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
index 2f4e570..5bae748 100644
--- a/meta/site/nios2-linux
+++ b/meta/site/nios2-linux
@@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
 db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
-db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
 db_cv_posixmutexes=${db_cv_posixmutexes=no}
 db_cv_uimutexes=${db_cv_uimutexes=no}
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
  2017-10-03 21:54 [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info Juro Bystricky
@ 2017-10-04  2:01 ` Andre McCurdy
  2017-10-04  2:25   ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Andre McCurdy @ 2017-10-04  2:01 UTC (permalink / raw)
  To: Juro Bystricky; +Cc: marex, Juro Bystricky, yau.wai.gan, OE Core mailing list

On Tue, Oct 3, 2017 at 2:54 PM, Juro Bystricky <juro.bystricky@intel.com> wrote:
> With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b

That revision doesn't exist in oe-core...

> some nios2 builds
> (uboot, core-image-minimal, etc) were broken due to db trying to use ARM instructions
> in mutexes. The reason was db "configure" used the cached entry from nios2-linux
> (which was incorrect). So the remedy was to remove the incorrect cached entry
> and let db "configure" figure out which is the proper mutex to use.
>
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> ---
>  meta/site/nios2-linux | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
> index 2f4e570..5bae748 100644
> --- a/meta/site/nios2-linux
> +++ b/meta/site/nios2-linux
> @@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
>  db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
>  db_cv_align_t=${db_cv_align_t='unsigned long long'}
>  db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
> -db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
>  db_cv_posixmutexes=${db_cv_posixmutexes=no}
>  db_cv_uimutexes=${db_cv_uimutexes=no}
>
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
  2017-10-04  2:01 ` Andre McCurdy
@ 2017-10-04  2:25   ` Marek Vasut
  2017-10-04  2:32     ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2017-10-04  2:25 UTC (permalink / raw)
  To: Andre McCurdy, Juro Bystricky
  Cc: Juro Bystricky, yau.wai.gan, OE Core mailing list

On 10/04/2017 04:01 AM, Andre McCurdy wrote:
> On Tue, Oct 3, 2017 at 2:54 PM, Juro Bystricky <juro.bystricky@intel.com> wrote:
>> With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b
> 
> That revision doesn't exist in oe-core...

Also, isn't there some sort of standardized format for listing git
commit IDs in commit messages ? I recall Linux kernel agreed on
something like that.

>> some nios2 builds
>> (uboot, core-image-minimal, etc) were broken due to db trying to use ARM instructions
>> in mutexes. The reason was db "configure" used the cached entry from nios2-linux
>> (which was incorrect). So the remedy was to remove the incorrect cached entry
>> and let db "configure" figure out which is the proper mutex to use.
>>
>> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>> ---
>>  meta/site/nios2-linux | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
>> index 2f4e570..5bae748 100644
>> --- a/meta/site/nios2-linux
>> +++ b/meta/site/nios2-linux
>> @@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
>>  db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
>>  db_cv_align_t=${db_cv_align_t='unsigned long long'}
>>  db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
>> -db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
>>  db_cv_posixmutexes=${db_cv_posixmutexes=no}
>>  db_cv_uimutexes=${db_cv_uimutexes=no}
>>
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
Best regards,
Marek Vasut


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
  2017-10-04  2:25   ` Marek Vasut
@ 2017-10-04  2:32     ` Khem Raj
  2017-10-04 16:07       ` Bystricky, Juro
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2017-10-04  2:32 UTC (permalink / raw)
  To: Marek Vasut; +Cc: yau.wai.gan, Juro Bystricky, OE Core mailing list

On Tue, Oct 3, 2017 at 7:25 PM, Marek Vasut <marex@denx.de> wrote:
> On 10/04/2017 04:01 AM, Andre McCurdy wrote:
>> On Tue, Oct 3, 2017 at 2:54 PM, Juro Bystricky <juro.bystricky@intel.com> wrote:
>>> With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b
>>
>> That revision doesn't exist in oe-core...
>

it exists in poky, sometimes users confuse Openembedded repositories with
yocto repositories, its unfortunate but not uncommon

> Also, isn't there some sort of standardized format for listing git
> commit IDs in commit messages ? I recall Linux kernel agreed on
> something like that.
>
>>> some nios2 builds
>>> (uboot, core-image-minimal, etc) were broken due to db trying to use ARM instructions
>>> in mutexes. The reason was db "configure" used the cached entry from nios2-linux
>>> (which was incorrect). So the remedy was to remove the incorrect cached entry
>>> and let db "configure" figure out which is the proper mutex to use.
>>>
>>> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>>> ---
>>>  meta/site/nios2-linux | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
>>> index 2f4e570..5bae748 100644
>>> --- a/meta/site/nios2-linux
>>> +++ b/meta/site/nios2-linux
>>> @@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
>>>  db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
>>>  db_cv_align_t=${db_cv_align_t='unsigned long long'}
>>>  db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
>>> -db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
>>>  db_cv_posixmutexes=${db_cv_posixmutexes=no}
>>>  db_cv_uimutexes=${db_cv_uimutexes=no}
>>>
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> --
> Best regards,
> Marek Vasut
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
  2017-10-04  2:32     ` Khem Raj
@ 2017-10-04 16:07       ` Bystricky, Juro
  2017-10-04 16:09         ` Burton, Ross
  0 siblings, 1 reply; 6+ messages in thread
From: Bystricky, Juro @ 2017-10-04 16:07 UTC (permalink / raw)
  To: Khem Raj, Marek Vasut; +Cc: Gan, Yau Wai, Juro Bystricky, OE Core mailing list

> > On 10/04/2017 04:01 AM, Andre McCurdy wrote:
> >> On Tue, Oct 3, 2017 at 2:54 PM, Juro Bystricky
> <juro.bystricky@intel.com> wrote:
> >>> With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b
> >>
> >> That revision doesn't exist in oe-core...
> >
> 
> it exists in poky, sometimes users confuse Openembedded repositories with
> yocto repositories, its unfortunate but not uncommon
> 

The commit I referenced is here:
http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/recipes-support/db?id=f4e8e9242c5df095b52688b083df3c9d36e7144b

Just to clarify: that commit did not break the build, it exposed the error that broke the build for nios2.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info
  2017-10-04 16:07       ` Bystricky, Juro
@ 2017-10-04 16:09         ` Burton, Ross
  0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2017-10-04 16:09 UTC (permalink / raw)
  To: Bystricky, Juro
  Cc: Marek Vasut, Juro Bystricky, Gan, Yau Wai, OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On 4 October 2017 at 17:07, Bystricky, Juro <juro.bystricky@intel.com>
wrote:

> > > On 10/04/2017 04:01 AM, Andre McCurdy wrote:
> > >> On Tue, Oct 3, 2017 at 2:54 PM, Juro Bystricky
> > <juro.bystricky@intel.com> wrote:
> > >>> With the commit f4e8e9242c5df095b52688b083df3c9d36e7144b
> > >>
> > >> That revision doesn't exist in oe-core...
> > >
> >
> > it exists in poky, sometimes users confuse Openembedded repositories with
> > yocto repositories, its unfortunate but not uncommon
> >
>
> The commit I referenced is here:
> http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/
> recipes-support/db?id=f4e8e9242c5df095b52688b083df3c9d36e7144b
>
> Just to clarify: that commit did not break the build, it exposed the error
> that broke the build for nios2.


The canonical repository is oe-core so we try to use oe-core references.
I'll fix the commit in my queue. :)

Ross

[-- Attachment #2: Type: text/html, Size: 1601 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-04 16:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 21:54 [PATCH v2] siteinfo: nios2-linux - remove wrong mutex info Juro Bystricky
2017-10-04  2:01 ` Andre McCurdy
2017-10-04  2:25   ` Marek Vasut
2017-10-04  2:32     ` Khem Raj
2017-10-04 16:07       ` Bystricky, Juro
2017-10-04 16:09         ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.