[PATCH] linux-libc-headers: Don't do useless configuration

[PATCH] linux-libc-headers: Don't do useless configuration

[Alexey Brodkin]

There's no point in configuring Linux kernel before
headers installation.

Moreover in come cases it might lead to problems on kernels
starting from 4.17 with architecture or platfrom sets
CROSS_COMPILE variable automatically, see [1].

Also note Buildroot doesn't do that kind of confiuration as
well, see [2].

[1] https://lkml.org/lkml/2018/9/12/486
[2] https://git.buildroot.org/buildroot/tree/package/linux-headers/linux-headers.mk#n106

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
 meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
index 05c82558e653..1a365ddeb6a9 100644
--- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
+++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
@@ -54,7 +54,6 @@ S = "${WORKDIR}/linux-${PV}"
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC}" HOSTCPP="${BUILD_CPP}""
 
 do_configure() {
-	oe_runmake allnoconfig
 }
 
 do_compile () {
-- 
2.17.1

Re: [PATCH] linux-libc-headers: Don't do useless configuration

[Khem Raj]

On Wed, Sep 12, 2018 at 9:03 AM Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
>
> There's no point in configuring Linux kernel before
> headers installation.
>

At one point the headers install did not work with out a .config file,
has that changed ?
if so then this is fine to remove it but this change needs to be done
a bit differently if thats what it did in this task

remove do_configure and then add

do_configure[noexec] = "1"


> Moreover in come cases it might lead to problems on kernels
> starting from 4.17 with architecture or platfrom sets
> CROSS_COMPILE variable automatically, see [1].
>
> Also note Buildroot doesn't do that kind of confiuration as
> well, see [2].
>
> [1] https://lkml.org/lkml/2018/9/12/486
> [2] https://git.buildroot.org/buildroot/tree/package/linux-headers/linux-headers.mk#n106
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
>  meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> index 05c82558e653..1a365ddeb6a9 100644
> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> @@ -54,7 +54,6 @@ S = "${WORKDIR}/linux-${PV}"
>  EXTRA_OEMAKE = " HOSTCC="${BUILD_CC}" HOSTCPP="${BUILD_CPP}""
>
>  do_configure() {
> -       oe_runmake allnoconfig
>  }
>
>  do_compile () {
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] linux-libc-headers: Don't do useless configuration

[Alexey Brodkin]

Hi Khem,

On Wed, 2018-09-12 at 09:29 -0700, Khem Raj wrote:
> On Wed, Sep 12, 2018 at 9:03 AM Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > 
> > There's no point in configuring Linux kernel before
> > headers installation.
> > 
> 
> At one point the headers install did not work with out a .config file,
> has that changed ?

Well that's hard to tell as I have no idea when and what kind of breakage
was seen :)

I'd say with up-to-date kernels it shouldn't happen and that's the
point Masahiro-san made here: https://lkml.org/lkml/2018/9/12/678


> if so then this is fine to remove it but this change needs to be done
> a bit differently if thats what it did in this task
> 
> remove do_configure and then add
> 
> do_configure[noexec] = "1"

Ok will do that. But why do we have 2 lines below:
------------------------------>8--------------------------
do_compile ()
{                                                                                                                                               
}
------------------------------>8--------------------------

-Alexey

Re: [PATCH] linux-libc-headers: Don't do useless configuration

[Khem Raj]

On Wed, Sep 12, 2018 at 9:35 AM Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
>
> Hi Khem,
>
> On Wed, 2018-09-12 at 09:29 -0700, Khem Raj wrote:
> > On Wed, Sep 12, 2018 at 9:03 AM Alexey Brodkin
> > <Alexey.Brodkin@synopsys.com> wrote:
> > >
> > > There's no point in configuring Linux kernel before
> > > headers installation.
> > >
> >
> > At one point the headers install did not work with out a .config file,
> > has that changed ?
>
> Well that's hard to tell as I have no idea when and what kind of breakage
> was seen :)
>
> I'd say with up-to-date kernels it shouldn't happen and that's the
> point Masahiro-san made here: https://lkml.org/lkml/2018/9/12/678
>

We lock the kernel-headers anyway to if it is how it is in 4.18 we
should be fine

>
> > if so then this is fine to remove it but this change needs to be done
> > a bit differently if thats what it did in this task
> >
> > remove do_configure and then add
> >
> > do_configure[noexec] = "1"
>
> Ok will do that. But why do we have 2 lines below:
> ------------------------------>8--------------------------
> do_compile ()
> {
> }
> ------------------------------>8--------------------------
>

you can change that too. Probably its there before noexec approach was adopted
widely.

> -Alexey