* [meta-oe][PATCH] ndctl: Remove run test of typeof
@ 2022-04-08 19:42 Jeremy A. Puhlman
2022-04-08 19:54 ` [oe] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy A. Puhlman @ 2022-04-08 19:42 UTC (permalink / raw)
To: openembedded-devel; +Cc: Jeremy A. Puhlman
../git/meson.build:213:0: ERROR: Can not run test applications in this cross environment.
Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
---
...sume-typeof-exists-in-our-modern-gcc.patch | 45 +++++++++++++++++++
meta-oe/recipes-core/ndctl/ndctl_v73.bb | 4 +-
2 files changed, 48 insertions(+), 1 deletion(-)
create mode 100644 meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
diff --git a/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
new file mode 100644
index 000000000..b47510a6b
--- /dev/null
+++ b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
@@ -0,0 +1,45 @@
+From 3abfe16bf2eb89efe3c823a935a6752c4a5b99d1 Mon Sep 17 00:00:00 2001
+From: "Jeremy A. Puhlman" <jpuhlman@mvista.com>
+Date: Fri, 8 Apr 2022 19:31:02 +0000
+Subject: [PATCH] Assume typeof exists in our modern gcc
+
+cc.run tests are not useful in a cross environment.
+
+Upstream-Status: Inappropriate [Assumes modern compiler]
+Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
+---
+ meson.build | 18 ++----------------
+ 1 file changed, 2 insertions(+), 16 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 42e11aa..e8d218b 100644
+--- a/meson.build
++++ b/meson.build
+@@ -210,22 +210,8 @@ conf.set('ENABLE_DESTRUCTIVE', get_option('destructive').enabled())
+ conf.set('ENABLE_LOGGING', get_option('logging').enabled())
+ conf.set('ENABLE_DEBUG', get_option('dbg').enabled())
+
+-typeof = cc.run('''
+- int main() {
+- struct {
+- char a[16];
+- } x;
+- typeof(x) y;
+-
+- return sizeof(x) == sizeof(y);
+- }
+- '''
+-)
+-
+-if typeof.compiled() and typeof.returncode() == 1
+- conf.set('HAVE_TYPEOF', 1)
+- conf.set('HAVE_STATEMENT_EXPR', 1)
+-endif
++conf.set('HAVE_TYPEOF', 1)
++conf.set('HAVE_STATEMENT_EXPR', 1)
+
+ if target_machine.endian() == 'big'
+ conf.set('HAVE_BIG_ENDIAN', 1)
+--
+2.33.0
+
diff --git a/meta-oe/recipes-core/ndctl/ndctl_v73.bb b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
index c88d39297..e2049ce2f 100644
--- a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
+++ b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
@@ -13,7 +13,9 @@ inherit meson pkgconfig bash-completion systemd
SRCREV = "dd58d43458943d20ff063850670bf54a5242c9c5"
SRC_URI = "git://github.com/pmem/ndctl.git;branch=main;protocol=https \
file://0001-util-Correct-path-to-iniparser.h.patch \
- file://0001-meson-Use-pkg-config-to-detect-iniparser.patch"
+ file://0001-meson-Use-pkg-config-to-detect-iniparser.patch \
+ file://0001-Assume-typeof-exists-in-our-modern-gcc.patch \
+"
UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>v\d+(\.\d+)*)"
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [oe] [meta-oe][PATCH] ndctl: Remove run test of typeof
2022-04-08 19:42 [meta-oe][PATCH] ndctl: Remove run test of typeof Jeremy A. Puhlman
@ 2022-04-08 19:54 ` Khem Raj
2022-04-09 2:31 ` Jeremy Puhlman
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2022-04-08 19:54 UTC (permalink / raw)
To: openembedded-devel
there is a patch in master-next
https://lists.openembedded.org/g/openembedded-devel/message/96468
does this solve your issue ?
On 4/8/22 12:42 PM, Jeremy Puhlman wrote:
> ../git/meson.build:213:0: ERROR: Can not run test applications in this cross environment.
>
> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> ---
> ...sume-typeof-exists-in-our-modern-gcc.patch | 45 +++++++++++++++++++
> meta-oe/recipes-core/ndctl/ndctl_v73.bb | 4 +-
> 2 files changed, 48 insertions(+), 1 deletion(-)
> create mode 100644 meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
>
> diff --git a/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> new file mode 100644
> index 000000000..b47510a6b
> --- /dev/null
> +++ b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> @@ -0,0 +1,45 @@
> +From 3abfe16bf2eb89efe3c823a935a6752c4a5b99d1 Mon Sep 17 00:00:00 2001
> +From: "Jeremy A. Puhlman" <jpuhlman@mvista.com>
> +Date: Fri, 8 Apr 2022 19:31:02 +0000
> +Subject: [PATCH] Assume typeof exists in our modern gcc
> +
> +cc.run tests are not useful in a cross environment.
> +
> +Upstream-Status: Inappropriate [Assumes modern compiler]
> +Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> +---
> + meson.build | 18 ++----------------
> + 1 file changed, 2 insertions(+), 16 deletions(-)
> +
> +diff --git a/meson.build b/meson.build
> +index 42e11aa..e8d218b 100644
> +--- a/meson.build
> ++++ b/meson.build
> +@@ -210,22 +210,8 @@ conf.set('ENABLE_DESTRUCTIVE', get_option('destructive').enabled())
> + conf.set('ENABLE_LOGGING', get_option('logging').enabled())
> + conf.set('ENABLE_DEBUG', get_option('dbg').enabled())
> +
> +-typeof = cc.run('''
> +- int main() {
> +- struct {
> +- char a[16];
> +- } x;
> +- typeof(x) y;
> +-
> +- return sizeof(x) == sizeof(y);
> +- }
> +- '''
> +-)
> +-
> +-if typeof.compiled() and typeof.returncode() == 1
> +- conf.set('HAVE_TYPEOF', 1)
> +- conf.set('HAVE_STATEMENT_EXPR', 1)
> +-endif
> ++conf.set('HAVE_TYPEOF', 1)
> ++conf.set('HAVE_STATEMENT_EXPR', 1)
> +
> + if target_machine.endian() == 'big'
> + conf.set('HAVE_BIG_ENDIAN', 1)
> +--
> +2.33.0
> +
> diff --git a/meta-oe/recipes-core/ndctl/ndctl_v73.bb b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> index c88d39297..e2049ce2f 100644
> --- a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> +++ b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> @@ -13,7 +13,9 @@ inherit meson pkgconfig bash-completion systemd
> SRCREV = "dd58d43458943d20ff063850670bf54a5242c9c5"
> SRC_URI = "git://github.com/pmem/ndctl.git;branch=main;protocol=https \
> file://0001-util-Correct-path-to-iniparser.h.patch \
> - file://0001-meson-Use-pkg-config-to-detect-iniparser.patch"
> + file://0001-meson-Use-pkg-config-to-detect-iniparser.patch \
> + file://0001-Assume-typeof-exists-in-our-modern-gcc.patch \
> +"
>
> UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>v\d+(\.\d+)*)"
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96487): https://lists.openembedded.org/g/openembedded-devel/message/96487
> Mute This Topic: https://lists.openembedded.org/mt/90343683/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe] [meta-oe][PATCH] ndctl: Remove run test of typeof
2022-04-08 19:54 ` [oe] " Khem Raj
@ 2022-04-09 2:31 ` Jeremy Puhlman
2022-04-09 2:49 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Puhlman @ 2022-04-09 2:31 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Yeah I saw that later in the day, it addresses the same issue.
On Fri, Apr 8, 2022, 12:54 PM Khem Raj <raj.khem@gmail.com> wrote:
> there is a patch in master-next
>
> https://lists.openembedded.org/g/openembedded-devel/message/96468
>
> does this solve your issue ?
>
> On 4/8/22 12:42 PM, Jeremy Puhlman wrote:
> > ../git/meson.build:213:0: ERROR: Can not run test applications in this
> cross environment.
> >
> > Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> > ---
> > ...sume-typeof-exists-in-our-modern-gcc.patch | 45 +++++++++++++++++++
> > meta-oe/recipes-core/ndctl/ndctl_v73.bb | 4 +-
> > 2 files changed, 48 insertions(+), 1 deletion(-)
> > create mode 100644
> meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> >
> > diff --git
> a/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> > new file mode 100644
> > index 000000000..b47510a6b
> > --- /dev/null
> > +++
> b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
> > @@ -0,0 +1,45 @@
> > +From 3abfe16bf2eb89efe3c823a935a6752c4a5b99d1 Mon Sep 17 00:00:00 2001
> > +From: "Jeremy A. Puhlman" <jpuhlman@mvista.com>
> > +Date: Fri, 8 Apr 2022 19:31:02 +0000
> > +Subject: [PATCH] Assume typeof exists in our modern gcc
> > +
> > +cc.run tests are not useful in a cross environment.
> > +
> > +Upstream-Status: Inappropriate [Assumes modern compiler]
> > +Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> > +---
> > + meson.build | 18 ++----------------
> > + 1 file changed, 2 insertions(+), 16 deletions(-)
> > +
> > +diff --git a/meson.build b/meson.build
> > +index 42e11aa..e8d218b 100644
> > +--- a/meson.build
> > ++++ b/meson.build
> > +@@ -210,22 +210,8 @@ conf.set('ENABLE_DESTRUCTIVE',
> get_option('destructive').enabled())
> > + conf.set('ENABLE_LOGGING', get_option('logging').enabled())
> > + conf.set('ENABLE_DEBUG', get_option('dbg').enabled())
> > +
> > +-typeof = cc.run('''
> > +- int main() {
> > +- struct {
> > +- char a[16];
> > +- } x;
> > +- typeof(x) y;
> > +-
> > +- return sizeof(x) == sizeof(y);
> > +- }
> > +- '''
> > +-)
> > +-
> > +-if typeof.compiled() and typeof.returncode() == 1
> > +- conf.set('HAVE_TYPEOF', 1)
> > +- conf.set('HAVE_STATEMENT_EXPR', 1)
> > +-endif
> > ++conf.set('HAVE_TYPEOF', 1)
> > ++conf.set('HAVE_STATEMENT_EXPR', 1)
> > +
> > + if target_machine.endian() == 'big'
> > + conf.set('HAVE_BIG_ENDIAN', 1)
> > +--
> > +2.33.0
> > +
> > diff --git a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> > index c88d39297..e2049ce2f 100644
> > --- a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> > +++ b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
> > @@ -13,7 +13,9 @@ inherit meson pkgconfig bash-completion systemd
> > SRCREV = "dd58d43458943d20ff063850670bf54a5242c9c5"
> > SRC_URI = "git://github.com/pmem/ndctl.git;branch=main;protocol=https
> \
> > file://0001-util-Correct-path-to-iniparser.h.patch \
> > - file://0001-meson-Use-pkg-config-to-detect-iniparser.patch"
> > + file://0001-meson-Use-pkg-config-to-detect-iniparser.patch \
> > + file://0001-Assume-typeof-exists-in-our-modern-gcc.patch \
> > +"
> >
> > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>v\d+(\.\d+)*)"
> >
> >
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96488):
> https://lists.openembedded.org/g/openembedded-devel/message/96488
> Mute This Topic: https://lists.openembedded.org/mt/90343683/2167262
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> jpuhlman@mvista.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 6301 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe] [meta-oe][PATCH] ndctl: Remove run test of typeof
2022-04-09 2:31 ` Jeremy Puhlman
@ 2022-04-09 2:49 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2022-04-09 2:49 UTC (permalink / raw)
To: Jeremy Puhlman; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 4088 bytes --]
Cool, thanks!
On Fri, Apr 8, 2022 at 7:31 PM Jeremy Puhlman <jpuhlman@mvista.com> wrote:
> Yeah I saw that later in the day, it addresses the same issue.
>
> On Fri, Apr 8, 2022, 12:54 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>> there is a patch in master-next
>>
>> https://lists.openembedded.org/g/openembedded-devel/message/96468
>>
>> does this solve your issue ?
>>
>> On 4/8/22 12:42 PM, Jeremy Puhlman wrote:
>> > ../git/meson.build:213:0: ERROR: Can not run test applications in this
>> cross environment.
>> >
>> > Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
>> > ---
>> > ...sume-typeof-exists-in-our-modern-gcc.patch | 45 +++++++++++++++++++
>> > meta-oe/recipes-core/ndctl/ndctl_v73.bb | 4 +-
>> > 2 files changed, 48 insertions(+), 1 deletion(-)
>> > create mode 100644
>> meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
>> >
>> > diff --git
>> a/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
>> b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
>> > new file mode 100644
>> > index 000000000..b47510a6b
>> > --- /dev/null
>> > +++
>> b/meta-oe/recipes-core/ndctl/ndctl/0001-Assume-typeof-exists-in-our-modern-gcc.patch
>> > @@ -0,0 +1,45 @@
>> > +From 3abfe16bf2eb89efe3c823a935a6752c4a5b99d1 Mon Sep 17 00:00:00 2001
>> > +From: "Jeremy A. Puhlman" <jpuhlman@mvista.com>
>> > +Date: Fri, 8 Apr 2022 19:31:02 +0000
>> > +Subject: [PATCH] Assume typeof exists in our modern gcc
>> > +
>> > +cc.run tests are not useful in a cross environment.
>> > +
>> > +Upstream-Status: Inappropriate [Assumes modern compiler]
>> > +Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
>> > +---
>> > + meson.build | 18 ++----------------
>> > + 1 file changed, 2 insertions(+), 16 deletions(-)
>> > +
>> > +diff --git a/meson.build b/meson.build
>> > +index 42e11aa..e8d218b 100644
>> > +--- a/meson.build
>> > ++++ b/meson.build
>> > +@@ -210,22 +210,8 @@ conf.set('ENABLE_DESTRUCTIVE',
>> get_option('destructive').enabled())
>> > + conf.set('ENABLE_LOGGING', get_option('logging').enabled())
>> > + conf.set('ENABLE_DEBUG', get_option('dbg').enabled())
>> > +
>> > +-typeof = cc.run('''
>> > +- int main() {
>> > +- struct {
>> > +- char a[16];
>> > +- } x;
>> > +- typeof(x) y;
>> > +-
>> > +- return sizeof(x) == sizeof(y);
>> > +- }
>> > +- '''
>> > +-)
>> > +-
>> > +-if typeof.compiled() and typeof.returncode() == 1
>> > +- conf.set('HAVE_TYPEOF', 1)
>> > +- conf.set('HAVE_STATEMENT_EXPR', 1)
>> > +-endif
>> > ++conf.set('HAVE_TYPEOF', 1)
>> > ++conf.set('HAVE_STATEMENT_EXPR', 1)
>> > +
>> > + if target_machine.endian() == 'big'
>> > + conf.set('HAVE_BIG_ENDIAN', 1)
>> > +--
>> > +2.33.0
>> > +
>> > diff --git a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
>> b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
>> > index c88d39297..e2049ce2f 100644
>> > --- a/meta-oe/recipes-core/ndctl/ndctl_v73.bb
>> > +++ b/meta-oe/recipes-core/ndctl/ndctl_v73.bb
>> > @@ -13,7 +13,9 @@ inherit meson pkgconfig bash-completion systemd
>> > SRCREV = "dd58d43458943d20ff063850670bf54a5242c9c5"
>> > SRC_URI = "git://github.com/pmem/ndctl.git;branch=main;protocol=https
>> \
>> > file://0001-util-Correct-path-to-iniparser.h.patch \
>> > - file://0001-meson-Use-pkg-config-to-detect-iniparser.patch"
>> > + file://0001-meson-Use-pkg-config-to-detect-iniparser.patch \
>> > + file://0001-Assume-typeof-exists-in-our-modern-gcc.patch \
>> > +"
>> >
>> > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>v\d+(\.\d+)*)"
>> >
>> >
>> >
>> >
>> >
>> >
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>>
> View/Reply Online (#96488):
>> https://lists.openembedded.org/g/openembedded-devel/message/96488
>> Mute This Topic: https://lists.openembedded.org/mt/90343683/2167262
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
>> jpuhlman@mvista.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>
[-- Attachment #2: Type: text/html, Size: 7023 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-11 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 19:42 [meta-oe][PATCH] ndctl: Remove run test of typeof Jeremy A. Puhlman
2022-04-08 19:54 ` [oe] " Khem Raj
2022-04-09 2:31 ` Jeremy Puhlman
2022-04-09 2:49 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.