[meta-browser][PATCHv2] chromium: Fix ILL_ILLOPN signal in sandbox

[meta-browser][PATCHv2] chromium: Fix ILL_ILLOPN signal in sandbox

[Davis, Michael]

Fix Aw Snap! error when running chromium 52 in Morty with sandbox enabled.

Based on upstream qtwebengine-chromium commit b12ffcd411d4776f7120ccecb3be34344d930d2b
http://code.qt.io/cgit/qt/qtwebengine-chromium.git/commit/?h=49-based&id=b12ffcd411d4776f7120ccecb3be34344d930d2b

Signed-off-by: Michael Davis <michael.davis@essvote.com>
---
 .../chromium/chromium/chromium/unset-madv-free.patch      | 15 +++++++++++++++
 recipes-browser/chromium/chromium_52.0.2743.76.bb         |  1 +
 2 files changed, 16 insertions(+)
 create mode 100644 recipes-browser/chromium/chromium/chromium/unset-madv-free.patch

diff --git a/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch b/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
new file mode 100644
index 0000000..15d4982
--- /dev/null
+++ b/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
@@ -0,0 +1,15 @@
+diff -Naur chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
+--- chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-07-15 17:02:49.000000000 -0500
++++ chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-11-18 09:13:01.109731385 -0600
+@@ -41,6 +41,11 @@
+ #include <errno.h>
+ #include <sys/mman.h>
+ 
++#if OS(LINUX) && defined(MADV_FREE)
++// Added in Linux 4.5, but it breaks the sandbox.
++#undef MADV_FREE
++#endif
++
+ #ifndef MADV_FREE
+ #define MADV_FREE MADV_DONTNEED
+ #endif
diff --git a/recipes-browser/chromium/chromium_52.0.2743.76.bb b/recipes-browser/chromium/chromium_52.0.2743.76.bb
index 14b519c..5be3c32 100644
--- a/recipes-browser/chromium/chromium_52.0.2743.76.bb
+++ b/recipes-browser/chromium/chromium_52.0.2743.76.bb
@@ -9,6 +9,7 @@ SRC_URI += "\
         file://0005-Override-root-filesystem-access-restriction.patch \
         file://chromium/0011-Replace-readdir_r-with-readdir.patch \
         file://chromium/remove-Werror.patch \
+        file://chromium/unset-madv-free.patch \
         ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \
         ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \
 "
-- 
2.5.5

Re: [meta-browser][PATCHv2] chromium: Fix ILL_ILLOPN signal in sandbox

[Khem Raj]

On Fri, Nov 18, 2016 at 11:38 AM, Davis, Michael
<michael.davis@essvote.com> wrote:
> Fix Aw Snap! error when running chromium 52 in Morty with sandbox enabled.
>
> Based on upstream qtwebengine-chromium commit b12ffcd411d4776f7120ccecb3be34344d930d2b
> http://code.qt.io/cgit/qt/qtwebengine-chromium.git/commit/?h=49-based&id=b12ffcd411d4776f7120ccecb3be34344d930d2b

Thanks. This looks good

>
> Signed-off-by: Michael Davis <michael.davis@essvote.com>
> ---
>  .../chromium/chromium/chromium/unset-madv-free.patch      | 15 +++++++++++++++
>  recipes-browser/chromium/chromium_52.0.2743.76.bb         |  1 +
>  2 files changed, 16 insertions(+)
>  create mode 100644 recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
>
> diff --git a/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch b/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
> new file mode 100644
> index 0000000..15d4982
> --- /dev/null
> +++ b/recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
> @@ -0,0 +1,15 @@
> +diff -Naur chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
> +--- chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp    2016-07-15 17:02:49.000000000 -0500
> ++++ chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp   2016-11-18 09:13:01.109731385 -0600
> +@@ -41,6 +41,11 @@
> + #include <errno.h>
> + #include <sys/mman.h>
> +
> ++#if OS(LINUX) && defined(MADV_FREE)
> ++// Added in Linux 4.5, but it breaks the sandbox.
> ++#undef MADV_FREE
> ++#endif
> ++
> + #ifndef MADV_FREE
> + #define MADV_FREE MADV_DONTNEED
> + #endif
> diff --git a/recipes-browser/chromium/chromium_52.0.2743.76.bb b/recipes-browser/chromium/chromium_52.0.2743.76.bb
> index 14b519c..5be3c32 100644
> --- a/recipes-browser/chromium/chromium_52.0.2743.76.bb
> +++ b/recipes-browser/chromium/chromium_52.0.2743.76.bb
> @@ -9,6 +9,7 @@ SRC_URI += "\
>          file://0005-Override-root-filesystem-access-restriction.patch \
>          file://chromium/0011-Replace-readdir_r-with-readdir.patch \
>          file://chromium/remove-Werror.patch \
> +        file://chromium/unset-madv-free.patch \
>          ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \
>          ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \
>  "
> --
> 2.5.5
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel