[PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]


Add patch from commit 96b1b5c127e9e0e637aaf7948cf3330a94a5cd57 to cross-localedef-native
to avoid broken images built with ENABLE_BINARY_LOCALE_GENERATION set to 1:

    $ sh -c "export LANG=de_DE; ls -la"
    sh: loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
    Aborted

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 meta/recipes-core/glibc/cross-localedef-native_2.22.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.22.bb b/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
index 03be9c0..3aefe74 100644
--- a/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
+++ b/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
@@ -20,6 +20,7 @@ GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git"
 SRC_URI = "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \
            git://github.com/kraj/localedef;branch=master;name=localedef;destsuffix=git/localedef \
            file://fix_for_centos_5.8.patch \
+	   file://strcoll-Remove-incorrect-STRDIFF-based-optimization-.patch \
            ${EGLIBCPATCHES} \
 "
 EGLIBCPATCHES = "\
--
1.9.1

--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

On 5 February 2016 at 10:25, Jens Rehsack <rehsack@gmail.com> wrote:

> Add patch from commit 96b1b5c127e9e0e637aaf7948cf3330a94a5cd57 to
> cross-localedef-native
> to avoid broken images built with ENABLE_BINARY_LOCALE_GENERATION set to 1:
>

This impacts master too, so I've merged this into ross/mut and endorse it
for Jethro.

I've also a filed a bug against QA so we notice this breaking on the
autobuilder...

Ross

[-- Attachment #2: Type: text/html, Size: 906 bytes --]

Re: [PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Andreas Müller]

On Fri, Feb 5, 2016 at 3:26 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 5 February 2016 at 10:25, Jens Rehsack <rehsack@gmail.com> wrote:
>>
>> Add patch from commit 96b1b5c127e9e0e637aaf7948cf3330a94a5cd57 to
>> cross-localedef-native
>> to avoid broken images built with ENABLE_BINARY_LOCALE_GENERATION set to
>> 1:
>
>
> This impacts master too, so I've merged this into ross/mut and endorse it
> for Jethro.
>
> I've also a filed a bug against QA so we notice this breaking on the
> autobuilder...
>
> Ross
>
Meanwhile I've build an image and tested: GTK's i18n is back - thanks
very much Jens!!

Andreas

Re: [PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]


> Am 05.02.2016 um 15:26 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> 
> On 5 February 2016 at 10:25, Jens Rehsack <rehsack@gmail.com> wrote:
> Add patch from commit 96b1b5c127e9e0e637aaf7948cf3330a94a5cd57 to cross-localedef-native
> to avoid broken images built with ENABLE_BINARY_LOCALE_GENERATION set to 1:
> 
> This impacts master too, so I've merged this into ross/mut and endorse it for Jethro.

I meant I've seen an upgrade to glibc-2.23 on master. For master I suggest a patch
which forces cross-localedef-native and glibc share the same glibc-sources.

> I've also a filed a bug against QA so we notice this breaking on the autobuilder...

Cool, thanks.

Cheers
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Khem Raj]

On Fri, Feb 5, 2016 at 2:25 AM, Jens Rehsack <rehsack@gmail.com> wrote:
>
> Add patch from commit 96b1b5c127e9e0e637aaf7948cf3330a94a5cd57 to cross-localedef-native
> to avoid broken images built with ENABLE_BINARY_LOCALE_GENERATION set to 1:
>

can you send a github pull request to include this patch into
cross-localedef too ?

>     $ sh -c "export LANG=de_DE; ls -la"
>     sh: loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
>     Aborted
>
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>  meta/recipes-core/glibc/cross-localedef-native_2.22.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.22.bb b/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
> index 03be9c0..3aefe74 100644
> --- a/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
> +++ b/meta/recipes-core/glibc/cross-localedef-native_2.22.bb
> @@ -20,6 +20,7 @@ GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git"
>  SRC_URI = "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \
>             git://github.com/kraj/localedef;branch=master;name=localedef;destsuffix=git/localedef \
>             file://fix_for_centos_5.8.patch \
> +          file://strcoll-Remove-incorrect-STRDIFF-based-optimization-.patch \
>             ${EGLIBCPATCHES} \
>  "
>  EGLIBCPATCHES = "\
> --
> 1.9.1
>
> --
> Jens Rehsack - rehsack@gmail.com
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH][jethro] cross-localedef-native: add ABI breaking glibc patch

[Alexander Kanavin]

On 02/05/2016 04:26 PM, Burton, Ross wrote:

> This impacts master too, so I've merged this into ross/mut and endorse
> it for Jethro.
>
> I've also a filed a bug against QA so we notice this breaking on the
> autobuilder...

Yes please; we have all the needed infrastructure to notice these 
regressions via automated testing before they make their way into master.

Alex