[PATCH] efibootmgr: Pass correct flags to compiler from pkg-config

[PATCH] efibootmgr: Pass correct flags to compiler from pkg-config

[Khem Raj]

efivar.h is in usr/include/efirvar directory so it should be
added to include search path via -I to compiler cmdline to fix

make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'.  Stop.
| make[1]: *** Waiting for unfinished jobs....

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
index 0e5a81e316..2f8fa34ee7 100644
--- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
+++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
@@ -22,8 +22,7 @@ inherit pkgconfig
 # The directory under the ESP that the default bootloader is found in.  When
 # wic uses a subdirectory, this should use the same one too.
 EFIDIR ?= "/"
-
-EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
+EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
 
 CFLAGS += " -Wno-error"
 
-- 
2.22.0

Re: [PATCH] efibootmgr: Pass correct flags to compiler from pkg-config

[Burton, Ross]

So why does this build for me?

Ross

On Mon, 24 Jun 2019 at 09:30, Khem Raj <raj.khem@gmail.com> wrote:
>
> efivar.h is in usr/include/efirvar directory so it should be
> added to include search path via -I to compiler cmdline to fix
>
> make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'.  Stop.
> | make[1]: *** Waiting for unfinished jobs....
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> index 0e5a81e316..2f8fa34ee7 100644
> --- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> +++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> @@ -22,8 +22,7 @@ inherit pkgconfig
>  # The directory under the ESP that the default bootloader is found in.  When
>  # wic uses a subdirectory, this should use the same one too.
>  EFIDIR ?= "/"
> -
> -EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
> +EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
>
>  CFLAGS += " -Wno-error"
>
> --
> 2.22.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] efibootmgr: Pass correct flags to compiler from pkg-config

[Khem Raj]

On Mon, Jun 24, 2019 at 2:11 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> So why does this build for me?

This happens when TOOLCHAIN = "clang" which is when using meta-clang
when using TOOLCHAIN = "gcc" all works

>
> Ross
>
> On Mon, 24 Jun 2019 at 09:30, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > efivar.h is in usr/include/efirvar directory so it should be
> > added to include search path via -I to compiler cmdline to fix
> >
> > make[1]: *** No rule to make target 'efivar.h', needed by 'efibootmgr.o'.  Stop.
> > | make[1]: *** Waiting for unfinished jobs....
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > index 0e5a81e316..2f8fa34ee7 100644
> > --- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > +++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > @@ -22,8 +22,7 @@ inherit pkgconfig
> >  # The directory under the ESP that the default bootloader is found in.  When
> >  # wic uses a subdirectory, this should use the same one too.
> >  EFIDIR ?= "/"
> > -
> > -EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}'"
> > +EXTRA_OEMAKE += "'EFIDIR=${EFIDIR}' 'CFLAGS=${CFLAGS} `pkg-config --cflags efivar`'"
> >
> >  CFLAGS += " -Wno-error"
> >
> > --
> > 2.22.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core