* [meta-oe][PATCH] glm: Fix packaging for header-only recipe
@ 2021-01-29 1:42 Tom Hochstein
2021-01-29 4:57 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Tom Hochstein @ 2021-01-29 1:42 UTC (permalink / raw)
To: openembedded-core; +Cc: Tom Hochstein
Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This
allows the SDK to be created properly when there is an RDEPENDS on glm.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
---
meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb b/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
index e2f4dbebc..019e6257d 100644
--- a/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
+++ b/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
@@ -34,6 +34,7 @@ do_install() {
}
-RDEPENDS_${PN}-dev = ""
+# This is a header-only library, so the main package will be empty.
+ALLOW_EMPTY_${PN} = "1"
BBCLASSEXTEND = "native"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] glm: Fix packaging for header-only recipe
2021-01-29 1:42 [meta-oe][PATCH] glm: Fix packaging for header-only recipe Tom Hochstein
@ 2021-01-29 4:57 ` Khem Raj
2021-01-29 16:05 ` Tom Hochstein
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-01-29 4:57 UTC (permalink / raw)
To: Tom Hochstein; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Thu, Jan 28, 2021 at 5:44 PM Tom Hochstein <tom.hochstein@nxp.com> wrote:
> Set ALLOW_EMPTY for the main package to "1" for this header-only recipe.
> This
> allows the SDK to be created properly when there is an RDEPENDS on glm.
Runtime dependency on a header only package seems a bit iffy it’s perhaps
better to depend on glm-dev perhaps ?
>
>
> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> ---
> meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
> b/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
> index e2f4dbebc..019e6257d 100644
> --- a/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
> +++ b/meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb
> @@ -34,6 +34,7 @@ do_install() {
>
> }
>
> -RDEPENDS_${PN}-dev = ""
> +# This is a header-only library, so the main package will be empty.
> +ALLOW_EMPTY_${PN} = "1"
>
> BBCLASSEXTEND = "native"
> --
> 2.17.1
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 2091 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] glm: Fix packaging for header-only recipe
2021-01-29 4:57 ` [OE-core] " Khem Raj
@ 2021-01-29 16:05 ` Tom Hochstein
2021-01-29 16:32 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Tom Hochstein @ 2021-01-29 16:05 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On Thu, Jan 28, 2021 at 10:57 PM Khem Raj <mailto:raj.khem@gmail.com> wrote:
>
> On Thu, Jan 28, 2021 at 5:44 PM Tom Hochstein <mailto:tom.hochstein@nxp.com> wrote:
> > Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This
> > allows the SDK to be created properly when there is an RDEPENDS on glm.
>
> Runtime dependency on a header only package seems a bit iffy it's perhaps better to depend on glm-dev perhaps ?
Well, it's all iffy in my mind since these are just different workarounds for the root problem that header-only packages are not included in the SDK. If you think including the headers in the image is the better workaround, then I will switch to that.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] glm: Fix packaging for header-only recipe
2021-01-29 16:05 ` Tom Hochstein
@ 2021-01-29 16:32 ` Otavio Salvador
0 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2021-01-29 16:32 UTC (permalink / raw)
To: Tom Hochstein; +Cc: Khem Raj, openembedded-core
Em sex., 29 de jan. de 2021 às 13:06, Tom Hochstein
<tom.hochstein@nxp.com> escreveu:
> On Thu, Jan 28, 2021 at 10:57 PM Khem Raj <mailto:raj.khem@gmail.com> wrote:
> > On Thu, Jan 28, 2021 at 5:44 PM Tom Hochstein <mailto:tom.hochstein@nxp.com> wrote:
> > > Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This
> > > allows the SDK to be created properly when there is an RDEPENDS on glm.
> >
> > Runtime dependency on a header only package seems a bit iffy it's perhaps better to depend on glm-dev perhaps ?
>
> Well, it's all iffy in my mind since these are just different workarounds for the root problem that header-only packages are not included in the SDK. If you think including the headers in the image is the better workaround, then I will switch to that.
The allow empty seems to be the right workaround here as it allow
people to consistently use the `dev-pkgs` filter to populate the SDK.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-29 16:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 1:42 [meta-oe][PATCH] glm: Fix packaging for header-only recipe Tom Hochstein
2021-01-29 4:57 ` [OE-core] " Khem Raj
2021-01-29 16:05 ` Tom Hochstein
2021-01-29 16:32 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.