* [meta-oe][thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules
@ 2019-08-02 7:02 Arturo Buzarra
2019-08-02 18:42 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Arturo Buzarra @ 2019-08-02 7:02 UTC (permalink / raw)
To: openembedded-devel
Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
a package dependency due to lvm2-udevrules needs dmsetup, however
dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2:
libdevicemapper package needs udev rules and dmsetup"), so this
dependency should be only for libdevmapper instead of the full package.
With the current implementation, a package that has a dependency with
lvm2-udev rules will include also many unnecessary packages like lvm2,
lvm2-scripts, etc. and their dependencies.
Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
---
meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
index 7bd7b09d8..08287e358 100644
--- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
+++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
@@ -48,11 +48,11 @@ FILES_${PN}-scripts = " \
${sbindir}/lvmdump \
"
# Specified explicitly for the udev rules, just in case that it does not get picked
# up automatically:
FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
-RDEPENDS_${PN}-udevrules = "${PN}"
+RDEPENDS_${PN}-udevrules = "libdevmapper"
RDEPENDS_${PN}_append_class-target = " libdevmapper"
RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
RRECOMMENDS_${PN}_class-target = "${PN}-scripts (= ${EXTENDPKGV})"
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-oe][thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules
2019-08-02 7:02 [meta-oe][thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules Arturo Buzarra
@ 2019-08-02 18:42 ` Khem Raj
2019-08-05 8:45 ` [meta-oe][PATCH v2] " Arturo Buzarra
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2019-08-02 18:42 UTC (permalink / raw)
To: Arturo Buzarra; +Cc: openembeded-devel
can you send it rebased on top of master
On Fri, Aug 2, 2019 at 12:02 AM Arturo Buzarra <arturo.buzarra@digi.com> wrote:
>
> Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
> a package dependency due to lvm2-udevrules needs dmsetup, however
> dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2:
> libdevicemapper package needs udev rules and dmsetup"), so this
> dependency should be only for libdevmapper instead of the full package.
>
> With the current implementation, a package that has a dependency with
> lvm2-udev rules will include also many unnecessary packages like lvm2,
> lvm2-scripts, etc. and their dependencies.
>
> Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
> ---
> meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> index 7bd7b09d8..08287e358 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> +++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.180.bb
> @@ -48,11 +48,11 @@ FILES_${PN}-scripts = " \
> ${sbindir}/lvmdump \
> "
> # Specified explicitly for the udev rules, just in case that it does not get picked
> # up automatically:
> FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
> -RDEPENDS_${PN}-udevrules = "${PN}"
> +RDEPENDS_${PN}-udevrules = "libdevmapper"
> RDEPENDS_${PN}_append_class-target = " libdevmapper"
> RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
>
> RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
> RRECOMMENDS_${PN}_class-target = "${PN}-scripts (= ${EXTENDPKGV})"
> --
> 2.22.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [meta-oe][PATCH v2] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules
2019-08-02 18:42 ` Khem Raj
@ 2019-08-05 8:45 ` Arturo Buzarra
0 siblings, 0 replies; 3+ messages in thread
From: Arturo Buzarra @ 2019-08-05 8:45 UTC (permalink / raw)
To: openembedded-devel
Commit c6e963f9e ("lvm2: Add RDEPEND on lvm2 to lvm2-udevrules") added
a package dependency due to lvm2-udevrules needs dmsetup, however
dmsetup was moved to libdevmapper in commit 269d009a81d4 ("lvm2:
libdevicemapper package needs udev rules and dmsetup"), so this
dependency should be only for libdevmapper instead of the full package.
With the current implementation, a package that has a dependency with
lvm2-udev rules will include also many unnecessary packages like lvm2,
lvm2-scripts, etc. and their dependencies.
Signed-off-by: Arturo Buzarra <arturo.buzarra@digi.com>
---
meta-oe/recipes-support/lvm2/lvm2_2.03.02.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.03.02.bb b/meta-oe/recipes-support/lvm2/lvm2_2.03.02.bb
index e2ce95c81..4ae0a62ab 100644
--- a/meta-oe/recipes-support/lvm2/lvm2_2.03.02.bb
+++ b/meta-oe/recipes-support/lvm2/lvm2_2.03.02.bb
@@ -48,11 +48,11 @@ FILES_${PN}-scripts = " \
${sbindir}/lvmdump \
"
# Specified explicitly for the udev rules, just in case that it does not get picked
# up automatically:
FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
-RDEPENDS_${PN}-udevrules = "${PN}"
+RDEPENDS_${PN}-udevrules = "libdevmapper"
RDEPENDS_${PN}_append_class-target = " libdevmapper"
RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
RRECOMMENDS_${PN}_class-target = "${PN}-scripts (= ${EXTENDPKGV})"
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 7:02 [meta-oe][thud][PATCH] lvm2: Fix RDEPEND on lvm2 to lvm2-udevrules Arturo Buzarra
2019-08-02 18:42 ` Khem Raj
2019-08-05 8:45 ` [meta-oe][PATCH v2] " Arturo Buzarra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.